-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] Support HTTP Common options for synthetics integration #111482
Comments
Pinging @elastic/uptime (Team:uptime) |
@liciavale @drewpost do we need any explicit design here? |
I'm happy with re-using the patterns established elsewhere in the integration for this. |
Hey @andrewvc thanks for this. What does it happen when a user unselects the Enable TLS configuration? Do the settings below belong to this checkbox? |
@liciavale To answer your questions, the settings below indeed belong to the checkbox and only appear when the checkbox is checked. I think the "Advanced Zip Url" panel could work well, as we could only show the panel when zip url is selected. |
sounds good! Thanks @dominiqueclarke |
@andrewvc @dominiqueclarke @drewpost I found this pattern that we could reuse here: |
i wasn't able to make zipurl configuration work while doing POST FF testing, inline scripe, and the script recorder format works pretty well for me. Zip url without enable tls options and using default tls option, in both cases it didn't work for me. |
Tested it again and this time it works, so Post FF Testing looks good !! |
With elastic/beats#27699 we now support a variety of new options for TLS and proxies when using
zip_url
sources for synthetics. These options only affect the download of the zip, not the operation of the browser. We should add these options to the synthetics integration UI.The needed fields are documented fully in the beats PR. The short summary is as follows)
proxy_url
fieldI think we can steal from the following portions of the HTTP integration UI with some modifications. I've included screenshots of that UI at the bottom of this ticket.
We will need to determine how this fits into the form, and crucially, how to communicate that these options affect the download of the zip, not the operation of the browser. I propose we add an expandable "Advanced Zip URL Settings" section with these settings put them one after the other, but am open to other ideas.
The text was updated successfully, but these errors were encountered: