Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] Support HTTP Common options for synthetics integration #111482

Closed
andrewvc opened this issue Sep 8, 2021 · 9 comments · Fixed by #112554
Closed

[Uptime] Support HTTP Common options for synthetics integration #111482

andrewvc opened this issue Sep 8, 2021 · 9 comments · Fixed by #112554
Assignees
Labels
enhancement New value added to drive a business result needs design refined Issue refined, ready to work on Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0

Comments

@andrewvc
Copy link
Contributor

andrewvc commented Sep 8, 2021

With elastic/beats#27699 we now support a variety of new options for TLS and proxies when using zip_url sources for synthetics. These options only affect the download of the zip, not the operation of the browser. We should add these options to the synthetics integration UI.

The needed fields are documented fully in the beats PR. The short summary is as follows)

  1. All TLS fields (same fields as in the HTTP UI for handling TLS). We should share a component here.
  2. The proxy_url field

I think we can steal from the following portions of the HTTP integration UI with some modifications. I've included screenshots of that UI at the bottom of this ticket.

We will need to determine how this fits into the form, and crucially, how to communicate that these options affect the download of the zip, not the operation of the browser. I propose we add an expandable "Advanced Zip URL Settings" section with these settings put them one after the other, but am open to other ideas.

image
image

@andrewvc andrewvc added enhancement New value added to drive a business result Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0 labels Sep 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@andrewvc
Copy link
Contributor Author

andrewvc commented Sep 8, 2021

@liciavale @drewpost do we need any explicit design here?

@drewpost
Copy link

drewpost commented Sep 8, 2021

I'm happy with re-using the patterns established elsewhere in the integration for this.

@liciavale
Copy link
Contributor

Hey @andrewvc thanks for this. What does it happen when a user unselects the Enable TLS configuration? Do the settings below belong to this checkbox?

@dominiqueclarke
Copy link
Contributor

@liciavale To answer your questions, the settings below indeed belong to the checkbox and only appear when the checkbox is checked.

I think the "Advanced Zip Url" panel could work well, as we could only show the panel when zip url is selected.

@liciavale
Copy link
Contributor

sounds good! Thanks @dominiqueclarke

@liciavale
Copy link
Contributor

liciavale commented Sep 9, 2021

@andrewvc @dominiqueclarke @drewpost I found this pattern that we could reuse here:
q1kcHifz6g
Wdyt?

@shahzad31
Copy link
Contributor

i wasn't able to make zipurl configuration work while doing POST FF testing, inline scripe, and the script recorder format works pretty well for me.

Zip url without enable tls options and using default tls option, in both cases it didn't work for me.

@shahzad31
Copy link
Contributor

Tested it again and this time it works, so Post FF Testing looks good !!

@zube zube bot removed the [zube]: Done label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result needs design refined Issue refined, ready to work on Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.16.0
Projects
None yet
7 participants