Fix missing icons in Visualize listing. #11243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcenizal
added
Feature:Visualizations
thomasneirynck
approved these changes
Apr 14, 2017
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Apr 14, 2017
* Fix StatusText component so that it supports image icons. * Fix missing icons in Visualize listing. Support both icons and images.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Apr 14, 2017
* Fix StatusText component so that it supports image icons. * Fix missing icons in Visualize listing. Support both icons and images.
This was referenced Apr 14, 2017
cjcenizal
added a commit
that referenced
this pull request
Apr 14, 2017
cjcenizal
added a commit
that referenced
this pull request
Apr 14, 2017
cjcenizal
added
release_note:enhancement
release_note:fix
and removed
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11235
Summary: When we implemented the new Visualization Wizard UI, we switched from using font icons to SVG images to represent each visualization type. However, we forgot to update the Visualize landing page table to use these SVG images.
Some of these icons are illegible at the smaller size. I already pinged @alt74 about this.