Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The visualization type icon is no longer on the visualization landing page #11235

Closed
trevan opened this issue Apr 13, 2017 · 4 comments
Closed

The visualization type icon is no longer on the visualization landing page #11235

trevan opened this issue Apr 13, 2017 · 4 comments
Assignees
@cjcenizal
Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@trevan
Copy link
Contributor

trevan commented Apr 13, 2017

It looks like after the change to the gallery style of the visualization create page, the icon was removed from the visualization definition. Now, when you go to the visualization landing page, it just has the type in string instead of also showing the icon.
@cjcenizal
Copy link
Contributor

@trevan Could you please include a screenshot?

@cjcenizal cjcenizal added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Feature:Visualizations Generic visualization features (in case no more specific feature label is available) bug Fixes for quality problems that affect the customer experience labels Apr 13, 2017
@trevan
Copy link
Contributor Author

trevan commented Apr 13, 2017

Here's a screenshot of master:

screen shot 2017-04-13 at 1 53 49 pm

Here's a screenshot from the 5.3 branch:

screen shot 2017-04-13 at 2 00 20 pm

14ed2e5 is the commit that removed the "icon" from the vis type objects.

@cjcenizal
Copy link
Contributor

Ahhh great catch!! Ironically I'm the one who both added the icons to the table, promptly forgot they were used there, and then broke them in the commit you linked to. Guess this one's on my plate... 😊

@cjcenizal cjcenizal self-assigned this Apr 13, 2017
@cjcenizal cjcenizal mentioned this issue Apr 13, 2017
Merged
@cjcenizal
Copy link
Contributor

Fixed by #11243

@cjcenizal cjcenizal reopened this Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjcenizal cjcenizal

Labels
bug Fixes for quality problems that affect the customer experience Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjcenizal @trevan