-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes edit view to json read-only view #112034
Changes from 23 commits
74e910a
0b25760
238f6da
9dfde70
8e31205
148a2b9
1110ff3
8c92317
e2c7143
e091640
b31a0a8
3c89d0b
3f2b30d
dac2f76
8df5007
9de3eb1
121283e
2c19acc
3cc2504
7b748d0
ad1d088
52f2261
e703655
940588d
8c75ad8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,9 +20,6 @@ export const searchSavedObjectType: SavedObjectsType = { | |
getTitle(obj) { | ||
return obj.attributes.title; | ||
}, | ||
getEditUrl(obj) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Allows us to decouple the loaders from the saved objects management page and still render the underlying saved object in the SOM Inspect view. |
||
return `/management/kibana/objects/savedSearches/${encodeURIComponent(obj.id)}`; | ||
}, | ||
getInAppUrl(obj) { | ||
return { | ||
path: `/app/discover#/view/${encodeURIComponent(obj.id)}`, | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -173,8 +173,8 @@ export class EmbeddablePublicPlugin implements Plugin<EmbeddableSetup, Embeddabl | |
); | ||
|
||
const commonContract: CommonEmbeddableStartContract = { | ||
getEmbeddableFactory: (this | ||
.getEmbeddableFactory as unknown) as CommonEmbeddableStartContract['getEmbeddableFactory'], | ||
getEmbeddableFactory: this | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. prettier fix after #112359 |
||
.getEmbeddableFactory as unknown as CommonEmbeddableStartContract['getEmbeddableFactory'], | ||
getEnhancement: this.getEnhancement, | ||
}; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -39,7 +39,7 @@ beforeEach(async () => { | |
|
||
const contactCardFactory = new ContactCardEmbeddableFactory( | ||
uiActions.executeTriggerActions, | ||
({} as unknown) as OverlayStart | ||
{} as unknown as OverlayStart | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. prettier fix after #112359 |
||
); | ||
setup.registerEmbeddableFactory(contactCardFactory.type, contactCardFactory); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,8 +45,8 @@ export class EmbeddableServerPlugin implements Plugin<EmbeddableSetup, Embeddabl | |
|
||
public setup(core: CoreSetup) { | ||
const commonContract: CommonEmbeddableStartContract = { | ||
getEmbeddableFactory: (this | ||
.getEmbeddableFactory as unknown) as CommonEmbeddableStartContract['getEmbeddableFactory'], | ||
getEmbeddableFactory: this | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. prettier fix after #112359 |
||
.getEmbeddableFactory as unknown as CommonEmbeddableStartContract['getEmbeddableFactory'], | ||
getEnhancement: this.getEnhancement, | ||
}; | ||
|
||
|
@@ -68,8 +68,8 @@ export class EmbeddableServerPlugin implements Plugin<EmbeddableSetup, Embeddabl | |
|
||
public start(core: CoreStart) { | ||
const commonContract: CommonEmbeddableStartContract = { | ||
getEmbeddableFactory: (this | ||
.getEmbeddableFactory as unknown) as CommonEmbeddableStartContract['getEmbeddableFactory'], | ||
getEmbeddableFactory: this | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. prettier fix after #112359 |
||
.getEmbeddableFactory as unknown as CommonEmbeddableStartContract['getEmbeddableFactory'], | ||
getEnhancement: this.getEnhancement, | ||
}; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,12 +62,11 @@ export const mountManagementSection = async ({ | |
<I18nProvider> | ||
<Router history={history}> | ||
<Switch> | ||
<Route path={'/:service/:id'} exact={true}> | ||
<Route path={'/:type/:id'} exact={true}> | ||
<RedirectToHomeIfUnauthorized> | ||
<Suspense fallback={<EuiLoadingSpinner />}> | ||
<SavedObjectsEditionPage | ||
coreStart={coreStart} | ||
Comment on lines
+65
to
69
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Um, good point! I'll double check to make sure we're not using the We have an open issue to handle decoupling the SOM from the SOL, so maybe we should defer the cleanup to a different PR to play it safe? I've realized small changes in one area have some unexpected downstream consequences (as with most things related to legacy code and saved objects 😆 ). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've taken a stab at removing the |
||
serviceRegistry={serviceRegistry} | ||
setBreadcrumbs={setBreadcrumbs} | ||
history={history} | ||
/> | ||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Allows us to decouple the loaders from the saved objects management page and still render the underlying saved object in the SOM Inspect view.
We were using the loaders to map from
savedDashboards
back todashboard
but we're aiming at removing the dependency on the loaders in the saved objects management plugin.