Changes edit view to json read-only view #112034

TinaHeiligers · 2021-09-13T23:28:32Z

Resolves #59588
Historically, we needed a way to update index pattern references after importing visualizations and added a way to edit the raw JSON of a saved object.
Now that import handles updating index pattern references, we don't need to support editing raw JSON in the UI anymore.
Given that there wasn't any validation on the edits in the first place, removing the option to edit the raw JSON should help to reduce the chance of Kibana breaking and/or migration failures during upgrades.

This PR changes the Inspect view in saved objects management to a read-only JSON view that's available for all saved objects.

Table view:

Flyout view:

View with all privileges:

View with read-only privileges:

Other changes:

Adds copy-to-clipboard functionality (will copy the entire object JSON)
Adds link to the saved objects API docs in the 'Not Found' callout

The following is a list of changes that should be handled as follow up issues. making the changes in this PR would make it more difficult to review.

Not done:

Change all filenames from *_edit_* to *_inspect_* (this will make the PR more difficult to review)
Remove client side SO mapping
Update saved_objects_page for functional tests (we no longer conditionally render the context menu, it is always available)

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Risk Matrix

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	Low	Functional tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.

For maintainers

This was checked for breaking API changes and was labeled appropriately

Release note

Changes saved objects management inspect view to a read-only json view of the whole saved object.

…ult space

…ts inspect functional tests

pgayvallet

Overall looking good. A few remarks and question. The most significant one is regarding what we want to do with editUrl.

pgayvallet · 2021-09-15T07:07:23Z

src/plugins/saved_objects_management/public/management_section/mount_section.tsx

+          <Route path={'/:type/:id'} exact={true}>
            <RedirectToHomeIfUnauthorized>
              <Suspense fallback={<EuiLoadingSpinner />}>
                <SavedObjectsEditionPage
                  coreStart={coreStart}


I see serviceRegistry is still passed down to <SavedObjectsTablePage>, to then be propagated to <Flyout>, where it apparently no longer have any usage. Do we want to perform the final SOL cleanup in this PR or in a follow-up?

Um, good point! I'll double check to make sure we're not using the serviceRegistry in some sub-component and can probably remove it in this PR if we want to go that way (or at least remove it from the top most UI layer, meaning the <Flyout> and <SavedObjectsTablePage>).

We have an open issue to handle decoupling the SOM from the SOL, so maybe we should defer the cleanup to a different PR to play it safe?

I've realized small changes in one area have some unexpected downstream consequences (as with most things related to legacy code and saved objects 😆 ).

I've taken a stab at removing the serviceRegistry up to a point in the top-most UI. I'd prefer to delay removing the rest to a follow up PR.

pgayvallet · 2021-09-15T07:19:03Z

...ns/saved_objects_management/public/management_section/object_view/components/header.test.tsx

      ...defaultProps,
      canEdit: false,
    });
-    expect(mounted.find('h1').text()).toMatchInlineSnapshot(`"View search"`);
+    expect(mounted.find('h1').text()).toMatchInlineSnapshot(`"Inspect saved object"`);


canEdit is no longer used in the component, so I think we can remove the duplicate tests that were testing for title depending on it.

pgayvallet · 2021-09-15T07:27:38Z

...plugins/saved_objects_management/public/management_section/object_view/components/header.tsx

+      pageTitle={i18n.translate('savedObjectsManagement.view.inspectTitle', {
+        defaultMessage: 'Inspect saved object',
+      })}


I wonder if we should pass down the object to the <Header> component to display it's name in the title (obj.meta.title)

Do we need the whole object? What about just passing down the title if there is one, as I've done here?

pgayvallet · 2021-09-15T07:43:36Z

...lugins/saved_objects_management/public/management_section/object_view/components/inspect.tsx

+        <CodeEditor
+          languageId={XJsonLang.ID}
+          value={objectAsJsonString}
+          onChange={() => {}}


NIT: is onChange required? The prop seems optional and we're using readOnly:true in the options

...ved_objects_management/public/management_section/object_view/saved_object_view.test.mocks.ts

pgayvallet · 2021-09-15T08:25:38Z

src/plugins/saved_objects_management/public/management_section/saved_objects_table_page.tsx

+          coreStart.application.navigateToUrl(
+            coreStart.http.basePath.prepend(
+              `/app/management/kibana/objects/${savedObject.type}/${savedObject.id}`
+            )
+          );


Are we sure no types were registering custom editUrls (allowing to edit the object via a page specific to the type instead of directing to /app/management/kibana/objects/{...})? We may be breaking things here.

Also, if we do know that all specified editUrl were directing to the SOM edit page, we can now get rid of SavedObjectsTypeManagementDefinition.getEditUrl

Are we sure no types were registering custom editUrls (allowing to edit the object via a page specific to the type instead of directing to /app/management/kibana/objects/{...})? We may be breaking things here.

@pgayvallet You're absolutely right about breaking things here, the functional tests needed to be updated and that should have made me question this! I quick search through the code shows that index-patterns define editUrl: /management/kibana/indexPatterns/patterns/<id>.

I was working towards the PoC, where the change to goInspectObject was proposed.
@timroes can you remember why you proposed the change to the redirect?

The idea behind the change was to make all saved objects "Inspectable", not just ones that had the editUrl defined.

If we need to keep the original implementation but also make other types 'Inspectable', would a combination of the two methods work?, e.g.

goInspectObject={(savedObject) => { const { editUrl } = savedObject.meta; if (editUrl) { return coreStart.application.navigateToUrl( coreStart.http.basePath.prepend(`/app${editUrl}`) ); } else { return coreStart.application.navigateToUrl( coreStart.http.basePath.prepend(`/app/management/kibana/objects/${savedObject.type}/${savedObject.id}`) ); } }}

If not, do you have some other suggestion we could try?

Also, if we do know that all specified editUrl were directing to the SOM edit page, we can now get rid of SavedObjectsTypeManagementDefinition.getEditUrl

Removing SavedObjectsTypeManagementDefinition.getEditUrl was also a remaining task in the PoC and I was planning on getting rid of that in a follow up PR.

If we need to keep the original implementation but also make other types 'Inspectable', would a combination of the two methods work?

After syncing with @lukeelmers we realized we're using the loaders to get the saved object type using the custom editUrl. Removing the deprecated SavedObjectLoader means we'll need to get the actual SO type in some other way on the client side.

Removing the deprecated SavedObjectLoader means we'll need to get the actual SO type in some other way on the client side.

Yeah this is the tricky part, basically there isn't a 1:1 relationship between the type defined in client-side route, and the underlying SO type. (For example dashboard URLs in SOM have savedDashboard/:id in the route). The flow looks something like this:

A SO type has getEditUrl on the server, the returned value of which is included in the injectedMeta that's added to the response from the client's call to bulkGet

The edit URL is pulled from the response rendered in the list view

When navigating to the edit url, we are using the provided service in the route params (which came from the injectedMeta) doing a lookup against the SOM service registry, which essentially provides a mapping between the id (savedDashboards) and the underlying SO type (dashboards)

The underlying SO type is then used to make the request to retrieve the actual object itself

This only works because it is relying on 2 things to be in sync:

The service name that's in the path in the editUrl on the server must match the ID that's in the SOM service registry on the client

The SO type that's in the SOM service registry on the client must match the type that's used to register the SO on the server, which also must match the type included in the SO Loader

Trying to think of a way out of this, I see a couple options:

Maintain a hardcoded list of mappings between the editUrl name & SO type on the client

👎 Implicit dependencies, no clear separation of concerns, not really better than status quo

Expose a registry in SOM for plugins to register this info

Basically the inverse of what we have today: other plugins would need to register with the SOM UI on the client to tell it about their SO types

👍 More explicit dependencies, clearer separation of concerns

👎 Adds a step to the process of adding a custom editUrl, because it wouldn't actually work unless you also registered this info on the client

Find a way to get this info from the server back to the client, perhaps by having some sort of preflight call

For this we'd probably create a route in SOM that returns a list of all available types and returns meta info such as their editUrls

This would need to be called up front whenever SOM is mounted so the mapping could be cached and referenced during routing

👍 No added dependencies or extension points

👎 Additional round trip to the server (but probably just one)

Only use editUrls for navigating outside of SOM (e.g. index patterns)

If no editUrl is provided, we'd fallback to defining this route internally in SOM

This means breaking existing routes so they are forced to do something like app/management/kibana/objects/dashboards/123456

👍 Results in the simplest implementation

👎 Requires breaking change to routes (unless we build in some redirects for affected types: dashboards, vis, saved searches)

Overall I am torn on this. Options 3 and 4 are probably least-bad? WDYT @TinaHeiligers @pgayvallet, any other ideas?

After chatting with @pgayvallet we've decided to go with option 4:

Only use editUrls for navigating outside of SOM (e.g. index patterns)

👍 What this means is that from the saved objects management UI, we'll be able to inspect (view the object) for all so types.

👎 The down side is that to get this to work, we'll need to remove the getEditUrl property of the type registrations that were directing to the SOM edit page:
savedDashboards
savedVisualizations
savedSearches

This is a breaking change to routes but will allow us to decouple the plugin from the loaders.

The next question is: Do we introduce these changes now or wait for 8.0?
@timroes does this seem reasonable to you?

src/plugins/saved_objects_management/public/management_section/saved_objects_edition_page.tsx

test/functional/apps/saved_objects_management/edit_saved_object.ts

x-pack/test/functional/apps/saved_objects_management/spaces_integration.ts

…eateDashboardSavedObjectType and visualizationSavedObjectType. Adds redirect to valid editUrl on Inspect if one is defined

TinaHeiligers · 2021-09-16T23:59:28Z

src/plugins/saved_objects_management/public/management_section/saved_objects_table_page.tsx

-          );
+          const { editUrl } = savedObject.meta;
+          if (editUrl) {
+            coreStart.application.navigateToUrl(coreStart.http.basePath.prepend(`/app${editUrl}`));


Redirect to a custom editUrl for editing in another app if the route is defined.

TinaHeiligers · 2021-09-17T00:00:36Z

src/plugins/saved_objects_management/public/management_section/saved_objects_table_page.tsx

+          } else {
+            coreStart.application.navigateToUrl(
+              coreStart.http.basePath.prepend(
+                `/app/management/kibana/objects/${savedObject.type}/${savedObject.id}`


Allows all saved objects to be viewed as read-only json.

TinaHeiligers · 2021-09-17T00:06:30Z

src/plugins/dashboard/server/saved_objects/dashboard.ts

@@ -27,9 +27,6 @@ export const createDashboardSavedObjectType = ({
    getTitle(obj) {
      return obj.attributes.title;
    },
-    getEditUrl(obj) {


Allows us to decouple the loaders from the saved objects management page and still render the underlying saved object in the SOM Inspect view.
We were using the loaders to map from savedDashboards back to dashboard but we're aiming at removing the dependency on the loaders in the saved objects management plugin.

TinaHeiligers · 2021-09-17T00:06:38Z

src/plugins/discover/server/saved_objects/search.ts

@@ -20,9 +20,6 @@ export const searchSavedObjectType: SavedObjectsType = {
    getTitle(obj) {
      return obj.attributes.title;
    },
-    getEditUrl(obj) {


Allows us to decouple the loaders from the saved objects management page and still render the underlying saved object in the SOM Inspect view.

TinaHeiligers · 2021-09-17T00:08:45Z

src/plugins/visualizations/server/saved_objects/visualization.ts

@@ -20,9 +20,6 @@ export const visualizationSavedObjectType: SavedObjectsType = {
    getTitle(obj) {
      return obj.attributes.title;
    },
-    getEditUrl(obj) {


Allows us to decouple the loaders from the saved objects management page and still render the underlying saved object in the SOM Inspect view.

…ctions as true based on object type and id being present

TinaHeiligers · 2021-09-17T22:41:11Z

...aved_objects_management/public/management_section/objects_table/components/relationships.tsx

@@ -298,7 +298,7 @@ export class Relationships extends Component<RelationshipsProps, RelationshipsSt
            icon: 'inspect',
            'data-test-subj': 'relationshipsTableAction-inspect',
            onClick: (object: SavedObjectWithMetadata) => goInspectObject(object),
-            available: (object: SavedObjectWithMetadata) => !!object.meta.editUrl,
+            available: (object: SavedObjectWithMetadata) => !!(object.type && object.id),


The inspect action is now available for all saved object types (we check that the object provided has a type and id to make sure that routing to the Inspect page will be valid). It used to only be available for saved objects that have an editUrl defined but is not the case anymore.

TinaHeiligers · 2021-09-18T04:41:33Z

@elasticmachine merge upstream

TinaHeiligers · 2021-09-19T23:26:38Z

@elasticmachine merge upstream

ThomThomson

Presentation team changes LGTM! Code only review, and removing the editUrl makes a lot of sense.

andreadelrio

Sass changes LGTM

kibanamachine · 2021-09-21T20:10:50Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`savedObjectsManagement`	79	95	+16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`savedObjectsManagement`	81.5KB	83.7KB	+2.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`core`	292.9KB	293.0KB	+65.0B
`savedObjectsManagement`	18.4KB	18.4KB	+73.0B
total			+138.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`savedObjectsManagement`	29	27	-2

History

💚 Build #154430 succeeded e703655
💚 Build #154375 succeeded 7b748d0
💚 Build #154138 succeeded 2c19acc
💔 Build #154130 failed 121283e
💔 Build #154126 failed dcd44bfc23678179fea86876a4bee0ee786f6862

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-09-21T20:13:55Z

💔 Backport failed

Status	Branch	Result
❌	7.x	Commit could not be cherrypicked due to conflicts

To backport manually run:
node scripts/backport --pr 112034

TinaHeiligers · 2021-09-21T20:58:50Z

@lukeelmers we can't actually backport this to 7.16. It depends on removing support for legacy exports, which we decided not to backport. Did we paint ourselves into a corner here?

lukeelmers · 2021-09-21T21:14:40Z

@TinaHeiligers Ah, shoot. 😞 I think this means our only option is making a second version of this PR targeting 7.x directly, which continues to use the old serviceRegistry and still adds the new Inspect UI. You might be able to cherry pick some specific commits from this PR to make that process easier, but I'm not sure how cleanly they would transfer to 7.x.

In hindsight, what would have saved us from this would be splitting the PR into two phases: the first just updating the UI component to be read-only, and the second updating all of the plumbing to remove serviceRegistry.

Edit: That is, assuming the app team's work that needs to coincide with this still lands in 7.16.

pgayvallet · 2021-09-22T12:26:37Z

I think this means our only option is making a second version of this PR targeting 7.x directly, which continues to use the old serviceRegistry and still adds the new Inspect.

Manual backports with conflicts are always painful, but that seems to be the only option. Note that we only need to preserve the serviceRegistry for the legacy export part, so hopefully most of the modified files can just be picked as-is in the new PR.

FWIW, in that situation I would personally manually pick file by file from this PR's diff instead of trying to cherry pick commits (but that's just how I would be doing it, it's not necessarily the easiest/correct way)

TinaHeiligers · 2021-09-22T17:03:56Z

Note that we only need to preserve the serviceRegistry for the legacy export part, so hopefully most of the modified files can just be picked as-is in the new PR.

I reached out to the app team about their plans for removing the loaders and heard back that they're only targeting 8.0. They assumed that everything would stay as is in 7.16, keeping support for legacy exports and keeping the edit capability using the loaders.

They consider the change from edit -> readonly view a breaking change, hence not implementing in 7.16.

flash1293 · 2021-09-22T17:21:46Z

To add to that - if the core team decides to drop one of these features in 7.16, the vis editors team wouldn’t object; we are fine both ways. It’s just that I’m not seeing a good reason to drop the edit ui in 7.16 vs 8.0 - we need the SO loader anyway for legacy import and it would give the users a bit more time to change their Workflows away from the so edit UI.

Jsut a suggestion, but what about keeping the edit UI in 7.16 with a big warning banner that it will be removed in 8.0?

TinaHeiligers · 2021-09-22T18:00:49Z

Jsut a suggestion, but what about keeping the edit UI in 7.16 with a big warning banner that it will be removed in 8.0

Adding a warning that the edit UI will change in 8.0 seems like a reasonable alternative. We could then also include the link to the saved objects API docs to get folks looking at using those rather than the UI. The API's have validation, something that's been sorely missing in the UI workflow. @elastic/kibana-core do you think we need to warn folks that editing from the UI is being removed in 8.0? It's a UI change and, IIRC, we thought of this as more of a feature than a breaking change.

lukeelmers · 2021-09-22T21:51:01Z

if the core team decides to drop one of these features in 7.16, the vis editors team wouldn’t object; we are fine both ways.

If the app team doesn't need this in 7.16, I see no reason why we should invest the time on manually backporting

do you think we need to warn folks that editing from the UI is being removed in 8.0? It's a UI change and, IIRC, we thought of this as more of a feature than a breaking change

TBH I am not sure if it's worth adding a warning. We agreed in the original issue #59588 (comment) that we didn't want to go out of our way to show users workarounds for manually changing their SOs due to the consequences of messing this up. We could add a general "this is going away" warning, but it probably would just annoy people if we aren't giving them a workaround.

Just my two cents though, I don't have particularly strong feelings on this & would support adding a warning if others felt it was important (we'd just need to wordsmith it carefully)

Edit: just found #112864, will move my comments there

everythings-gonna-be-alright · 2022-11-27T01:38:26Z

Actually it uncomfortable, because sometimes it was useful, to change some pieces of object directly in kibana editor.

TinaHeiligers added 4 commits September 13, 2021 15:40

Changes edit view to json read-only view

74e910a

Adds copy to clipboard functionality

0b25760

Adds link to saved objects api for not found error message

238f6da

Update i18n

9dfde70

TinaHeiligers added release_note:feature Makes this part of the condensed release notes v7.16.0 v8.0.0 labels Sep 13, 2021

TinaHeiligers added 4 commits September 13, 2021 17:00

Cleans up todo comments

8e31205

Merge branch 'master' into so-management/read-only-inspect-view

148a2b9

Updates test for ensuring we can inspect a saved object in a non-defa…

1110ff3

…ult space

Updates unit test snapshot and refactors security-related saved objec…

8c92317

…ts inspect functional tests

pgayvallet reviewed Sep 15, 2021

View reviewed changes

TinaHeiligers added 5 commits September 15, 2021 08:58

Merge branch 'master' into so-management/read-only-inspect-view

e2c7143

Merge branch 'master' into so-management/read-only-inspect-view

e091640

removes getEditUrl from saved object loader searchSavedObjectType, cr…

b31a0a8

…eateDashboardSavedObjectType and visualizationSavedObjectType. Adds redirect to valid editUrl on Inspect if one is defined

Addresses draft comments

3c89d0b

improves functional tests

3f2b30d

TinaHeiligers commented Sep 16, 2021

View reviewed changes

TinaHeiligers commented Sep 17, 2021

View reviewed changes

TinaHeiligers added 2 commits September 16, 2021 17:14

Fixes som api_integration test

dac2f76

Updates unit test snapshots, sets available in relationships flyout a…

8df5007

…ctions as true based on object type and id being present

TinaHeiligers commented Sep 17, 2021

View reviewed changes

Updates api_integration test making editUrl optional in the schema

9de3eb1

Merge branch 'master' into so-management/read-only-inspect-view

121283e

TinaHeiligers force-pushed the so-management/read-only-inspect-view branch from dcd44bf to 121283e Compare September 19, 2021 21:18

ThomThomson approved these changes Sep 21, 2021

View reviewed changes

TinaHeiligers added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 21, 2021

Addresses nits

8c75ad8

andreadelrio approved these changes Sep 21, 2021

View reviewed changes

TinaHeiligers removed the request for review from a team September 21, 2021 20:06

TinaHeiligers enabled auto-merge (squash) September 21, 2021 20:09

TinaHeiligers merged commit 8cf0efe into elastic:master Sep 21, 2021

TinaHeiligers added backport:skip This commit does not require backporting and removed auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 labels Sep 21, 2021

TinaHeiligers added Feature:Saved Objects Management and removed Feature:Embedding Embedding content via iFrame labels Sep 22, 2021

TinaHeiligers mentioned this pull request Sep 22, 2021

Saved objects management: Add warning for UI edit -> read-only UI change #112864

Closed

TinaHeiligers mentioned this pull request Sep 23, 2021

Decouples saved objects management from legacy saved objects loaders #113031

Merged

2 tasks

TinaHeiligers deleted the so-management/read-only-inspect-view branch October 14, 2021 22:27

KOTungseth added the Feature:Saved Objects label Oct 27, 2021

This was referenced Apr 1, 2022

[Docs] fix docs on editing saved objects (you can't any longer) #129252

Closed

Saved Object editor doesn't allow for edits #129096

Closed

TinaHeiligers mentioned this pull request Apr 15, 2022

Deletes section on editing saved objects from the UI #130408

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes edit view to json read-only view #112034

Changes edit view to json read-only view #112034

TinaHeiligers commented Sep 13, 2021 •

edited

Loading

pgayvallet left a comment

pgayvallet Sep 15, 2021

TinaHeiligers Sep 20, 2021 •

edited

Loading

TinaHeiligers Sep 20, 2021

pgayvallet Sep 15, 2021

pgayvallet Sep 15, 2021

TinaHeiligers Sep 16, 2021 •

edited

Loading

pgayvallet Sep 15, 2021

pgayvallet Sep 15, 2021

TinaHeiligers Sep 15, 2021 •

edited

Loading

TinaHeiligers Sep 15, 2021

lukeelmers Sep 15, 2021

TinaHeiligers Sep 16, 2021 •

edited

Loading

TinaHeiligers Sep 16, 2021 •

edited

Loading

TinaHeiligers Sep 17, 2021

TinaHeiligers Sep 17, 2021 •

edited

Loading

TinaHeiligers Sep 17, 2021 •

edited

Loading

TinaHeiligers Sep 17, 2021

TinaHeiligers Sep 17, 2021

TinaHeiligers commented Sep 18, 2021

TinaHeiligers commented Sep 19, 2021

ThomThomson left a comment

andreadelrio left a comment

kibanamachine commented Sep 21, 2021

References to deprecated APIs

kibanamachine commented Sep 21, 2021

TinaHeiligers commented Sep 21, 2021

lukeelmers commented Sep 21, 2021 •

edited

Loading

pgayvallet commented Sep 22, 2021

TinaHeiligers commented Sep 22, 2021 •

edited

Loading

flash1293 commented Sep 22, 2021

TinaHeiligers commented Sep 22, 2021 •

edited

Loading

lukeelmers commented Sep 22, 2021 •

edited

Loading

everythings-gonna-be-alright commented Nov 27, 2022 •

edited

Loading

Changes edit view to json read-only view #112034

Changes edit view to json read-only view #112034

Conversation

TinaHeiligers commented Sep 13, 2021 • edited Loading

Checklist

Risk Matrix

For maintainers

Release note

pgayvallet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers Sep 20, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers Sep 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers Sep 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers Sep 16, 2021 • edited Loading

Choose a reason for hiding this comment

TinaHeiligers Sep 16, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers Sep 17, 2021 • edited Loading

Choose a reason for hiding this comment

TinaHeiligers Sep 17, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TinaHeiligers commented Sep 18, 2021

TinaHeiligers commented Sep 19, 2021

ThomThomson left a comment

Choose a reason for hiding this comment

andreadelrio left a comment

Choose a reason for hiding this comment

kibanamachine commented Sep 21, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

References to deprecated APIs

History

kibanamachine commented Sep 21, 2021

💔 Backport failed

TinaHeiligers commented Sep 21, 2021

lukeelmers commented Sep 21, 2021 • edited Loading

pgayvallet commented Sep 22, 2021

TinaHeiligers commented Sep 22, 2021 • edited Loading

flash1293 commented Sep 22, 2021

TinaHeiligers commented Sep 22, 2021 • edited Loading

lukeelmers commented Sep 22, 2021 • edited Loading

everythings-gonna-be-alright commented Nov 27, 2022 • edited Loading

TinaHeiligers commented Sep 13, 2021 •

edited

Loading

TinaHeiligers Sep 20, 2021 •

edited

Loading

TinaHeiligers Sep 16, 2021 •

edited

Loading

TinaHeiligers Sep 15, 2021 •

edited

Loading

TinaHeiligers Sep 16, 2021 •

edited

Loading

TinaHeiligers Sep 16, 2021 •

edited

Loading

TinaHeiligers Sep 17, 2021 •

edited

Loading

TinaHeiligers Sep 17, 2021 •

edited

Loading

lukeelmers commented Sep 21, 2021 •

edited

Loading

TinaHeiligers commented Sep 22, 2021 •

edited

Loading

TinaHeiligers commented Sep 22, 2021 •

edited

Loading

lukeelmers commented Sep 22, 2021 •

edited

Loading

everythings-gonna-be-alright commented Nov 27, 2022 •

edited

Loading