Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Add KQL filter bar to alerts #111663

Merged

Conversation

simianhacker
Copy link
Member

@simianhacker simianhacker commented Sep 8, 2021

Summary

This PR closes #96800 by adding a KQL filter section to each of the Stack Monitoring rule types.

Example Screenshots

image

image

Checklist

Delete any items that are not applicable to this PR.

@simianhacker simianhacker added Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0 release_note:enhancement labels Sep 8, 2021
@simianhacker simianhacker force-pushed the issue-96800-add-filter-to-sm-alerts branch from 2b0a40b to a7a566f Compare September 14, 2021 20:27
@simianhacker simianhacker marked this pull request as ready for review September 16, 2021 16:41
@simianhacker simianhacker requested a review from a team as a code owner September 16, 2021 16:41
@simianhacker simianhacker requested review from a team September 16, 2021 16:41
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

Copy link
Contributor

@Zacqary Zacqary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@simianhacker
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
monitoring 582 601 +19

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 788.4KB 937.7KB +149.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
monitoring 48.4KB 36.2KB -12.2KB
Unknown metric groups

async chunk count

id before after diff
monitoring 3 12 +9

References to deprecated APIs

id before after diff
monitoring 2 39 +37

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@simianhacker simianhacker added the auto-backport Deprecated - use backport:version if exact versions are needed label Sep 22, 2021
@simianhacker simianhacker merged commit 1b93b00 into elastic:master Sep 22, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Sep 22, 2021
* [Monitoring] Add KQL filter bar to alerts

* Finish adding filters to UI

* Adding filterQuery to all the backend alert functions

* removing unused translations

* fixing types

* Moving alerting code to async imports

Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 23, 2021
…-migrate-away-from-injected-css-js

* 'master' of github.com:elastic/kibana: (189 commits)
  fix permissions for cloud test (elastic#112568)
  Updates the VEGA docs for v8.0 (elastic#112781)
  Updates the TSVB docs for v8 (elastic#112778)
  [Expressions] Fix setup and start contracts (elastic#110841)
  [DOCS] Update remote cluster and security links (elastic#112874)
  test/functional/apps/management/_test_huge_fields.js (elastic#112878)
  Fix the other one... (elastic#112873)
  [data.search.aggs] Use fields instead of _source in top_hits agg (elastic#109531)
  [Search sessions] Don't show incomplete warning if search requests aren't in session (elastic#112364)
  [data.search] Do not send ignore_throttled when search:includeFrozen is disabled (elastic#112755)
  [Monitoring] Add KQL filter bar to alerts (elastic#111663)
  Log deprecation warnings for plugins which won't be disable-able in 8.0 (elastic#112602)
  [CI] Balance CI Groups (elastic#112836)
  Add ILM URLs to documentation link service (elastic#112748)
  Bump chromedriver to 93 (elastic#112847)
  [Maps] move joins from LayerDescriptor to VectorLayerDescriptor (elastic#112427)
  Add a handler for a possible promise rejection (elastic#112840)
  Removes space, fix build (elastic#112856)
  [Maps] fix unhandled promise rejections in jest tests (elastic#112712)
  Copy pass 3 (elastic#112815)
  ...

# Conflicts:
#	src/plugins/dashboard/public/application/dashboard_app.tsx
#	src/plugins/dashboard/public/application/embeddable/viewport/dashboard_viewport.tsx
kibanamachine added a commit that referenced this pull request Sep 23, 2021
* [Monitoring] Add KQL filter bar to alerts

* Finish adding filters to UI

* Adding filterQuery to all the backend alert functions

* removing unused translations

* fixing types

* Moving alerting code to async imports

Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Chris Cowan <[email protected]>
@simianhacker simianhacker deleted the issue-96800-add-filter-to-sm-alerts branch April 17, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Metrics UI Metrics UI feature release_note:enhancement Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Monitoring]Add Filter in stack monitoring rules
4 participants