Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Add KQL validation to Stack Monitoring alerts #119863

Open
simianhacker opened this issue Nov 29, 2021 · 1 comment
Open

[Stack Monitoring] Add KQL validation to Stack Monitoring alerts #119863

simianhacker opened this issue Nov 29, 2021 · 1 comment
Labels
Feature:Stack Monitoring Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:Monitoring Stack Monitoring team

Comments

@simianhacker
Copy link
Member

In #111663 we added KQL filters to the stack monitoring alerts. We need to add a condition that will prevent the user from saving any alerts with invalid KQL filters. We also suppressed the JSON parsing of the filterQuery in the rules like:

try {
if (filterQuery) {
const filterQueryObject = JSON.parse(filterQuery);
params.body.query.bool.filter.push(filterQueryObject);
}
} catch (e) {
// meh
}

After giving it some thought we should just let those errors bubble up.

Related issues and PRs:

@simianhacker simianhacker added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Nov 29, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@smith smith added Team:Monitoring Stack Monitoring team and removed Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Stack Monitoring Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Team:Monitoring Stack Monitoring team
Projects
None yet
Development

No branches or pull requests

3 participants