Add correct roles to test user for functional tests in dashboard #110880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poffdeluxe
added
loe:small
poffdeluxe
force-pushed
the
test/presentation-functional-cloud-fix
branch
from
927a730 to
13d28c2
Compare
poffdeluxe
changed the title
ThomThomson
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
Code review only, but functional test changes LGTM! I'm so excited that such a simple change can solve so many cloud failed tests. Thanks for figuring this out!
I'd be curious to know why these pass in the regular CI runs, so hopefully something turns up in your research in that area!
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
poffdeluxe
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 2, 2021
…stic#110880) * Add animals role to test user for functional tests in dashboard * Fix two more dashboard tests by applying proper roles * Restore test user defaults * Fix one last dashboard test * forgot security service * Cleanup
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 2, 2021
…stic#110880) * Add animals role to test user for functional tests in dashboard * Fix two more dashboard tests by applying proper roles * Restore test user defaults * Fix one last dashboard test * forgot security service * Cleanup
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 2, 2021
…stic#110880) * Add animals role to test user for functional tests in dashboard * Fix two more dashboard tests by applying proper roles * Restore test user defaults * Fix one last dashboard test * forgot security service * Cleanup
kibanamachine
added a commit
that referenced
this pull request
Sep 2, 2021
…0880) (#111049) * Add animals role to test user for functional tests in dashboard * Fix two more dashboard tests by applying proper roles * Restore test user defaults * Fix one last dashboard test * forgot security service * Cleanup Co-authored-by: Poff Poffenberger <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 2, 2021
…0880) (#111047) * Add animals role to test user for functional tests in dashboard * Fix two more dashboard tests by applying proper roles * Restore test user defaults * Fix one last dashboard test * forgot security service * Cleanup Co-authored-by: Poff Poffenberger <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Sep 2, 2021
…0880) (#111048) * Add animals role to test user for functional tests in dashboard * Fix two more dashboard tests by applying proper roles * Restore test user defaults * Fix one last dashboard test * forgot security service * Cleanup Co-authored-by: Poff Poffenberger <[email protected]>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 3, 2021
…eporting-to-v2 * 'master' of github.com:elastic/kibana: (65 commits) Move to vis_types folder part 2 (elastic#110574) [SOR] use initialNamespaces when checking for conflict for `create` and `bulkCreate` (elastic#111023) [Discover] Remove export* syntax (elastic#110934) [Event log][7.x] Updated event log client to search across legacy IDs (elastic#109365) [Security Solution][Detection Rules] Changes 'activated' text on rule details page (elastic#111044) [Metrics UI] Filter out APM nodes from the inventory view (elastic#110300) [package testing] Update logging and pid configuration (elastic#111059) [Dashboard] Read App State from URL on Soft Refresh (elastic#109354) Add correct roles to test user for functional tests in dashboard (elastic#110880) [DOCS] Adds Lens Inspector and minor edits (elastic#109736) [DOCS] Updates Spaces page (elastic#111005) normalize initialNamespaces (elastic#110936) [Reporting] Clean up `any` usage, reorganize server route files (elastic#110740) [Security Solution] [CTI] Fixes bug that caused Threshold and Indicator Match rules to ignore custom rule filters if a saved query was used in the rule definition. (elastic#109253) skip flaky suites: elastic#111001, elastic#111022 [Security Solution][RAC] - Update reason field text (elastic#110308) [RAC][Security Solution] Make analyzer work with EuiDataGrid full screen (elastic#110913) [Metrics UI] Add integration tests for Metric Threshold Rule and refactor to fire correctly (elastic#109971) [DOCS] Updates Discover docs (elastic#110346) [RAC] Persistent timeline fields fix (elastic#110685) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds animals/logstash role that was required for the test user to view a few indices and visualizations
Fixes #92307
Fixes #97540
Fixes #92303
Fixes #86524
Fixes #76181