[Metrics UI] Filter out APM nodes from the inventory view #110300
Conversation
Zacqary
added
release_note:fix
Feature:Metrics UI
| return { ...node, path, name }; | ||
| }); | ||
| const isNoData = node.metrics.every((m) => m.value === null); | ||
| const isAPMNode = series.metricsets?.includes('app'); |
There was a problem hiding this comment.
APM produces other metric sets than app so I'm not sure this check will filter all APM nodes out.
Perhaps it would be better to check for the existence of one or more required fields, eg the cpu value.
There was a problem hiding this comment.
Are there any APM nodes that don't produce app? series.metricsets includes every metric set attached to the node in question, so as long as app is present then the existence of other sets don't matter.
I'm not sure how else to differentiate between a missing CPU value because of a No Data situation, and a missing CPU value because the node is from APM.
x-pack/plugins/infra/server/routes/snapshot/lib/trasform_metrics_ui_response.ts
Outdated
Show resolved
Hide resolved
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Zacqary
added
the
auto-backport
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
@Zacqary Any chance this can make it to 7.15? |
There was a problem hiding this comment.
LGTM
I wonder if we might have some more work to do to avoid displaying duplicates if the data gets collected by both apm & metricbeat, as @alex-fedotyev mentioned here.
Not sure if the code accounts for it, but I don't see a test for it so I'm guessing not.
Either way I think we can worry about that once APM is able to send the expected data.
…0300) * [Metrics UI] Filter out APM nodes from the inventory view * Update jest snapshots * Add tests for fs for filtering out APM nodes
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…111074) * [Metrics UI] Filter out APM nodes from the inventory view * Update jest snapshots * Add tests for fs for filtering out APM nodes Co-authored-by: Zacqary Adam Xeper <[email protected]>
…eporting-to-v2 * 'master' of github.com:elastic/kibana: (65 commits) Move to vis_types folder part 2 (elastic#110574) [SOR] use initialNamespaces when checking for conflict for `create` and `bulkCreate` (elastic#111023) [Discover] Remove export* syntax (elastic#110934) [Event log][7.x] Updated event log client to search across legacy IDs (elastic#109365) [Security Solution][Detection Rules] Changes 'activated' text on rule details page (elastic#111044) [Metrics UI] Filter out APM nodes from the inventory view (elastic#110300) [package testing] Update logging and pid configuration (elastic#111059) [Dashboard] Read App State from URL on Soft Refresh (elastic#109354) Add correct roles to test user for functional tests in dashboard (elastic#110880) [DOCS] Adds Lens Inspector and minor edits (elastic#109736) [DOCS] Updates Spaces page (elastic#111005) normalize initialNamespaces (elastic#110936) [Reporting] Clean up `any` usage, reorganize server route files (elastic#110740) [Security Solution] [CTI] Fixes bug that caused Threshold and Indicator Match rules to ignore custom rule filters if a saved query was used in the rule definition. (elastic#109253) skip flaky suites: elastic#111001, elastic#111022 [Security Solution][RAC] - Update reason field text (elastic#110308) [RAC][Security Solution] Make analyzer work with EuiDataGrid full screen (elastic#110913) [Metrics UI] Add integration tests for Metric Threshold Rule and refactor to fire correctly (elastic#109971) [DOCS] Updates Discover docs (elastic#110346) [RAC] Persistent timeline fields fix (elastic#110685) ...
…0300) * [Metrics UI] Filter out APM nodes from the inventory view * Update jest snapshots * Add tests for fs for filtering out APM nodes
Summary
Closes #107565
Filters out APM nodes from the Inventory view, as they don't report the correct set of metrics to be useful.
The Snapshot API will filter out any nodes that:
nullapp, which indicates that this is data from APM and not MetricbeatNote that this PR will NOT filter out any APM nodes that do successfully report data. When APM is updated to report data compatible with the Inventory view, we won't need to make any changes to the Metrics app for it to work.
Checklist