[Security Solutions][Detection Engine] Changes the loading of indexes in tests from beforeEach() to before() #110340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankHassanabad
added
v8.0.0
v7.16.0
auto-backport
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
FrankHassanabad
added
the
release_note:skip
FrankHassanabad
commented
Aug 26, 2021
| }); | ||
|
|
||
| afterEach(async () => { | ||
| await deleteSignalsIndex(supertest); | ||
| await deleteAllAlerts(supertest); | ||
| await esArchiver.load('x-pack/test/functional/es_archives/auditbeat/hosts'); |
There was a problem hiding this comment.
NOTE: This one was a load instead of unload and did not technically ever unload the hosts, so I fixed it here.
spong
approved these changes
Aug 26, 2021
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 26, 2021
…elastic#110340) ## Summary Changes the loading of indexes in tests from beforeEach() to before() Hoping this fixes some flake we have seen recently. If it doesn't, at least tests should run faster and be less flake overall. If these two below do begin acting up again I will then probably resort to wrapping the individual tests around retry blocks or removing the tests. Also found one area within `x-pack/test/detection_engine_api_integration/security_and_spaces/tests/generating_signals.ts` where we do a `load` twice but I fixed it to the `load`/`unload` pattern. Issues this should fix: * elastic#107911 * elastic#107856 ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 30, 2021
…#110340) (#110368) ## Summary Changes the loading of indexes in tests from beforeEach() to before() Hoping this fixes some flake we have seen recently. If it doesn't, at least tests should run faster and be less flake overall. If these two below do begin acting up again I will then probably resort to wrapping the individual tests around retry blocks or removing the tests. Also found one area within `x-pack/test/detection_engine_api_integration/security_and_spaces/tests/generating_signals.ts` where we do a `load` twice but I fixed it to the `load`/`unload` pattern. Issues this should fix: * #107911 * #107856 ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Frank Hassanabad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes the loading of indexes in tests from beforeEach() to before()
Hoping this fixes some flake we have seen recently. If it doesn't, at least tests should run faster and be less flake overall. If these two below do begin acting up again I will then probably resort to wrapping the individual tests around retry blocks or removing the tests.
Also found one area within
x-pack/test/detection_engine_api_integration/security_and_spaces/tests/generating_signals.tswhere we do aloadtwice but I fixed it to theload/unloadpattern.Issues this should fix:
Checklist