Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/text·ts - detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type text "is not" operator will return 0 results if it cannot find what it is excluding #107911

Closed
Tracked by #161531
kibanamachine opened this issue Aug 9, 2021 · 6 comments
Closed
Tracked by #161531

Failing test: X-Pack Detection Engine API Integration Tests.x-pack/test/detection_engine_api_integration/security_and_spaces/tests/exception_operators_data_types/text·ts - detection engine api security and spaces enabled Detection exceptions data types and operators Rule exception operators for data type text "is not" operator will return 0 results if it cannot find what it is excluding #107911

kibanamachine opened this issue Aug 9, 2021 · 6 comments
Assignees
@e40pud
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Detections and Resp Security Detection Response Team

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Aug 9, 2021 •
edited
Loading

A test failed on a tracked branch

Error: timed out waiting for function condition to be true within waitForRuleSuccessOrStatus
    at /dev/shm/workspace/parallel/10/kibana/x-pack/test/detection_engine_api_integration/utils.ts:785:9

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Aug 9, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 9, 2021
@mistic mistic added the Team:Detections and Resp Security Detection Response Team label Aug 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Aug 9, 2021
@spong spong mentioned this issue Aug 9, 2021
Merged
1 task
@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

@kibanamachine
Copy link
Contributor Author

New failure: Jenkins Build

spalger added a commit that referenced this issue Aug 12, 2021
@spalger
skip flaky suite (#107911)
31b8a82
spalger added a commit that referenced this issue Aug 12, 2021
@spalger
skip flaky suite (#107911)
617775d 
(cherry picked from commit 31b8a82)
@spalger
Copy link
Contributor

spalger commented Aug 12, 2021

56 failures across PRs and master, skipping

image

8.0/master: 31b8a82
7.x/7.15: 617775d

@FrankHassanabad FrankHassanabad self-assigned this Aug 26, 2021
@FrankHassanabad FrankHassanabad mentioned this issue Aug 26, 2021
Merged
1 task
FrankHassanabad added a commit that referenced this issue Aug 26, 2021
@FrankHassanabad
Changes the loading of indexes in tests from beforeEach() to before() (…
35b59cd 
…#110340)

## Summary

Changes the loading of indexes in tests from beforeEach() to before()

Hoping this fixes some flake we have seen recently. If it doesn't, at least tests should run faster and be less flake overall. If these two below do begin acting up again I will then probably resort to wrapping the individual tests around retry blocks or removing the tests.

Also found one area within `x-pack/test/detection_engine_api_integration/security_and_spaces/tests/generating_signals.ts` where we do a `load` twice but I fixed it to the `load`/`unload` pattern.

Issues this should fix:
* #107911
* #107856

### Checklist

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 26, 2021
@FrankHassanabad @kibanamachine
Changes the loading of indexes in tests from beforeEach() to before() (…
3979592 
…elastic#110340)

## Summary

Changes the loading of indexes in tests from beforeEach() to before()

Hoping this fixes some flake we have seen recently. If it doesn't, at least tests should run faster and be less flake overall. If these two below do begin acting up again I will then probably resort to wrapping the individual tests around retry blocks or removing the tests.

Also found one area within `x-pack/test/detection_engine_api_integration/security_and_spaces/tests/generating_signals.ts` where we do a `load` twice but I fixed it to the `load`/`unload` pattern.

Issues this should fix:
* elastic#107911
* elastic#107856

### Checklist

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine added a commit that referenced this issue Aug 30, 2021
@kibanamachine @FrankHassanabad
Changes the loading of indexes in tests from beforeEach() to before() (…
525f63c 
…#110340) (#110368)

## Summary

Changes the loading of indexes in tests from beforeEach() to before()

Hoping this fixes some flake we have seen recently. If it doesn't, at least tests should run faster and be less flake overall. If these two below do begin acting up again I will then probably resort to wrapping the individual tests around retry blocks or removing the tests.

Also found one area within `x-pack/test/detection_engine_api_integration/security_and_spaces/tests/generating_signals.ts` where we do a `load` twice but I fixed it to the `load`/`unload` pattern.

Issues this should fix:
* #107911
* #107856

### Checklist

- [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <[email protected]>
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@kibanamachine kibanamachine reopened this Nov 1, 2021
@FrankHassanabad FrankHassanabad removed their assignment Feb 8, 2023
@e40pud e40pud self-assigned this Jul 13, 2023
@e40pud
Copy link
Contributor

e40pud commented Jul 13, 2023 •
edited
Loading

I see that these tests were un-skipped more than two years ago in this commit https://github.com/elastic/kibana/pull/110340/files#diff-93bf7da752c2d5dce1dde1c8d9f2868b91d6c9afda005284f1d0a6a641a6f3bb

Here is the location of the test in the current version of the code https://github.com/elastic/kibana/blob/main/x-pack/test/detection_engine_api_integration/security_and_spaces/group8/exception_operators_data_types/text.ts#L251

Closing since test is not skipped and works in main.

cc @MadameSheema @yctercero

@e40pud e40pud closed this as completed Jul 13, 2023
@e40pud e40pud mentioned this issue Jul 13, 2023
Closed
@e40pud e40pud mentioned this issue Jul 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@e40pud e40pud

Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Detections and Resp Security Detection Response Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@FrankHassanabad @spalger @e40pud @mistic @elasticmachine @kibanamachine