[Stack monitoring] Add global state context and routeInit component #109790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estermv
added
v8.0.0
Team:Infra Monitoring UI - DEPRECATED
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
estermv
commented
Aug 24, 2021
Comment on lines
+64
to
+71
| const isExpired = (license: any): boolean => { | ||
| const { expiry_date_in_millis: expiryDateInMillis } = license; | ||
|
|
||
| if (expiryDateInMillis !== undefined) { | ||
| return new Date().getTime() >= expiryDateInMillis; | ||
| } | ||
| return false; | ||
| }; |
There was a problem hiding this comment.
This comes from the license service in Angular. It stores the license of the cluster viewed.
This service seems to be used in a couple of places, so I don't think is worth it to keep it as part of the state. We can extract this code to a separate file later if it's used in more places
estermv
changed the title
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
|
|
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 26, 2021
…lastic#109790) * Add global state to stack monitoring react app * Add type for state * Add some todos * Add route_init migration Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 26, 2021
…109790) (#110181) * Add global state to stack monitoring react app * Add type for state * Add some todos * Add route_init migration Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Ester Martí Vilaseca <[email protected]>
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is part of the Angular migration:
GlobalStatecontext. It makes use of the existingGlobalState, which is responsible for storing the global state and keep it in sync with the URL query params.RouteInitcomponent that requests the clusters and does some redirects based on the response. This replaces the routeInit provider from Angular, used in almost all the routes definitions on the resolve property.