Add some todos

elastic · Aug 24, 2021 · b9f12f7 · b9f12f7
1 parent 91cbaed
commit b9f12f7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/x-pack/plugins/monitoring/public/application/global_state_context.tsx b/x-pack/plugins/monitoring/public/application/global_state_context.tsx
@@ -21,7 +21,8 @@ interface State {
 export const GlobalStateContext = createContext({} as State);
 
 export const GlobalStateProvider = ({ query, toasts, children }: GlobalStateProviderProps) => {
-  const fakeRootScope: Partial<ng.IRootScopeService> = {
+  // TODO: remove fakeAngularRootScope and fakeAngularLocation when angular is removed
+  const fakeAngularRootScope: Partial<ng.IRootScopeService> = {
     $on: (
       name: string,
       listener: (event: ng.IAngularEvent, ...args: any[]) => any
@@ -39,7 +40,13 @@ export const GlobalStateProvider = ({ query, toasts, children }: GlobalStateProv
   };
 
   const localState: { [key: string]: unknown } = {};
-  const state = new GlobalState(query, toasts, fakeRootScope, fakeAngularLocation, localState);
+  const state = new GlobalState(
+    query,
+    toasts,
+    fakeAngularRootScope,
+    fakeAngularLocation,
+    localState
+  );
 
   const initialState: any = state.getState();
   for (const key in initialState) {

diff --git a/x-pack/plugins/monitoring/public/url_state.ts b/x-pack/plugins/monitoring/public/url_state.ts
@@ -57,6 +57,7 @@ export interface MonitoringAppStateTransitions {
 const GLOBAL_STATE_KEY = '_g';
 const objectEquals = (objA: any, objB: any) => JSON.stringify(objA) === JSON.stringify(objB);
 
+// TODO: clean all angular references after angular is removed
 export class GlobalState {
   private readonly stateSyncRef: ISyncStateRef;
   private readonly stateContainer: StateContainer<