[eslint] add rule to prevent export* in plugin index files #109357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏 👏 👏 👏 👏 👏 👏 👏 - nicely done |
spalger
force-pushed
the
implement/eslint-rule-no-export-all
branch
4 times, most recently
from
0b3e6f6 to
d796ec2
Compare
spalger
force-pushed
the
implement/eslint-rule-no-export-all
branch
from
175bbf2 to
1d6958e
Compare
…int-rule-no-export-all
This was referenced Aug 24, 2021
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
cjcenizal
approved these changes
Sep 1, 2021
botelastic
bot
added
Feature:Embedding
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
spalger
added
the
auto-backport
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 2, 2021
…09357) * [eslint] add rule to prevent export* in plugin index files * deduplicate export names for types/instances with the same name * attempt to auto-fix duplicate exports too * capture exported enums too * enforce no_export_all for core too * disable rule by default, allow opting-in for help fixing * update tests * reduce yarn.lock duplication * add rule but no fixes * disable all existing violations * update api docs with new line numbers * revert unnecessary changes to yarn.lock which only had drawbacks * remove unnecessary eslint-disable * rework codegen to split type exports and use babel to generate valid code * check for "export types" deeply * improve test by using fixtures * add comments to some helper functions * disable fix for namespace exports including types * label all eslint-disable comments with related team-specific issue * ensure that child exports of `export type` are always tracked as types Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Sep 2, 2021
…110928) * [eslint] add rule to prevent export* in plugin index files * deduplicate export names for types/instances with the same name * attempt to auto-fix duplicate exports too * capture exported enums too * enforce no_export_all for core too * disable rule by default, allow opting-in for help fixing * update tests * reduce yarn.lock duplication * add rule but no fixes * disable all existing violations * update api docs with new line numbers * revert unnecessary changes to yarn.lock which only had drawbacks * remove unnecessary eslint-disable * rework codegen to split type exports and use babel to generate valid code * check for "export types" deeply * improve test by using fixtures * add comments to some helper functions * disable fix for namespace exports including types * label all eslint-disable comments with related team-specific issue * ensure that child exports of `export type` are always tracked as types Co-authored-by: spalger <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Spencer <[email protected]> Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers!
These changes are just adding
/* eslint-disable */comments to tons of plugins so don't worry about reviewing. I'll be merging without reviews. Just please check the issues created for your team and in: https://github.com/elastic/kibana/projects/76Implements the ESLint rule requested by #57370
Unfortunately, auto-fixing these violations perfectly isn't easy (we tried, but it created a number of problems) so rather than spend a ton of time trying to get the auto-fix perfect I suggest that we disable all the current violations and create issues for each team to remove the
eslint-disablecomments. Removing the comment will auto-fix, but since it's imperfect folks will need to review the changes.The list of plugins with violations by team:
kibana-app-services: (10) bfetch, data, embeddable, expressions, fieldFormats, inspector, kibanaReact, kibanaUtils, uiActions, uiActionsEnhancedkibana-app: (10) charts, kibanaLegacy, urlForwarding, visDefaultEditor, visTypeTable, visTypeVislib, visTypeXy, visualizations, discoverEnhanced, lenskibana-presentation: (8) expressionError, expressionImage, expressionMetric, expressionRepeatImage, expressionRevealImage, expressionShape, presentationUtil, dashboardEnhancedkibana-alerting-services: alerting, ruleRegistry, stackAlerts, triggersActionsUikibana-stack-management: devTools, indexManagement, snapshotRestoreml-ui: dataVisualizer, fileUpload, mlsecurity-solution: metricsEntities, securitySolution, timelineskibana-gis: mapsEms, mapssecurity-threat-hunting: casesfleet: fleetkibana-core: licensingsecurity-detections-response: listsobservability-ui: observabilitysecurity-asset-management: osquerykibana-reporting-services: reporting