Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Remove * exports #109853

Closed
thomasneirynck opened this issue Aug 24, 2021 · 2 comments · Fixed by #111003
Closed

[Maps] Remove * exports #109853

thomasneirynck opened this issue Aug 24, 2021 · 2 comments · Fixed by #111003
Assignees
@nreese
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0

Comments

@thomasneirynck
Copy link
Contributor

Some maps plugins are exporting public api with export *. This is no longer allowed.

See #109357
@thomasneirynck thomasneirynck added chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 labels Aug 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@spalger
Copy link
Contributor

spalger commented Sep 1, 2021

Search for // TODO: https://github.com/elastic/kibana/issues/109853 to find instances which need fixing after #109357 is merged.

@nreese nreese mentioned this issue Sep 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Maps] Remove * exports nreese/kibana
4 participants
@nreese @spalger @thomasneirynck @elasticmachine