-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution] Move Endpoint details flyout and related middleware to their own functions #108330
[Security Solution] Move Endpoint details flyout and related middleware to their own functions #108330
Conversation
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/middleware.ts
Outdated
Show resolved
Hide resolved
...s/security_solution/public/management/pages/endpoint_hosts/view/details/endpoint_details.tsx
Show resolved
Hide resolved
@@ -4,122 +4,23 @@ | |||
* 2.0; you may not use this file except in compliance with the Elastic License | |||
* 2.0. | |||
*/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all the code that you see had been removed here (A)
@@ -0,0 +1,210 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was moved into this file (A)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. 🚀 Nice to have large files refactored. 👏
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/store/action.ts
Show resolved
Hide resolved
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
…re to their own functions (elastic#108330) * Split function to load endpoint details using parameters * Add action to load endpoint details * Moving all the endpoint details content to a separate component * Rename endpoint details to endpoint details content * Rename temporal file into EndpointDetails * Remove unused dispatch * Refactor ingestPolicies dispatching in the middleware
💔 Backport failed
Successful backport PRs will be merged automatically after passing CI. To backport manually run: |
…re to their own functions (#108330) (#108491) * Split function to load endpoint details using parameters * Add action to load endpoint details * Moving all the endpoint details content to a separate component * Rename endpoint details to endpoint details content * Rename temporal file into EndpointDetails * Remove unused dispatch * Refactor ingestPolicies dispatching in the middleware Co-authored-by: Esteban Beltran <[email protected]>
… correctly (#108551) * update endpoint middleware to load data correctly fixes kibana/issues/108497 modifies changes done in /pull/107632 and /pull/108330 * await results fixes /issues/108497 * review comments * Add a test to cover this case fixes /issues/108497 Co-authored-by: Kibana Machine <[email protected]>
… correctly (elastic#108551) * update endpoint middleware to load data correctly fixes kibana/issues/108497 modifies changes done in elastic/pull/107632 and elastic/pull/108330 * await results fixes elastic/issues/108497 * review comments * Add a test to cover this case fixes elastic/issues/108497 Co-authored-by: Kibana Machine <[email protected]>
… correctly (#108551) (#108678) * update endpoint middleware to load data correctly fixes kibana/issues/108497 modifies changes done in /pull/107632 and /pull/108330 * await results fixes /issues/108497 * review comments * Add a test to cover this case fixes /issues/108497 Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Ashokaditya <[email protected]>
Summary
This PR is a continuation to #107632
Even though there seem to be many changes, this PR doesn't change any business logic. It moves things from a file to other and adds a new redux action to later be used.
Tests will be added for this new component after is moved to common components in the following refactor PR.
What in the past was a component like this:
turns to be:
and the DetailsContent would be:
What had been done:
TODO in upcoming PRs:
Checklist
Delete any items that are not applicable to this PR.