[Security Solution] Move endpointdetails into its own middleware function

[academo]

Summary

This is the first of a small series of PRs to decouple the endpoint details flyout from its current place in the endpoints tab.

This PR Refactors the endpoint middleware by splitting the main big middleware function into smaller ones.

Checklist

Delete any items that are not applicable to this PR.

• Unit or functional tests were updated or added to match the most common scenarios

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[elasticmachine]

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

[paul-tavares]

This looks good to me - thank you for breaking it up.

Can you check if we can remove the ESLint disabled rule for complexity on line 88 now that this is main middleware function is allot simpler?

[academo]

This looks good to me - thank you for breaking it up.

Can you check if we can remove the ESLint disabled rule for complexity on line 88 now that this is main middleware function is allot simpler?

Yes. I pushed the last bit to remove it.

[kibanamachine]

💛 Build succeeded, but was flaky

• continuous-integration/kibana-ci/pull-request

• Commit: c1fd23e

• Storybooks Preview

• Flaky suites:

  • kibana-ciGroup7

---

Test Failures

Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/management/_index_pattern_create_delete·js.management creating and deleting default index validation can display errors

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 11 times on tracked branches: https://github.com/elastic/kibana/issues/107831

[00:00:00]       │
[00:00:00]         └-: management
[00:00:00]           └-> "before all" hook in "management"
[00:00:00]           └-> "before all" hook in "management"
[00:00:00]             │ info [test/functional/fixtures/es_archiver/logstash_functional] Unloading indices from "mappings.json"
[00:00:00]             │ info [test/functional/fixtures/es_archiver/logstash_functional] Unloading indices from "data.json.gz"
[00:00:01]             │ info [test/functional/fixtures/es_archiver/makelogs] Loading "mappings.json"
[00:00:01]             │ info [test/functional/fixtures/es_archiver/makelogs] Loading "data.json.gz"
[00:00:01]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.17] creating index, cause [api], templates [], shards [1]/[0]
[00:00:01]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.17][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.17][0]]"
[00:00:01]             │ info [test/functional/fixtures/es_archiver/makelogs] Created index "logstash-2015.09.17"
[00:00:01]             │ debg [test/functional/fixtures/es_archiver/makelogs] "logstash-2015.09.17" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:01]             │ info [o.e.c.m.MetadataCreateIndexService] [node-01] [logstash-2015.09.18] creating index, cause [api], templates [], shards [1]/[0]
[00:00:01]             │ info [o.e.c.r.a.AllocationService] [node-01] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[logstash-2015.09.18][0]]])." previous.health="YELLOW" reason="shards started [[logstash-2015.09.18][0]]"
[00:00:01]             │ info [test/functional/fixtures/es_archiver/makelogs] Created index "logstash-2015.09.18"
[00:00:01]             │ debg [test/functional/fixtures/es_archiver/makelogs] "logstash-2015.09.18" settings {"index":{"analysis":{"analyzer":{"url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:01]             │ info [test/functional/fixtures/es_archiver/makelogs] Indexed 101 docs into "logstash-2015.09.17"
[00:00:01]             │ info [test/functional/fixtures/es_archiver/makelogs] Indexed 301 docs into "logstash-2015.09.18"
[00:00:02]           └-: 
[00:00:02]             └-> "before all" hook in ""
[00:00:26]             └-: creating and deleting default index
[00:00:26]               └-> "before all" hook in "creating and deleting default index"
[00:00:26]               └-> "before all" hook in "creating and deleting default index"
[00:00:26]                 │ debg replacing kibana config doc: {}
[00:00:27]                 │ debg navigating to settings url: http://localhost:6131/app/management
[00:00:27]                 │ debg navigate to: http://localhost:6131/app/management
[00:00:27]                 │ debg browser[INFO] http://localhost:6131/app/management?_t=1628509878576 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:27]                 │
[00:00:27]                 │ debg browser[INFO] http://localhost:6131/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:27]                 │ debg ... sleep(700) start
[00:00:27]                 │ debg ... sleep(700) end
[00:00:27]                 │ debg returned from get, calling refresh
[00:00:28]                 │ debg browser[INFO] http://localhost:6131/app/management?_t=1628509878576 281 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:28]                 │
[00:00:28]                 │ debg browser[INFO] http://localhost:6131/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:29]                 │ debg currentUrl = http://localhost:6131/app/management
[00:00:29]                 │          appUrl = http://localhost:6131/app/management
[00:00:29]                 │ debg TestSubjects.find(kibanaChrome)
[00:00:29]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:29]                 │ debg ... sleep(501) start
[00:00:29]                 │ debg ... sleep(501) end
[00:00:29]                 │ debg in navigateTo url = http://localhost:6131/app/management
[00:00:29]                 │ debg clickKibanaIndexPatterns link
[00:00:30]                 │ debg TestSubjects.click(indexPatterns)
[00:00:30]                 │ debg Find.clickByCssSelector('[data-test-subj="indexPatterns"]') with timeout=10000
[00:00:30]                 │ debg Find.findByCssSelector('[data-test-subj="indexPatterns"]') with timeout=10000
[00:00:30]                 │ debg isGlobalLoadingIndicatorVisible
[00:00:30]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:00:30]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:00:31]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:00:32]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:00:32]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:00:34]               └-: validation
[00:00:34]                 └-> "before all" hook for "can display errors"
[00:00:34]                 └-> can display errors
[00:00:34]                   └-> "before each" hook: global before each for "can display errors"
[00:00:34]                   │ debg TestSubjects.exists(createIndexPatternButtonFlyout)
[00:00:34]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="createIndexPatternButtonFlyout"]') with timeout=2500
[00:00:37]                   │ debg --- retry.tryForTime error: [data-test-subj="createIndexPatternButtonFlyout"] is not displayed
[00:00:37]                   │ debg TestSubjects.exists(createIndexPatternButton)
[00:00:37]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="createIndexPatternButton"]') with timeout=2500
[00:00:37]                   │ debg TestSubjects.click(createIndexPatternButton)
[00:00:37]                   │ debg Find.clickByCssSelector('[data-test-subj="createIndexPatternButton"]') with timeout=10000
[00:00:37]                   │ debg Find.findByCssSelector('[data-test-subj="createIndexPatternButton"]') with timeout=10000
[00:00:37]                   │ debg TestSubjects.exists(createIndexPatternButtonFlyout)
[00:00:37]                   │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="createIndexPatternButtonFlyout"]') with timeout=2500
[00:00:37]                   │ debg TestSubjects.click(createIndexPatternButtonFlyout)
[00:00:37]                   │ debg Find.clickByCssSelector('[data-test-subj="createIndexPatternButtonFlyout"]') with timeout=10000
[00:00:37]                   │ debg Find.findByCssSelector('[data-test-subj="createIndexPatternButtonFlyout"]') with timeout=10000
[00:00:37]                   │ debg setIndexPatternField(log*)
[00:00:37]                   │ debg TestSubjects.find(createIndexPatternNameInput)
[00:00:37]                   │ debg Find.findByCssSelector('[data-test-subj="createIndexPatternNameInput"]') with timeout=10000
[00:00:38]                   │ debg setIndexPatternField set to log*
[00:00:38]                   │ debg TestSubjects.find(saveIndexPatternButton)
[00:00:38]                   │ debg Find.findByCssSelector('[data-test-subj="saveIndexPatternButton"]') with timeout=10000
[00:00:38]                   │ debg Find.findByClassName('euiFormErrorText') with timeout=10000
[00:00:48]                   │ info Taking screenshot "/dev/shm/workspace/parallel/3/kibana/test/functional/screenshots/failure/management  creating and deleting default index validation can display errors.png"
[00:00:48]                   │ info Current URL is: http://localhost:6131/app/management/kibana/indexPatterns/patterns/22c236a0-f908-11eb-8e44-c133e9a2ec48#/?_a=(tab:indexedFields)
[00:00:48]                   │ info Saving page source to: /dev/shm/workspace/parallel/3/kibana/test/functional/failure_debug/html/management  creating and deleting default index validation can display errors.html
[00:00:48]                   └- ✖ fail: management  creating and deleting default index validation can display errors
[00:00:48]                   │      TimeoutError: Waiting for element to be located By(css selector, .euiFormErrorText)
[00:00:48]                   │ Wait timed out after 10017ms
[00:00:48]                   │       at /dev/shm/workspace/parallel/3/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
[00:00:48]                   │       at runMicrotasks (<anonymous>)
[00:00:48]                   │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:00:48]                   │ 
[00:00:48]                   │ 

Stack Trace

TimeoutError: Waiting for element to be located By(css selector, .euiFormErrorText)
Wait timed out after 10017ms
    at /dev/shm/workspace/parallel/3/kibana/node_modules/selenium-webdriver/lib/webdriver.js:842:17
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5) {
  remoteStacktrace: ''
}

---

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
securitySolution	6.5MB	6.5MB	+768.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
securitySolution	832	834	+2

History

• 💛 Build #143606 was flaky 11a6a46
• 💚 Build #142912 succeeded a6fea49

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[kibanamachine]

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.