Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] [Alerting] adjust Uptime RAC RBAC and index settings #108200

Merged
merged 7 commits into from
Aug 16, 2021
Merged

[Uptime] [Alerting] adjust Uptime RAC RBAC and index settings #108200

merged 7 commits into from
Aug 16, 2021

Conversation

dominiqueclarke
Copy link
Contributor

@dominiqueclarke dominiqueclarke commented Aug 11, 2021 •
edited
Loading

Fixes #108202

Summary

This PR adjusts Uptime RBAC settings. Previously, we were aliasing uptime RAC data with the "synthetics" name. However, synthetics does not match with the "uptime" capability within our permission model. To keep things simple, we should continue using "uptime" for alerting related items.

Testing

  1. Start heartbeat with a monitor that will always resolve to down
  2. Navigate to Uptime and create a monitor status alert by either using the alert status toggle or alerts and rules dropdown in the heading
  3. Navigate to /app/observability/alerts to observe the alert

@dominiqueclarke dominiqueclarke added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed v7.15.0 labels Aug 11, 2021
@dominiqueclarke dominiqueclarke requested a review from a team as a code owner August 11, 2021 14:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

vigneshshanmugam
vigneshshanmugam approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

justinkambic
justinkambic approved these changes Aug 12, 2021
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and smoke test LGTM

image

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream`

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@dominiqueclarke
Copy link
Contributor Author

@elasticmachine merge upstream

@banderror banderror mentioned this pull request Aug 16, 2021
Closed
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 4.3MB 4.3MB -16.0B
observability 483.6KB 483.6KB -20.0B
securitySolution 6.5MB 6.5MB -16.0B
timelines 407.9KB 407.9KB -16.0B
total -68.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 149.2KB 149.1KB -16.0B
uptime 36.0KB 36.0KB -16.0B
total -32.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dominiqueclarke dominiqueclarke merged commit 024eeed into elastic:master Aug 16, 2021
@dominiqueclarke dominiqueclarke deleted the fix/uptime-alerting-rbac branch August 16, 2021 18:01
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Aug 16, 2021
@dominiqueclarke @kibanamachine
[Uptime] adjust RAC RBAC and index settings (elastic#108200)
088d833 
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine kibanamachine mentioned this pull request Aug 16, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Aug 16, 2021
@kibanamachine @dominiqueclarke
[Uptime] adjust RAC RBAC and index settings (#108200) (#108752)
2363c27 
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Dominique Clarke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

@vigneshshanmugam vigneshshanmugam vigneshshanmugam approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.15.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Uptime] [Alerting] Uptime Alerts do not show up in Observability alerts table. RBAC Settings need adjustment
5 participants
@dominiqueclarke @elasticmachine @kibanamachine @vigneshshanmugam @justinkambic