-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index pattern creation - text improvements #107860
Index pattern creation - text improvements #107860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ to index alias
Can you please provide screenshots that shows the latest for these two messages. I'd like to see how the final text looks.
-
The index pattern you entered doesn't match any indices. You can match 1 index below.
-
Your index pattern doesn't match an indices, but you have an index that looks similar.
...ugins/index_pattern_editor/public/components/preview_panel/status_message/status_message.tsx
Outdated
Show resolved
Hide resolved
...ugins/index_pattern_editor/public/components/preview_panel/status_message/status_message.tsx
Outdated
Show resolved
Hide resolved
...ugins/index_pattern_editor/public/components/preview_panel/status_message/status_message.tsx
Outdated
Show resolved
Hide resolved
@gchaps Here are your requested screenshots - |
A few comments: Is this hint text still correct. It only mentions indices. Or should it be "to match multiple sources" or "to match multiple characters" It seems to me that a word is needed after the number 1. Does this work: Your index pattern doesn't match any data streams, indices, or index aliases, but 1 source is similar. How about this: No data streams, indices, or index aliases match your index pattern. You can match 1 source. |
Pinging @elastic/kibana-app-services (Team:AppServices) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for updating the text.
💚 Build SucceededMetrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
* text improvements
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
* text improvements Co-authored-by: Matthew Kime <[email protected]>
Summary
Minor text improvements in follow up to #101853
Its worth noting that I tried to standardize around
index alias
instead of justalias
as its a searchable technical term but if I'm causing trouble I'm happy change course.