Skip to content

Commit

Permalink
Index pattern creation - text improvements (#107860)
Browse files Browse the repository at this point in the history
* text improvements
  • Loading branch information
mattkime authored Aug 16, 2021
1 parent 34eb8c6 commit 0153bdb
Show file tree
Hide file tree
Showing 10 changed files with 20 additions and 47 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export const EmptyIndexPatternPrompt = ({
<p>
<FormattedMessage
id="indexPatternEditor.emptyIndexPatternPrompt.indexPatternExplanation"
defaultMessage="Kibana requires an index pattern to identify which data streams, indices, and aliases you want to explore. An
defaultMessage="Kibana requires an index pattern to identify which data streams, indices, and index aliases you want to explore. An
index pattern can point to a specific index, for example, your log data from
yesterday, or all indices that contain your log data."
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const getTimestampConfig = (
};

const noTimestampOptionText = i18n.translate('indexPatternEditor.editor.form.noTimeFieldsLabel', {
defaultMessage: 'No matching data stream, index, or alias has a timestamp field.',
defaultMessage: 'No matching data stream, index, or index alias has a timestamp field.',
});

const timestampFieldHelp = i18n.translate('indexPatternEditor.editor.form.timeFieldHelp', {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ const rollupIndexPatternTooManyMatchesError = {

const mustMatchError = {
message: i18n.translate('indexPatternEditor.createIndex.noMatch', {
defaultMessage: 'Name must match one or more data streams, indices, or aliases.',
defaultMessage: 'Name must match one or more data streams, indices, or index aliases.',
}),
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const schema = {
defaultValue: '',
helpText: i18n.translate('indexPatternEditor.validations.titleHelpText', {
defaultMessage:
'Use an asterisk (*) to match multiple indices. Spaces and the characters , /, ?, ", <, >, | are not allowed.',
'Use an asterisk (*) to match multiple characters. Spaces and the characters , /, ?, ", <, >, | are not allowed.',
}),
validations: [
{
Expand Down
26 changes: 0 additions & 26 deletions src/plugins/index_pattern_editor/public/components/i18n_texts.ts

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ export { TimestampField, TypeField, TitleField } from './form_fields';
export { EmptyPrompts } from './empty_prompts';
export { PreviewPanel } from './preview_panel';
export { LoadingIndices } from './loading_indices';
export { geti18nTexts } from './i18n_texts';
export { Footer } from './footer';
export { AdvancedParamsContent } from './advanced_params_content';
export { RollupBetaWarning } from './rollup_beta_warning';

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ const NoMatchStatusMessage = (allIndicesLength: number) => (
<span>
<FormattedMessage
id="indexPatternEditor.status.notMatchLabel.notMatchDetail"
defaultMessage="The index pattern you've entered doesn't match any indices, data streams, or index aliases.
You can match {strongIndices}, below."
defaultMessage="The index pattern you entered doesn't match any data streams, indices, or index aliases.
You can match {strongIndices}."
values={{
strongIndices: (
<strong>
Expand All @@ -49,7 +49,7 @@ const NoMatchNoIndicesStatusMessage = () => (
<span>
<FormattedMessage
id="indexPatternEditor.status.notMatchLabel.notMatchNoIndicesDetail"
defaultMessage="The index pattern you've entered doesn't match any indices."
defaultMessage="The index pattern you entered doesn't match any data streams, indices, or index aliases."
/>
</span>
);
Expand All @@ -75,9 +75,9 @@ export const StatusMessage: React.FC<StatusMessageProps> = ({
<span>
<FormattedMessage
id="indexPatternEditor.status.matchAnyLabel.matchAnyDetail"
defaultMessage="Your index pattern has {sourceCount, plural,
one {# match}
other {# matches}
defaultMessage="Your index pattern can match {sourceCount, plural,
one {# source}
other {# sources}
}."
values={{ sourceCount: allIndicesLength }}
/>
Expand All @@ -88,7 +88,7 @@ export const StatusMessage: React.FC<StatusMessageProps> = ({
<span>
<FormattedMessage
id="indexPatternEditor.status.noSystemIndicesWithPromptLabel"
defaultMessage="No Elasticsearch indices match your pattern."
defaultMessage="No data streams, indices, or index aliases match your index pattern."
/>
</span>
);
Expand All @@ -97,7 +97,7 @@ export const StatusMessage: React.FC<StatusMessageProps> = ({
<span>
<FormattedMessage
id="indexPatternEditor.status.noSystemIndicesLabel"
defaultMessage="No Elasticsearch indices match your pattern."
defaultMessage="No data streams, indices, or index aliases match your index pattern."
/>
</span>
);
Expand Down Expand Up @@ -127,7 +127,7 @@ export const StatusMessage: React.FC<StatusMessageProps> = ({
<span>
<FormattedMessage
id="indexPatternEditor.status.partialMatchLabel.partialMatchDetail"
defaultMessage="Your index pattern doesn't match any sources, but you have {strongIndices} which
defaultMessage="Your index pattern doesn't match any data streams, indices, or index aliases, but {strongIndices}
{matchedIndicesLength, plural,
one {is}
other {are}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ export default function ({ getService, getPageObjects }) {

await retry.try(async () => {
expect(await testSubjects.getVisibleText('createIndexPatternStatusMessage')).to.contain(
`The index pattern you've entered doesn't match any indices`
`The index pattern you entered doesn\'t match any data streams, indices, or index aliases.`
);
});
});
Expand Down

0 comments on commit 0153bdb

Please sign in to comment.