[APM] always prefer url over transaction.page.url #107613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 7.9.0, APM Server has been copying the `transaction.page.url` value to the ECS `url` field. We should still use `transaction.page.url` if it exists and `url` does not (i.e. for very old docs), but we should stop expecting it in newly written documents.
|
Pinging @elastic/apm-ui (Team:apm) |
axw
added
release_note:skip
axw
changed the title
1 task
axw
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 4, 2021
Since 7.9.0, APM Server has been copying the `transaction.page.url` value to the ECS `url` field. We should still use `transaction.page.url` if it exists and `url` does not (i.e. for very old docs), but we should stop expecting it in newly written documents.
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Aug 4, 2021
Since 7.9.0, APM Server has been copying the `transaction.page.url` value to the ECS `url` field. We should still use `transaction.page.url` if it exists and `url` does not (i.e. for very old docs), but we should stop expecting it in newly written documents. Co-authored-by: Andrew Wilkins <[email protected]>
streamich
pushed a commit
to vadimkibana/kibana
that referenced
this pull request
Aug 8, 2021
Since 7.9.0, APM Server has been copying the `transaction.page.url` value to the ECS `url` field. We should still use `transaction.page.url` if it exists and `url` does not (i.e. for very old docs), but we should stop expecting it in newly written documents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since 7.9.0, APM Server has been copying the
transaction.page.urlvalue to the ECSurlfield. We should still usetransaction.page.urlif it exists andurldoes not (i.e. for very old docs), but we should stop expecting it in newly written documents.Closes #107493
Checklist
- [ ] Unit or functional tests were updated or added to match the most common scenarios(Couldn't find any existing test, doesn't seem worthwhile to add one.)For maintainers