Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] remove transaction.page field #107493

Closed
axw opened this issue Aug 3, 2021 · 2 comments · Fixed by #107613
Closed

[APM] remove transaction.page field #107493

axw opened this issue Aug 3, 2021 · 2 comments · Fixed by #107613
Labels
Team:APM All issues that need APM UI Team support

Comments

@axw
Copy link
Member

axw commented Aug 3, 2021

In 7.9.0, APM Server started duplicating the non-standard RUM-specific transaction.page.* fields under the ECS url.* and http.* fields. I would like to remove the old transaction.page.* fields. I think we can mostly leave the UI code untouched so it can continue to visualise old RUM data, except for this snippet:

const isRumAgent = isRumAgentName(transaction.agent.name);
const url = isRumAgent
? transaction.transaction.page?.url
: transaction.url?.full;

If we replace this with something like the following, then I think we we're good:

const url = transaction.url?.full || transaction.transaction?.page?.url;
@axw axw added the Team:APM All issues that need APM UI Team support label Aug 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

Sgtm 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:APM All issues that need APM UI Team support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants