[APM] Backends inventory & overview page routes #106223

dgieselaar · 2021-07-20T11:04:06Z

Adds inventory & overview pages for backends, and a latency chart for the latter.

…ng-page

elasticmachine · 2021-07-20T11:04:09Z

Pinging @elastic/apm-ui (Team:apm)

dgieselaar · 2021-07-20T11:05:50Z

x-pack/plugins/apm/public/components/app/backend_detail_overview/backend_latency_chart.tsx

+          query: {
+            start,
+            end,
+            offset,


I figure offset is a simpler API than comparisonStart + comparisonEnd, but open to feedback here.

I feel like if this was changed we should update the others APIs too. Otherwise now we'll have two ways to get comparison data.

joshdover

ES type changes LGTM

smith

Works great. Just blocking to add the line for deepLinks so it shows up in global search.

smith · 2021-07-20T18:43:29Z

x-pack/plugins/apm/public/components/app/backend_detail_overview/backend_latency_chart.tsx

+
+  const theme = useTheme();
+
+  const { start, end } = useTimeRange();


smith · 2021-07-20T18:46:01Z

x-pack/plugins/apm/public/components/app/backend_detail_overview/index.tsx

+  const {
+    path: { backendName },
+    query,
+  } = useApmParams('/backends/:backendName/overview');


Are backends uniquely keyed by their name? Seems like it would be common to have more than one "postgres" or "redis".

yeah, they can be different instances but we group them by span.destination.service.resource - at least I don't think there's any other way, as the instances themselves are not instrumented.

smith · 2021-07-20T18:57:52Z

x-pack/plugins/apm/public/plugin.ts

@@ -117,6 +121,7 @@ export class ApmPlugin implements Plugin<ApmPluginSetup, ApmPluginStart> {
                  { label: servicesTitle, app: 'apm', path: '/services' },
                  { label: tracesTitle, app: 'apm', path: '/traces' },
                  { label: serviceMapTitle, app: 'apm', path: '/service-map' },
+                  { label: backendsTitle, app: 'apm', path: '/backends' },


We should also add a link in deepLinks around line 250.

…ng-page

kibanamachine · 2021-07-21T13:28:50Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`apm`	1560	1567	+7

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`apm`	4.3MB	4.3MB	+5.4KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`apm`	40.3KB	40.6KB	+229.0B

History

💔 Build #139687 failed 1c173ee

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-07-21T13:33:29Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

…y-show-migrate-to-authzd-users * 'master' of github.com:elastic/kibana: (48 commits) [Canvas] Expression shape (elastic#103219) [FTR] Skips Vega tests [Sample data] Use Lens in ecommerce data (elastic#106039) [APM] Backends inventory & overview page routes (elastic#106223) [TSVB] Add more functional tests for Gauge and TopN (elastic#105361) Add toggle to enable/disable rule install from SOs (elastic#106189) Improve unit test coverage of FS API calls (elastic#106242) Remove recursive plugin status in meta field (elastic#106286) [Ingest pipelines] add community id processor (elastic#103863) [XY axis] Fixes the values inside bar charts (elastic#106198) [data.search] Set default expiration to 1m if search sessions are disabled (elastic#105329) set the doc title when navigating to reporting and unset when navigating away (elastic#106253) [Lens] Display legend inside chart (elastic#105571) [RAC] [TGrid] Migrate the TGrid's rendering to `EuiDataGrid` (elastic#106199) [Security Solutions] Removes the elastic legacy client from lists and security_solution plugins (elastic#106130) [Enterprise Search] Require security plugin in 8.0 (elastic#106307) [DOCS] Updates screenshots in Dev Tools docs (elastic#105859) [DOCS] Updates text and screenshots in tags doc (elastic#105853) [Alerting] Allow rule types to extract/inject saved object references on rule CRU (elastic#101896) Jest and Storybook fixes (elastic#104991) ... # Conflicts: # x-pack/plugins/reporting/public/plugin.ts

Co-authored-by: Dario Gieselaar <[email protected]>

dgieselaar added 2 commits July 20, 2021 12:53

[APM] Backends inventory & overview page routes

9a91368

Adds inventory & overview pages for backends, and a latency chart for the latter.

Merge branch 'master' of github.com:elastic/kibana into backend-landi…

1c173ee

…ng-page

dgieselaar added Team:APM All issues that need APM UI Team support release_note:skip Skip the PR/issue when compiling release notes v7.15.0 labels Jul 20, 2021

dgieselaar requested review from a team as code owners July 20, 2021 11:04

dgieselaar commented Jul 20, 2021

View reviewed changes

joshdover approved these changes Jul 20, 2021

View reviewed changes

smith requested changes Jul 20, 2021

View reviewed changes

dgieselaar added 2 commits July 21, 2021 12:25

Merge branch 'master' of github.com:elastic/kibana into backend-landi…

ed5967e

…ng-page

Add backends to deeplinks, fix type error

1d67ffd

dgieselaar requested a review from smith July 21, 2021 12:28

smith approved these changes Jul 21, 2021

View reviewed changes

dgieselaar added the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 21, 2021

dgieselaar enabled auto-merge (squash) July 21, 2021 13:09

dgieselaar merged commit 3039db2 into elastic:master Jul 21, 2021

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 21, 2021

[APM] Backends inventory & overview page routes (elastic#106223)

09f3841

kibanamachine mentioned this pull request Jul 21, 2021

[7.x] [APM] Backends inventory & overview page routes (#106223) #106407

Merged

kibanamachine added a commit that referenced this pull request Jul 21, 2021

[APM] Backends inventory & overview page routes (#106223) (#106407)

0451402

Co-authored-by: Dario Gieselaar <[email protected]>

smith mentioned this pull request Jul 27, 2021

[APM] Backends UI: Add link from the Service overview dependencies table #103260

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[APM] Backends inventory & overview page routes #106223

[APM] Backends inventory & overview page routes #106223

dgieselaar commented Jul 20, 2021

elasticmachine commented Jul 20, 2021

dgieselaar Jul 20, 2021

cauemarcondes Jul 21, 2021

joshdover left a comment

smith left a comment

smith Jul 20, 2021

smith Jul 20, 2021

dgieselaar Jul 21, 2021

smith Jul 20, 2021

dgieselaar Jul 21, 2021

kibanamachine commented Jul 21, 2021

kibanamachine commented Jul 21, 2021


		const theme = useTheme();

		const { start, end } = useTimeRange();

[APM] Backends inventory & overview page routes #106223

[APM] Backends inventory & overview page routes #106223

Conversation

dgieselaar commented Jul 20, 2021

elasticmachine commented Jul 20, 2021

dgieselaar Jul 20, 2021

Choose a reason for hiding this comment

cauemarcondes Jul 21, 2021

Choose a reason for hiding this comment

joshdover left a comment

Choose a reason for hiding this comment

smith left a comment

Choose a reason for hiding this comment

smith Jul 20, 2021

Choose a reason for hiding this comment

smith Jul 20, 2021

Choose a reason for hiding this comment

dgieselaar Jul 21, 2021

Choose a reason for hiding this comment

smith Jul 20, 2021

Choose a reason for hiding this comment

dgieselaar Jul 21, 2021

Choose a reason for hiding this comment

kibanamachine commented Jul 21, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

kibanamachine commented Jul 21, 2021

💚 Backport successful