[APM] Display automatic deployment annotations correctly #102020
Conversation
dgieselaar
added
release_note:fix
v7.14.0
v7.13.0
auto-backport
|
Pinging @elastic/apm-ui (Team:apm) |
| }); | ||
| } | ||
|
|
||
| await es.indices.create({ |
There was a problem hiding this comment.
Do you really need to create the index before calling the API? I thought that happened automatically
There was a problem hiding this comment.
If you create an index template yes, otherwise you have to create it manually right?
| }); | ||
|
|
||
| const docs = dates.flatMap((date, index) => { | ||
| const defaults = { |
There was a problem hiding this comment.
nit: naming
| const defaults = { | |
| const defaultAnnotation = { |
or
| const defaults = { | |
| const baseAnnotation = { |
|
|
||
| await es.bulk({ | ||
| index: indexName, | ||
| body: docs.flatMap((doc) => [{ index: {} }, doc]), |
There was a problem hiding this comment.
Why are you adding an empty doc for every annotation doc?
There was a problem hiding this comment.
I'm not, I think? This is how the bulk API works: an operation (in this case index), followed by the document.
There was a problem hiding this comment.
Ah yes. i forgot that's how it works. So weird that the ES client doesn't abstract that away if you ask me.
|
jenkins run the e2e |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
…102061) Co-authored-by: Dario Gieselaar <[email protected]>
…102062) Co-authored-by: Dario Gieselaar <[email protected]>
|
@dgieselaar is there an easy way to test it? |
|
Tests ok. Versions annotations shown at proper positions instead of how reported in original bug. |
smith
added
the
apm:test-plan-done
Closes #101760.