Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Automatic deployment annotations are incorrectly displayed #101760

Closed
dgieselaar opened this issue Jun 9, 2021 · 2 comments · Fixed by #102020
Closed

[APM] Automatic deployment annotations are incorrectly displayed #101760

dgieselaar opened this issue Jun 9, 2021 · 2 comments · Fixed by #102020
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.13.0

Comments

@dgieselaar
Copy link
Member

We automatically show deployment annotations based on service.version if the user is not using the API. The logic is as follows:

  • get all the values for service.version in the given time range
  • if there is more than one, fetch the oldest document (not by the given time range) for each value of service.version: "first seen"
  • display an annotation at/if its "first seen" timestamp is within the given time range.

However, in #92112, I changed the min aggregation to fetch + sorting on @timestamp. Unfortunately I used descending instead of ascending, which results in the annotation almost always being displayed, because it uses the last seen instead of the first seen, as reported by @LucaWintergerst.

@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.13.0 labels Jun 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@LucaWintergerst
Copy link
Contributor

Screenshot 2021-06-10 at 08 42 50

Adding some context to what this looks like and when it happens. When running a service with two different versions, two annotations will be displayed at the end of the chart when the last event for each respective service happened. It will keep happening until the current time window only has data from one service version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.13.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants