Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] "Redesigned alert experience Tour" position is not updated after resizing the Alert Details Flyout #197492

Closed
vgomez-el opened this issue Oct 23, 2024 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Milestone

Comments

@vgomez-el
Copy link

Describe the bug:
When the Alert Details Flyout is resized, the guided tour indicator fails to update its position accordingly. This causes the tour pointer to reference incorrect locations within the interface, leading to misaligned guidance for users.

Kibana/Elasticsearch Stack version:
8.16 BC1

Server OS version:

Browser and Browser OS versions:
Google Chrome

Elastic Endpoint version:

Original install method (e.g. download page, yum, from source, etc.):
Cloud deployment

Functional Area (e.g. Endpoint management, timelines, resolver, etc.):
Alert Details Flyout

Steps to reproduce:
Preconditions: User should have alert listed on Alerts table

  1. Navigate to Alerts table
  2. Click on "View Details" icon from a listed alert
  3. resize the alert details Flyout
  4. Notice the tour position

Current behavior:
Tour indicator position is not updated properly

Expected behavior:
Tour position should be updated according to the resize of the flyout

Screenshots (if relevant):
https://github.com/user-attachments/assets/99986731-abf3-452b-9df2-add323bffe5f

Image
Image

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context (logs, chat logs, magical formulas, etc.):

@vgomez-el vgomez-el added bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team Team:Threat Hunting:Investigations Security Solution Investigations Team triage_needed labels Oct 23, 2024
@vgomez-el vgomez-el added this to the 8.16 milestone Oct 23, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations)

@PhilippeOberti PhilippeOberti removed their assignment Oct 24, 2024
@PhilippeOberti PhilippeOberti removed this from the 8.16 milestone Oct 29, 2024
PhilippeOberti added a commit that referenced this issue Nov 4, 2024
… 8.14 (#198708)

## Summary

We [added](#180318) a guided tour
to the expandable flyout back in `8.14`. It is time to remove it as
enough users have seen it.

No UI changes other than the tour not showing up.

### How to test

- clear local storage (more specifically remove the
`securitySolution.documentDetails.newFeaturesTour.v8.14` key
- open a alert or event details flyout and verify that the tour does not
show up

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Should help solve #197492
@PhilippeOberti PhilippeOberti added this to the 8.17 milestone Nov 4, 2024
@PhilippeOberti
Copy link
Contributor

PhilippeOberti commented Nov 4, 2024

this bug isn't present anymore as we removed the tour entirely in 8.17 (see this PR and it's 8.x backport)

PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this issue Nov 4, 2024
… 8.14 (elastic#198708)

## Summary

We [added](elastic#180318) a guided tour
to the expandable flyout back in `8.14`. It is time to remove it as
enough users have seen it.

No UI changes other than the tour not showing up.

### How to test

- clear local storage (more specifically remove the
`securitySolution.documentDetails.newFeaturesTour.v8.14` key
- open a alert or event details flyout and verify that the tour does not
show up

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Should help solve elastic#197492

(cherry picked from commit 0aec5a8)

# Conflicts:
#	x-pack/packages/security-solution/common/src/flyout/common/components/flyout_navigation.tsx
#	x-pack/plugins/security_solution/public/flyout/document_details/shared/utils/tour_step_config.tsx
#	x-pack/plugins/translations/translations/fr-FR.json
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this issue Nov 4, 2024
… 8.14 (elastic#198708)

## Summary

We [added](elastic#180318) a guided tour
to the expandable flyout back in `8.14`. It is time to remove it as
enough users have seen it.

No UI changes other than the tour not showing up.

### How to test

- clear local storage (more specifically remove the
`securitySolution.documentDetails.newFeaturesTour.v8.14` key
- open a alert or event details flyout and verify that the tour does not
show up

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Should help solve elastic#197492

(cherry picked from commit 0aec5a8)

# Conflicts:
#	x-pack/packages/security-solution/common/src/flyout/common/components/flyout_navigation.tsx
#	x-pack/plugins/security_solution/public/flyout/document_details/shared/utils/tour_step_config.tsx
#	x-pack/plugins/translations/translations/fr-FR.json
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this issue Nov 4, 2024
… 8.14 (elastic#198708)

## Summary

We [added](elastic#180318) a guided tour
to the expandable flyout back in `8.14`. It is time to remove it as
enough users have seen it.

No UI changes other than the tour not showing up.

### How to test

- clear local storage (more specifically remove the
`securitySolution.documentDetails.newFeaturesTour.v8.14` key
- open a alert or event details flyout and verify that the tour does not
show up

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Should help solve elastic#197492

(cherry picked from commit 0aec5a8)

# Conflicts:
#	x-pack/packages/security-solution/common/src/flyout/common/components/flyout_navigation.tsx
#	x-pack/plugins/security_solution/public/flyout/document_details/shared/utils/tour_step_config.tsx
#	x-pack/plugins/translations/translations/fr-FR.json
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@MadameSheema
Copy link
Member

@vgomez-el can we close this ticket?

PhilippeOberti added a commit to PhilippeOberti/kibana that referenced this issue Nov 5, 2024
… 8.14 (elastic#198708)

## Summary

We [added](elastic#180318) a guided tour
to the expandable flyout back in `8.14`. It is time to remove it as
enough users have seen it.

No UI changes other than the tour not showing up.

### How to test

- clear local storage (more specifically remove the
`securitySolution.documentDetails.newFeaturesTour.v8.14` key
- open a alert or event details flyout and verify that the tour does not
show up

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Should help solve elastic#197492

(cherry picked from commit 0aec5a8)

# Conflicts:
#	x-pack/packages/security-solution/common/src/flyout/common/components/flyout_navigation.tsx
#	x-pack/plugins/security_solution/public/flyout/document_details/shared/utils/tour_step_config.tsx
#	x-pack/plugins/translations/translations/fr-FR.json
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@vgomez-el
Copy link
Author

Sure thing @MadameSheema , bug can be considered as fixed since the tour removal. I have tested and validated that the tour is not displayed in 8.16 BC3:
Image

Thanks @PhilippeOberti for fixing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Investigations Security Solution Investigations Team Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Development

No branches or pull requests

4 participants