[Security Solution][Alert Details] - remove flyout tour introduced in…

… 8.14 (#198708)

## Summary

We [added](#180318) a guided tour
to the expandable flyout back in `8.14`. It is time to remove it as
enough users have seen it.

No UI changes other than the tour not showing up.

### How to test

- clear local storage (more specifically remove the
`securitySolution.documentDetails.newFeaturesTour.v8.14` key
- open a alert or event details flyout and verify that the tour does not
show up

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

Should help solve #197492

x-pack/plugins/fleet/cypress/tasks/common.ts

@@ -67,7 +67,6 @@ export const internalRequest = <T = unknown>({
 const NEW_FEATURES_TOUR_STORAGE_KEYS = {
   RULE_MANAGEMENT_PAGE: 'securitySolution.rulesManagementPage.newFeaturesTour.v8.9',
   TIMELINES: 'securitySolution.security.timelineFlyoutHeader.saveTimelineTour',
-  FLYOUT: 'securitySolution.documentDetails.newFeaturesTour.v8.14',
 };
 
 const disableNewFeaturesTours = (window: Window) => {

x-pack/plugins/osquery/cypress/tasks/navigation.ts

@@ -45,8 +45,6 @@ export enum NAV_SEARCH_INPUT_OSQUERY_RESULTS {
 export const NEW_FEATURES_TOUR_STORAGE_KEYS = {
   RULE_MANAGEMENT_PAGE: 'securitySolution.rulesManagementPage.newFeaturesTour.v8.13',
   TIMELINES: 'securitySolution.security.timelineFlyoutHeader.saveTimelineTour',
-  TIMELINE: 'securitySolution.timeline.newFeaturesTour.v8.12',
-  FLYOUT: 'securitySolution.documentDetails.newFeaturesTour.v8.14',
   KNOWLEDGE_BASE: 'elasticAssistant.knowledgeBase.newFeaturesTour.v8.16',
 };
 

x-pack/plugins/security_solution/common/constants.ts

@@ -424,7 +424,6 @@ export const RULES_TABLE_MAX_PAGE_SIZE = 100;
 export const NEW_FEATURES_TOUR_STORAGE_KEYS = {
   RULE_MANAGEMENT_PAGE: 'securitySolution.rulesManagementPage.newFeaturesTour.v8.13',
   TIMELINES: 'securitySolution.security.timelineFlyoutHeader.saveTimelineTour',
-  FLYOUT: 'securitySolution.documentDetails.newFeaturesTour.v8.14',
 };
 
 export const RULE_DETAILS_EXECUTION_LOG_TABLE_SHOW_METRIC_COLUMNS_STORAGE_KEY =

x-pack/plugins/security_solution/public/flyout/document_details/left/index.tsx

@@ -22,7 +22,6 @@ import { getField } from '../shared/utils';
 import { EventKind } from '../shared/constants/event_kinds';
 import { useDocumentDetailsContext } from '../shared/context';
 import type { DocumentDetailsProps } from '../shared/types';
-import { LeftPanelTour } from './components/tour';
 
 export type LeftPanelPaths = 'visualize' | 'insights' | 'investigation' | 'response' | 'notes';
 export const LeftPanelVisualizeTab: LeftPanelPaths = 'visualize';
@@ -85,7 +84,6 @@ export const LeftPanel: FC<Partial<DocumentDetailsProps>> = memo(({ path }) => {
 
   return (
     <>
-      <LeftPanelTour />
       <PanelHeader
         selectedTabId={selectedTabId}
         setSelectedTabId={setSelectedTabId}

x-pack/plugins/security_solution/public/flyout/document_details/left/tabs/insights_tab.tsx

@@ -14,10 +14,8 @@ import { useExpandableFlyoutApi, useExpandableFlyoutState } from '@kbn/expandabl
 import { useKibana } from '../../../../common/lib/kibana';
 import {
   INSIGHTS_TAB_BUTTON_GROUP_TEST_ID,
-  INSIGHTS_TAB_ENTITIES_BUTTON_LABEL_TEST_ID,
   INSIGHTS_TAB_ENTITIES_BUTTON_TEST_ID,
   INSIGHTS_TAB_THREAT_INTELLIGENCE_BUTTON_TEST_ID,
-  INSIGHTS_TAB_PREVALENCE_BUTTON_LABEL_TEST_ID,
   INSIGHTS_TAB_PREVALENCE_BUTTON_TEST_ID,
   INSIGHTS_TAB_CORRELATIONS_BUTTON_TEST_ID,
 } from './test_ids';
@@ -40,12 +38,10 @@ const insightsButtons: EuiButtonGroupOptionProps[] = [
   {
     id: ENTITIES_TAB_ID,
     label: (
-      <div data-test-subj={INSIGHTS_TAB_ENTITIES_BUTTON_LABEL_TEST_ID}>
-        <FormattedMessage
-          id="xpack.securitySolution.flyout.left.insights.entitiesButtonLabel"
-          defaultMessage="Entities"
-        />
-      </div>
+      <FormattedMessage
+        id="xpack.securitySolution.flyout.left.insights.entitiesButtonLabel"
+        defaultMessage="Entities"
+      />
     ),
     'data-test-subj': INSIGHTS_TAB_ENTITIES_BUTTON_TEST_ID,
   },
@@ -62,12 +58,10 @@ const insightsButtons: EuiButtonGroupOptionProps[] = [
   {
     id: PREVALENCE_TAB_ID,
     label: (
-      <div data-test-subj={INSIGHTS_TAB_PREVALENCE_BUTTON_LABEL_TEST_ID}>
-        <FormattedMessage
-          id="xpack.securitySolution.flyout.left.insights.prevalenceButtonLabel"
-          defaultMessage="Prevalence"
-        />
-      </div>
+      <FormattedMessage
+        id="xpack.securitySolution.flyout.left.insights.prevalenceButtonLabel"
+        defaultMessage="Prevalence"
+      />
     ),
     'data-test-subj': INSIGHTS_TAB_PREVALENCE_BUTTON_TEST_ID,
   },

x-pack/plugins/security_solution/public/flyout/document_details/left/tabs/test_ids.ts

@@ -17,12 +17,8 @@ const INSIGHTS_TAB_TEST_ID = `${PREFIX}InsightsTab` as const;
 export const INSIGHTS_TAB_BUTTON_GROUP_TEST_ID = `${INSIGHTS_TAB_TEST_ID}ButtonGroup` as const;
 export const INSIGHTS_TAB_ENTITIES_BUTTON_TEST_ID =
   `${INSIGHTS_TAB_TEST_ID}EntitiesButton` as const;
-export const INSIGHTS_TAB_ENTITIES_BUTTON_LABEL_TEST_ID =
-  `${INSIGHTS_TAB_TEST_ID}Entities` as const;
 export const INSIGHTS_TAB_THREAT_INTELLIGENCE_BUTTON_TEST_ID =
   `${INSIGHTS_TAB_TEST_ID}ThreatIntelligenceButton` as const;
-export const INSIGHTS_TAB_PREVALENCE_BUTTON_LABEL_TEST_ID =
-  `${INSIGHTS_TAB_TEST_ID}Prevalence` as const;
 export const INSIGHTS_TAB_PREVALENCE_BUTTON_TEST_ID =
   `${INSIGHTS_TAB_TEST_ID}PrevalenceButton` as const;
 export const INSIGHTS_TAB_CORRELATIONS_BUTTON_TEST_ID =