[DataDiscovery] Add deprecation banners to Advanced settings configuration we aim to deprecate in 9.0 #179899
Closed
3 tasks done
Assignees
Labels
chore
impact:low
Addressing this issue will have a low level of impact on the quality/strength of our product.
loe:small
Small Level of Effort
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Comments
kertal
added
chore
loe:small
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
|
When this deprecation occurs, we'd want to update this page too: https://www.elastic.co/guide/en/kibana/current/advanced-options.html Fixed in #186309 |
3 tasks
jughosta
added a commit
that referenced
this issue
Dec 3, 2024
- Closes #167582 ## Summary This PR removes the code related to the legacy doc table and 2 Advanced Settings: `doc_table:legacy` and `truncate:maxHeight`. The legacy table in Discover was replaced by the new data grid in v8.3. The `doc_table:legacy` Advanced Setting was added to let users switch back to the legacy table if necessary. The removal of the setting and the legacy table entirely would allow us to reduce bundle size, maintenance burden, and code complexity. Also the legacy table does not support many new features which were added to the grid only (e.g. comparing selected documents, context-aware UI based on current solution project, column resizing, bulk row selection, copy actions, new doc viewer flyout, and more). Since v8.15 `doc_table:legacy` is marked as deprecated on Advanced Settings page via #179899 Since v8.16 `truncate:maxHeight` is marked as deprecated too via #183736 The removal of these 2 settings and the associated code is planned for v9. ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this issue
Dec 5, 2024
- Closes elastic#167582 ## Summary This PR removes the code related to the legacy doc table and 2 Advanced Settings: `doc_table:legacy` and `truncate:maxHeight`. The legacy table in Discover was replaced by the new data grid in v8.3. The `doc_table:legacy` Advanced Setting was added to let users switch back to the legacy table if necessary. The removal of the setting and the legacy table entirely would allow us to reduce bundle size, maintenance burden, and code complexity. Also the legacy table does not support many new features which were added to the grid only (e.g. comparing selected documents, context-aware UI based on current solution project, column resizing, bulk row selection, copy actions, new doc viewer flyout, and more). Since v8.15 `doc_table:legacy` is marked as deprecated on Advanced Settings page via elastic#179899 Since v8.16 `truncate:maxHeight` is marked as deprecated too via elastic#183736 The removal of these 2 settings and the associated code is planned for v9. ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 9, 2024
- Closes elastic#167582 ## Summary This PR removes the code related to the legacy doc table and 2 Advanced Settings: `doc_table:legacy` and `truncate:maxHeight`. The legacy table in Discover was replaced by the new data grid in v8.3. The `doc_table:legacy` Advanced Setting was added to let users switch back to the legacy table if necessary. The removal of the setting and the legacy table entirely would allow us to reduce bundle size, maintenance burden, and code complexity. Also the legacy table does not support many new features which were added to the grid only (e.g. comparing selected documents, context-aware UI based on current solution project, column resizing, bulk row selection, copy actions, new doc viewer flyout, and more). Since v8.15 `doc_table:legacy` is marked as deprecated on Advanced Settings page via elastic#179899 Since v8.16 `truncate:maxHeight` is marked as deprecated too via elastic#183736 The removal of these 2 settings and the associated code is planned for v9. ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Dec 12, 2024
- Closes elastic#167582 ## Summary This PR removes the code related to the legacy doc table and 2 Advanced Settings: `doc_table:legacy` and `truncate:maxHeight`. The legacy table in Discover was replaced by the new data grid in v8.3. The `doc_table:legacy` Advanced Setting was added to let users switch back to the legacy table if necessary. The removal of the setting and the legacy table entirely would allow us to reduce bundle size, maintenance burden, and code complexity. Also the legacy table does not support many new features which were added to the grid only (e.g. comparing selected documents, context-aware UI based on current solution project, column resizing, bulk row selection, copy actions, new doc viewer flyout, and more). Since v8.15 `doc_table:legacy` is marked as deprecated on Advanced Settings page via elastic#179899 Since v8.16 `truncate:maxHeight` is marked as deprecated too via elastic#183736 The removal of these 2 settings and the associated code is planned for v9. ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For Advanced settings we aim to deprecate in 9.0 (or earlier) we should add deprecation banners like for
search:includeFrozenThis currently are
The text was updated successfully, but these errors were encountered: