Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Remove legacy/classic table #167582

Closed
davismcphee opened this issue Sep 28, 2023 · 5 comments · Fixed by #201254
Closed

[Discover] Remove legacy/classic table #167582

davismcphee opened this issue Sep 28, 2023 · 5 comments · Fixed by #201254
Assignees
@jughosta
Labels
Breaking Change Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture

Comments

@davismcphee
Copy link
Contributor

davismcphee commented Sep 28, 2023 •
edited by kertal
Loading

In version 9.0, we are removing the legacy/classic table in Discover.

Image

The following needs to be done:

  • Remove the doc_table:legacy setting from the Discover app and all associated code related to the legacy table view.
  • Remove the truncate:maxHeight setting since it is only relevant to the legacy table.
  • Remove all the code + tests depending on these settings
@davismcphee davismcphee added Meta Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee added loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Sep 28, 2023
@kertal
Copy link
Member

kertal commented Sep 29, 2023

The legacy table doesn't use virtualization when rendering table rows, instead rendering them all at once, which has the side effect of supporting local filtering through built in find functionality in browsers. Unified Data Table is based on EuiDataGrid, which uses virtualization and prevents relying on browser find functionality for local filtering. In order to support this we'd need to implement in-app filtering in Unified Data Table.

About the legacy in-app filtering... it depends, because it renders the list in chunks when scrolling. So when you scroll down you can use the browser to find in all results displayed. Apart from that detail, yes, we should implement searching in the results #70799

@davismcphee
Copy link
Contributor Author

@kertal thanks for the clarification! Updated the bullet to include that info.

@kertal kertal added epic and removed Meta labels Nov 30, 2023
@jughosta
Copy link
Contributor

jughosta commented Aug 9, 2024

And we could remove truncate:maxHeight

@kertal kertal added technical debt Improvement of the software architecture and operational architecture and removed epic labels Sep 25, 2024
@kertal kertal changed the title [Discover] Remove legacy table [Discover] Remove legacy/classic table Oct 16, 2024
@kertal
Copy link
Member

kertal commented Oct 16, 2024

I rewrote this issue to describe the task that needs to be done, we just need to decide when it's the right time, to omit backports of other issues that follow this merge, won't run into too much conflicts

@kertal kertal added Breaking Change impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Oct 16, 2024
@jughosta jughosta mentioned this issue Nov 21, 2024
Merged
3 tasks
hop-dev pushed a commit to hop-dev/kibana that referenced this issue Dec 5, 2024
@jughosta @kibanamachine
@elasticmachine @hop-dev
[Discover] Remove the legacy table (elastic#201254)
04be27e 
- Closes elastic#167582

## Summary

This PR removes the code related to the legacy doc table and 2 Advanced
Settings: `doc_table:legacy` and `truncate:maxHeight`.

The legacy table in Discover was replaced by the new data grid in v8.3.
The `doc_table:legacy` Advanced Setting was added to let users switch
back to the legacy table if necessary. The removal of the setting and
the legacy table entirely would allow us to reduce bundle size,
maintenance burden, and code complexity.

Also the legacy table does not support many new features which were
added to the grid only (e.g. comparing selected documents, context-aware
UI based on current solution project, column resizing, bulk row
selection, copy actions, new doc viewer flyout, and more).

Since v8.15 `doc_table:legacy` is marked as deprecated on Advanced
Settings page via elastic#179899

Since v8.16 `truncate:maxHeight` is marked as deprecated too via
elastic#183736

The removal of these 2 settings and the associated code is planned for
v9.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 9, 2024
@jughosta @kibanamachine
@elasticmachine @CAWilson94
[Discover] Remove the legacy table (elastic#201254)
d5a4a9b 
- Closes elastic#167582

## Summary

This PR removes the code related to the legacy doc table and 2 Advanced
Settings: `doc_table:legacy` and `truncate:maxHeight`.

The legacy table in Discover was replaced by the new data grid in v8.3.
The `doc_table:legacy` Advanced Setting was added to let users switch
back to the legacy table if necessary. The removal of the setting and
the legacy table entirely would allow us to reduce bundle size,
maintenance burden, and code complexity.

Also the legacy table does not support many new features which were
added to the grid only (e.g. comparing selected documents, context-aware
UI based on current solution project, column resizing, bulk row
selection, copy actions, new doc viewer flyout, and more).

Since v8.15 `doc_table:legacy` is marked as deprecated on Advanced
Settings page via elastic#179899

Since v8.16 `truncate:maxHeight` is marked as deprecated too via
elastic#183736

The removal of these 2 settings and the associated code is planned for
v9.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@jughosta @kibanamachine
@elasticmachine @CAWilson94
[Discover] Remove the legacy table (elastic#201254)
6868a63 
- Closes elastic#167582

## Summary

This PR removes the code related to the legacy doc table and 2 Advanced
Settings: `doc_table:legacy` and `truncate:maxHeight`.

The legacy table in Discover was replaced by the new data grid in v8.3.
The `doc_table:legacy` Advanced Setting was added to let users switch
back to the legacy table if necessary. The removal of the setting and
the legacy table entirely would allow us to reduce bundle size,
maintenance burden, and code complexity.

Also the legacy table does not support many new features which were
added to the grid only (e.g. comparing selected documents, context-aware
UI based on current solution project, column resizing, bulk row
selection, copy actions, new doc viewer flyout, and more).

Since v8.15 `doc_table:legacy` is marked as deprecated on Advanced
Settings page via elastic#179899

Since v8.16 `truncate:maxHeight` is marked as deprecated too via
elastic#183736

The removal of these 2 settings and the associated code is planned for
v9.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
Breaking Change Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Remove the legacy table jughosta/kibana
4 participants
@kertal @jughosta @elasticmachine @davismcphee