Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly Detection: Single Metric Viewer embeddable - 8.14 enhancements #176651

Closed
13 tasks done
alvarezmelissa87 opened this issue Feb 10, 2024 · 3 comments
Closed
13 tasks done

[ML] Anomaly Detection: Single Metric Viewer embeddable - 8.14 enhancements #176651

alvarezmelissa87 opened this issue Feb 10, 2024 · 3 comments
Assignees
@alvarezmelissa87
Labels
Feature:Anomaly Detection ML anomaly detection :ml v8.14.0

Comments

@alvarezmelissa87
Copy link
Contributor

alvarezmelissa87 commented Feb 10, 2024 •
edited by peteharverson
Loading

Describe the feature:

Follow up to adding the single metric viewer as an embeddable to be used in Dashboards.

Tests:

Enhancements:

Maintenance tasks:
@alvarezmelissa87 alvarezmelissa87 self-assigned this Feb 10, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 mentioned this issue Feb 10, 2024
Closed
22 tasks
@peteharverson peteharverson changed the title [ML] Anomaly Detection: Enhancements for Single Metric Viewer in Dashboards [ML] Anomaly Detection: Enhancements for Single Metric Viewer embeddable Feb 12, 2024
@walterra walterra mentioned this issue Feb 13, 2024
Merged
2 tasks
walterra added a commit that referenced this issue Mar 5, 2024
@walterra
[ML] Anomaly Detection: Fix anomaly marker click in Single Metric Vie…
dda8c8f 
…wer embeddable (#176788)

## Summary

Part of #176651 and #153476. Follow up to #175556.

Fixes the click on anomaly markers in the Single Metric Viewer
embeddable. This required refactoring some dependencies to be properly
passed in via React contexts instead of the legacy dependency cache.

[smv-embeddable-click-0001.webm](https://github.com/elastic/kibana/assets/230104/6d0bb0e5-bfde-4429-8876-bdc94ce646c8)

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
This was referenced Mar 12, 2024
Merged
Merged
alvarezmelissa87 added a commit that referenced this issue Mar 18, 2024
@alvarezmelissa87 @kibanamachine
[ML] Single metric viewer in dashboards: adds functional test (#178768)
a6174d4 
## Summary

Related meta issue: #176651

This PR adds functional tests for SMV in dashboards.
Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5485


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

Co-authored-by: Kibana Machine <[email protected]>
walterra pushed a commit that referenced this issue Mar 20, 2024
@alvarezmelissa87
[ML] Removes duplicated service code used in Single Metric Viewer (#1…
8c85463 
…78566)

## Summary

Related meta issue: #176651

This PR removes duplicates created in the initial PR for adding SMV as
an embeddable in dashboards:

- `ml/public/application/services/forecast_service_provider.ts` replaces
`ml/public/application/services/forecast_service.js`

- `ml/public/application/timeseriesexplorer/timeseriesexplorer_utils/time_series_search_service.ts`
replaces `ml/public/application/timeseriesexplorer/timeseries_search_service.ts`

- removes `ml/public/application/timeseriesexplorer/timeseriesexplorer_utils/timeseriesexplorer_utils.js`


### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
saikatsarkar056 pushed a commit to saikatsarkar056/kibana that referenced this issue Mar 21, 2024
@alvarezmelissa87 @kibanamachine @saikatsarkar056
[ML] Single metric viewer in dashboards: adds functional test (elasti…
e44b40b 
…c#178768)

## Summary

Related meta issue: elastic#176651

This PR adds functional tests for SMV in dashboards.
Flaky test runner:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/5485


### Checklist

Delete any items that are not applicable to this PR.

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

Co-authored-by: Kibana Machine <[email protected]>
@alvarezmelissa87 alvarezmelissa87 mentioned this issue Mar 25, 2024
Merged
9 tasks
alvarezmelissa87 added a commit that referenced this issue Apr 4, 2024
@alvarezmelissa87 @kibanamachine
[ML] Single Metric Viewer embeddable: add open and edit panel actions (…
339e24f 
…#179364)

## Summary

Part of #176651

This PR:

- adds the 'Open in Single Metric Viewer' and 'Edit' panel actions to
the Single Metric Viewer embeddable for dashboards.
- detector index fix moved to separate
[PR](#179761)




### Screen shots ###

<img width="672" alt="image"
src="https://github.com/elastic/kibana/assets/6446462/4955143f-ace0-406f-839b-8f2469d3ea2f">




### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

---------

Co-authored-by: Kibana Machine <[email protected]>
@peteharverson peteharverson changed the title [ML] Anomaly Detection: Enhancements for Single Metric Viewer embeddable [ML] Anomaly Detection: Enhancements for Single Metric Viewer embeddable - 8.14 Apr 22, 2024
@peteharverson peteharverson changed the title [ML] Anomaly Detection: Enhancements for Single Metric Viewer embeddable - 8.14 [ML] Anomaly Detection: Single Metric Viewer embeddable - 8.14 enhancements Apr 22, 2024
@peteharverson peteharverson mentioned this issue Apr 22, 2024
Closed
4 tasks
@peteharverson
Copy link
Contributor

Created #181272 for follow-up work.

@peteharverson
Copy link
Contributor

Closing as all items planned for 8.14 have been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Anomaly Detection ML anomaly detection :ml v8.14.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alvarezmelissa87 @peteharverson @elasticmachine