[ML] Remove dependency cache #153476
Assignees
Labels
Meta
:ml
refactoring
technical debt
Improvement of the software architecture and operational architecture
v8.16.0
Comments
jgowdyelastic
added
Meta
:ml
refactoring
technical debt
|
Pinging @elastic/ml-ui (:ml) |
2 tasks
walterra
added a commit
that referenced
this issue
Mar 5, 2024
…wer embeddable (#176788) ## Summary Part of #176651 and #153476. Follow up to #175556. Fixes the click on anomaly markers in the Single Metric Viewer embeddable. This required refactoring some dependencies to be properly passed in via React contexts instead of the legacy dependency cache. [smv-embeddable-click-0001.webm](https://github.com/elastic/kibana/assets/230104/6d0bb0e5-bfde-4429-8876-bdc94ce646c8) ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ML's dependancy cache is a system which provides access to external services as a static import.
It is used in 31 files.
Remove dependency cache items
The following are removed as of #176788
Util like files
These will need to be wrapped in provider function or converted to a service class to allow the dependencies to be passed in.
x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_exploration/components/outlier_exploration/use_outlier_data.tsx-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/services/analytics_service/stop_analytics.tsx-pack/plugins/ml/public/application/explorer/explorer_utils.ts(DA)x-pack/plugins/ml/public/application/jobs/components/custom_url_editor/utils.jsx-pack/plugins/ml/public/application/jobs/jobs_list/components/edit_job_flyout/edit_utils.jsx-pack/plugins/ml/public/application/jobs/jobs_list/components/utils.jsx-pack/plugins/ml/public/application/jobs/new_job/job_from_lens/route_resolver.tsx-pack/plugins/ml/public/application/jobs/new_job/job_from_map/quick_create_job.tsx-pack/plugins/ml/public/application/jobs/new_job/job_from_map/route_resolver.tsx-pack/plugins/ml/public/application/jobs/new_job/recognize/resolvers.tsx-pack/plugins/ml/public/application/services/http_service.tsx-pack/plugins/ml/public/application/services/ml_api_service/index.tsx-pack/plugins/ml/public/application/services/toast_notification_service/toast_notification_service.tsx-pack/plugins/ml/public/application/settings/filter_lists/edit/utils.jsx-pack/plugins/ml/public/application/util/index_utils.tsx-pack/plugins/ml/public/application/util/recently_accessed.tsx-pack/plugins/ml/public/application/util/time_buckets.jsReact classes
Convert to functional component to allow use of hooks or pass in dependencies as props.
An alternative is to use
contextTypeto access kibana context from the class based component (see https://legacy.reactjs.org/docs/context.html#classcontexttype).For javascript files, converting to a functional component would also involve rewriting in TypeScript.
x-pack/plugins/ml/public/application/components/annotations/annotation_flyout/index.tsxx-pack/plugins/ml/public/application/components/validate_job/validate_job_view.jsx-pack/plugins/ml/public/application/settings/calendars/edit/new_calendar.jsx-pack/plugins/ml/public/application/settings/calendars/list/calendars_list.jsx-pack/plugins/ml/public/application/settings/calendars/list/delete_calendars.jsx-pack/plugins/ml/public/application/settings/filter_lists/components/delete_filter_list_modal/delete_filter_lists.jsx-pack/plugins/ml/public/application/settings/filter_lists/edit/edit_filter_list.jsx-pack/plugins/ml/public/application/settings/filter_lists/list/filter_lists.jsTypeScript functional components
Replace with context versions supplied by
useMlKibanax-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_creation/components/configuration_step/configuration_step_form.tsxx-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_exploration/components/expandable_section/expandable_section_results.tsxx-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_exploration/components/exploration_results_table/exploration_results_table.tsxx-pack/plugins/ml/public/application/license/expired_warning.tsxTest files
x-pack/plugins/ml/public/application/components/annotations/annotation_flyout/index.test.tsxx-pack/plugins/ml/public/application/components/validate_job/validate_job_view.test.jsx-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/action_delete/delete_action_name.test.tsxx-pack/plugins/ml/public/application/settings/calendars/edit/new_calendar.test.jsx-pack/plugins/ml/public/application/settings/calendars/list/calendars_list.test.jsx-pack/plugins/ml/public/application/settings/filter_lists/edit/edit_filter_list.test.jsx-pack/plugins/ml/public/application/settings/filter_lists/list/filter_lists.test.jsx-pack/plugins/ml/public/application/util/chart_utils.test.jsML API service
We have a lot of use of the statically imported api service, normally imported as
mlfromml/public/application/services/ml_api_service/index.tsThis uses
httpfrom the dependency cache. In order to remove this dependancy, the api service will also need to change. Related issueThe text was updated successfully, but these errors were encountered: