Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming [Saved Search] to [Discover Session] #174144

Closed
stratoula opened this issue Jan 3, 2024 · 14 comments · Fixed by #202217
Closed

Renaming [Saved Search] to [Discover Session] #174144

stratoula opened this issue Jan 3, 2024 · 14 comments · Fixed by #202217
Assignees
Labels
Feature:Discover Discover Application Feature:Unified search Unified search related tasks impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@stratoula
Copy link
Contributor

stratoula commented Jan 3, 2024

Describe the feature:

Currently, the term Saved Searches is used to represent the Discover SO, which allows users to save their Discover configuration, share it, or use it in dashboards and visualizations. Over time, this has expanded to include much more than just “saved searches,” making the term outdated. With upcoming enhancements (#167887 and #167635), it will store even more details about the user’s Discover configuration. In the future, Discover Session will store new features, and we expect users to save Discover Session elements to e.g. Cases and Dashboards.

Proposed change: Rename “Saved Searches” to “Discover Session” to better reflect its role as a saved representation of the Discover app state.

Why This Is Important

•	Improves clarity and aligns terminology with the expanded functionality of the Discover app.
•	Helps users better understand the role of saved objects in Discover.

Implementation Details

•	Update all UI references from “Saved Searches” to “Discover Session.”
•	Retain the existing SO type for technical continuity (no changes to storage).
•	Communicate the change to users via release notes and documentation
@stratoula stratoula changed the title [Saves s] [Saved searches][Saved queries] Renaming to avoid confusion Jan 3, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 3, 2024
@stratoula stratoula added Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Feature:Unified search Unified search related tasks and removed needs-team Issues missing a team label labels Jan 3, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@stratoula
Copy link
Contributor Author

stratoula commented Jan 3, 2024

cc @amyjtechwriter @ninoslavmiskovic @timductive

@thomasneirynck
Copy link
Contributor

@stratoula is this just a rename in the UX?

I would caution against renaming. It breaks discontinuity with marginal benefit. E.g. the rename index-pattern -> data-view added more confusion than it resolved. Until we can rename SO-types, we then also have to maintain a new mental model which maps the visible-naming to the internal-naming.

Good docs and guides within the product should already go a long way of making these distinct concepts more understandable.

@stratoula
Copy link
Contributor Author

stratoula commented Jan 3, 2024

@thomasneirynck yes. I understand the point you are raising but I am afraid that the confusion will be much bigger if we keep it as it is. We really need to take action imho. Unless the renaming is something we are expecting to be possible soonish. Is it? We can always mask the SO type on the saved objects management page and display the new name on the dropdown and keep the old name only inside the SO.

@kertal kertal added the loe:needs-research This issue requires some research before it can be worked on or estimated label Jan 15, 2024
@teresaalvarezsoler
Copy link

I just removed the Visualizations team from this issue since this seems to be an ESQL/Discover team issue.

@teresaalvarezsoler teresaalvarezsoler removed the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 19, 2024
@ninoslavmiskovic ninoslavmiskovic changed the title [Saved searches][Saved queries] Renaming to avoid confusion Renaming [Saved Search] to [Discover Session] Nov 21, 2024
@jughosta
Copy link
Contributor

jughosta commented Dec 4, 2024

Communicate the change to users via ... in-app messaging.

Should we add a notice to UI? In what form?

cc @ninoslavmiskovic

@ninoslavmiskovic
Copy link
Contributor

We could add a small info badge perhaps ? @jughosta

@jughosta
Copy link
Contributor

jughosta commented Dec 4, 2024

Okay, would be great to have some visual guidelines then cc @l-suarez @kertal

@davismcphee
Copy link
Contributor

Adding it to the release notes and documentation would definitely be a good first step. Some sort of in-app messaging could also be good, although I agree with @jughosta that we should do a quick design pass on this before adding anything. Also if we intend to make this a 9.0 change (tbh I can't remember what we agreed here), then possibly a warning in the Upgrade Assistant could be helpful. This may be a misuse of the UA though, so I'd check with Core first.

@ninoslavmiskovic
Copy link
Contributor

I was just thinking something simple. We can also just add it to the release notes and not in-app. I don't want to out this on risk.

@kertal
Copy link
Member

kertal commented Dec 5, 2024

+1 for release notes + documentation, and since we will backport this (right @ninoslavmiskovic) I don't think Upgrade Assistant needs to be involved. in my point of view, no in app message is required

@ninoslavmiskovic
Copy link
Contributor

Changed the description to only have release notes and documentation - @jughosta

@jughosta
Copy link
Contributor

jughosta commented Dec 5, 2024

Alright, thanks!

jughosta added a commit to jughosta/kibana that referenced this issue Dec 18, 2024
- Closes elastic#174144

## Summary

This PR renames Saved Search into Discover Session in UI.

- [x] Discover
- [x] Saved Objects page and modal
- [x] Docs
- [x] Other occurrences

<img width="810" alt="Screenshot 2024-12-16 at 15 20 10"
src="https://github.com/user-attachments/assets/e39083da-f496-4ed5-bbdc-8e184897fc41"
/>
<img width="1220" alt="Screenshot 2024-12-11 at 14 40 15"
src="https://github.com/user-attachments/assets/a6dc3e29-e1a5-4304-8148-0108231cc9de"
/>
<img width="1476" alt="Screenshot 2024-12-16 at 14 57 39"
src="https://github.com/user-attachments/assets/4b34c70e-e21a-4d82-85f2-f5a3cb7a3826"
/>

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: wajihaparvez <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Co-authored-by: Julia Bardi <[email protected]>
(cherry picked from commit 40c9055)

# Conflicts:
#	x-pack/platform/plugins/private/translations/translations/zh-CN.json
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Dec 19, 2024
- Closes elastic#174144

## Summary

This PR renames Saved Search into Discover Session in UI.

- [x] Discover
- [x] Saved Objects page and modal
- [x] Docs
- [x] Other occurrences 

<img width="810" alt="Screenshot 2024-12-16 at 15 20 10"
src="https://github.com/user-attachments/assets/e39083da-f496-4ed5-bbdc-8e184897fc41"
/>
<img width="1220" alt="Screenshot 2024-12-11 at 14 40 15"
src="https://github.com/user-attachments/assets/a6dc3e29-e1a5-4304-8148-0108231cc9de"
/>
<img width="1476" alt="Screenshot 2024-12-16 at 14 57 39"
src="https://github.com/user-attachments/assets/4b34c70e-e21a-4d82-85f2-f5a3cb7a3826"
/>


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: wajihaparvez <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Co-authored-by: Julia Bardi <[email protected]>
benakansara pushed a commit to benakansara/kibana that referenced this issue Jan 2, 2025
- Closes elastic#174144

## Summary

This PR renames Saved Search into Discover Session in UI.

- [x] Discover
- [x] Saved Objects page and modal
- [x] Docs
- [x] Other occurrences 

<img width="810" alt="Screenshot 2024-12-16 at 15 20 10"
src="https://github.com/user-attachments/assets/e39083da-f496-4ed5-bbdc-8e184897fc41"
/>
<img width="1220" alt="Screenshot 2024-12-11 at 14 40 15"
src="https://github.com/user-attachments/assets/a6dc3e29-e1a5-4304-8148-0108231cc9de"
/>
<img width="1476" alt="Screenshot 2024-12-16 at 14 57 39"
src="https://github.com/user-attachments/assets/4b34c70e-e21a-4d82-85f2-f5a3cb7a3826"
/>


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: wajihaparvez <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Co-authored-by: Julia Bardi <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
- Closes elastic#174144

## Summary

This PR renames Saved Search into Discover Session in UI.

- [x] Discover
- [x] Saved Objects page and modal
- [x] Docs
- [x] Other occurrences 

<img width="810" alt="Screenshot 2024-12-16 at 15 20 10"
src="https://github.com/user-attachments/assets/e39083da-f496-4ed5-bbdc-8e184897fc41"
/>
<img width="1220" alt="Screenshot 2024-12-11 at 14 40 15"
src="https://github.com/user-attachments/assets/a6dc3e29-e1a5-4304-8148-0108231cc9de"
/>
<img width="1476" alt="Screenshot 2024-12-16 at 14 57 39"
src="https://github.com/user-attachments/assets/4b34c70e-e21a-4d82-85f2-f5a3cb7a3826"
/>


### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: wajihaparvez <[email protected]>
Co-authored-by: Davis McPhee <[email protected]>
Co-authored-by: Julia Bardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application Feature:Unified search Unified search related tasks impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants