Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Allow inline editing in Lens charts on the dataview mode #167635

Open
stratoula opened this issue Sep 29, 2023 · 5 comments
Open

[Discover] Allow inline editing in Lens charts on the dataview mode #167635

stratoula opened this issue Sep 29, 2023 · 5 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Sep 29, 2023

Describe the feature:
Discover supports 2 modes:

  • DataView mode. It is the default one where the users can select their datasource from the dataview picker and apply filtering with KQL or the filter builder
  • ES|QL mode: Users can switch to this from the dataview picker. This mode has more capabilities from the default one as the user can use the query for many things (aggs, formulas, lookups, new fields etc). This mode also allows the users to edit the suggested Lens charts immediately from Discover without navigating to Lens

The same experience can also be applied on the dataview mode. Instead of redirecting users to Lens, we can use the inline editing flyout to give the same capabilities as in the ESQL mode.

The advantage is that the users will be able to accomplish many things from Discover such as adding reference lines and annotations and immediately save to the dashboard.

image

Bonus idea

Right now if I want to visualize a field I have to click the Visualize button and go to Lens. We could instead update the Discover histogram with the suggestion from Lens. With inline editing enabled the users can make the changes they want and immediately add to dashboard. As a result the users never leave the Discover app, only for saving to a dashboard.

image
@stratoula stratoula added Feature:Discover Discover Application enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee
Copy link
Contributor

I love this, and the bonus idea too! This would truly be DiscoLens 🪩

@stratoula do you have any thoughts on what we might be able to do with saved searches that were previously saved with breakdown fields, since I'm assuming the ideas is we'd replace the breakdown functionality with this?

@stratoula
Copy link
Contributor Author

This is a good question. I remember that @timductive had suggested to leave the breakdown as it is. (Which means have it above the chart and also in the flyout - they should be synced of course).
But in general I thing we need to discuss with more details what saved search is (now that we have ESQL with charts or in the future where you will be able to create whatever chart you want from Discover). Worth a meeting I think!

@timductive timductive added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Oct 4, 2023
@davismcphee davismcphee added the loe:medium Medium Level of Effort label Oct 26, 2023
@davismcphee
Copy link
Contributor

Leaving a note here to say that we should resolve #167887 and make sure visualizations save with saved searches before we do this enhancement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants