Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Use the embeddable only for rendering #167631

Closed
stratoula opened this issue Sep 29, 2023 · 2 comments · Fixed by #171081
Closed

[Lens] Use the embeddable only for rendering #167631

stratoula opened this issue Sep 29, 2023 · 2 comments · Fixed by #171081
Assignees
@ppisljar
Labels
enhancement New value added to drive a business result epic Feature:ES|QL ES|QL related features in Kibana Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. performance Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

Describe the feature:

There are cases that the users want to use their own data and use Lens only for rendering. Except from that there are cases where the Lens chart is embedded in an application which already has retrieved the data for other reasons (e.g. depict a table). It is not performant to run the same query twice (one for the app and one for the embeddable).

The Lens embeddable should be able to accept the table as input, not run the search query, and render the charts with the given configuration.

In Discover for example every time we depict a Lens suggestion we run the ES|QL query again (once for Discover and once for Lens). As we already have the table in Discover it could be passed into Lens embeddable and avoid re-running the query once again.
@stratoula stratoula added performance enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Feature:ES|QL ES|QL related features in Kibana labels Sep 29, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@stratoula stratoula mentioned this issue Sep 29, 2023
Open
@stratoula stratoula added impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Oct 11, 2023
@stratoula
Copy link
Contributor Author

For ES|QL if we could cache the results either in ES or kibana, this would solve the problem mentioned above. Search API is already caching the results, _query api not yet.

(The necessity still exists for consumers who want to use Lens only for rendering).

@stratoula stratoula mentioned this issue Dec 6, 2023
Closed
@stratoula stratoula mentioned this issue Jan 4, 2024
Merged
stratoula added a commit that referenced this issue Jan 26, 2024
@ppisljar @kibanamachine
@stratoula @jughosta
[Lens] value based ES|QL data source (#171081)
0e3513a 
## Summary

Closes #167631

Enhances the ES|QL lens datasource to receive a DataTable as an input
(so no datafetching happens in lens)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Julia Rechkunova <[email protected]>
CoenWarmer pushed a commit to CoenWarmer/kibana that referenced this issue Feb 15, 2024
@ppisljar @kibanamachine
@stratoula @jughosta @CoenWarmer
[Lens] value based ES|QL data source (elastic#171081)
3ec51cb 
## Summary

Closes elastic#167631

Enhances the ES|QL lens datasource to receive a DataTable as an input
(so no datafetching happens in lens)

---------

Co-authored-by: kibanamachine <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Stratoula Kalafateli <[email protected]>
Co-authored-by: Julia Rechkunova <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppisljar ppisljar

Labels
enhancement New value added to drive a business result epic Feature:ES|QL ES|QL related features in Kibana Feature:Lens impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. performance Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] value based ES|QL data source ppisljar/kibana
4 participants
@timductive @ppisljar @elasticmachine @stratoula