Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Heatmap color bands not synchronized with the legend always #172665

Closed
stratoula opened this issue Dec 6, 2023 · 8 comments
Closed

[ES|QL] Heatmap color bands not synchronized with the legend always #172665

stratoula opened this issue Dec 6, 2023 · 8 comments
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Dec 6, 2023

Kibana version:
8.11 +

Describe the bug:
I can also reproduce it with logstash-* (I have a lot of data so possibly this is the key here)

esql_bug

Steps to reproduce:

  1. Install demo logstash dataset
  2. Go to Discover esql mode
  3. Write a query which produces a heatmap from logstash-* | limit 10 | stats var0 = avg(bytes) by geo.dest
  4. Open the edit flyout
  5. Toggle the coloring from percent to values and vice versa
  6. Check that the legend values and that the flyout do not have the same values

Expected behavior:
They should be synced.

@stratoula stratoula added the bug Fixes for quality problems that affect the customer experience label Dec 6, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 6, 2023
@stratoula stratoula added Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Feature:ES|QL ES|QL related features in Kibana Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 6, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 6, 2023
@stratoula stratoula changed the title [ES|QL] Heatmap color bands not synchronized with thge [ES|QL] Heatmap color bands not synchronized with thg Dec 6, 2023
@stratoula stratoula changed the title [ES|QL] Heatmap color bands not synchronized with thg [ES|QL] Heatmap color bands not synchronized with the legend always Dec 6, 2023
@dej611
Copy link
Contributor

dej611 commented Dec 6, 2023

It seems related to #172433 : can you reproduce it in #172602 ?

@stratoula
Copy link
Contributor Author

@dej611 let me try!

@stratoula
Copy link
Contributor Author

No Marco unfortunately is something else :(

@stratoula stratoula added enhancement New value added to drive a business result and removed bug Fixes for quality problems that affect the customer experience labels Dec 6, 2023
@stratoula
Copy link
Contributor Author

We know why it happens. The ES|QL queries with limit can return different results in every render. This happens when the user hasn't added a sort command. In that case by toggling the percent / values tabs the expression re- runs and different results are rendered.
With this we are going to improve the behavior in Discover side #167631 but in the dashboard it will persist.

We have addressed our concerns to ES and we think that the rows should be sorted by default. We are still in discussions. With that being said we could also improve the behavior in the Lens side with expression caching or other techniques but this is a quite big task.

@markov00
Copy link
Member

markov00 commented Dec 7, 2023

@stratoula I believe that the expression (at least the query part) should not rerun if I'm not changing the query itself or the time picker (even if is set to relative time ranges). Switching between two possible configurations shouldn't trigger a complete re-run of the query, if really necessary just the "color range" configuration part.

@stratoula
Copy link
Contributor Author

@markov00 this is exactly what I said to @dej611 :D I totally agree, it is very weird that we rerun the expression

@stratoula
Copy link
Contributor Author

I am closing this as it is going to be resolved when this lands #177548 so it is a duplicate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ES|QL ES|QL related features in Kibana Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants