Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra UI] Add options to the alerts link in the asset details flyout #167524

Closed
jennypavlova opened this issue Sep 28, 2023 · 1 comment · Fixed by #167616
Closed

[Infra UI] Add options to the alerts link in the asset details flyout #167524

jennypavlova opened this issue Sep 28, 2023 · 1 comment · Fixed by #167616
Assignees
@jennypavlova
Labels
enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@jennypavlova
Copy link
Member

jennypavlova commented Sep 28, 2023 •
edited
Loading

Now that we are using the asset details flyout in inventory (after #166965 is merged) we should extend the Alerts flyout with the options property to support more customizations using an override. This is needed for the metrics prefilling -as it worked with the previous flyout :

Image

AC:

  • When clicking on Create Rule from the inventory assets flyout the metric selection should be prefilled:

Image

  • Asset details page and hosts view flyout should remain unchanged.
@jennypavlova jennypavlova added enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Sep 28, 2023
@jennypavlova jennypavlova self-assigned this Sep 28, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

This was referenced Sep 28, 2023
Merged
Merged
jennypavlova added a commit that referenced this issue Sep 29, 2023
@jennypavlova
[Infra UI] Add options to the alerts link in the asset details flyout (…
567a6de 
…#167616)

Closes #167524
## Summary

This PR adds the possibility of overriding the alerts flyout options.
This is used to change the metric value during the alert creation when
it is changed in the menu on inventory.

## Testing
- Go to Inventory
   - Change the metric in the drop-down menu
   - The metric should be changed in the alerts flyout
- Go to hosts view flyout (alert rule should remain the same)
- Go to asset details page view (alert rule should remain the same)



https://github.com/elastic/kibana/assets/14139027/2bb31be0-04c8-4611-a8d2-b91a465a09b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jennypavlova jennypavlova

Labels
enhancement New value added to drive a business result Feature:Metrics UI Metrics UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infra UI] Add options to the alerts link in the asset details flyout jennypavlova/kibana
2 participants
@jennypavlova @elasticmachine