Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security][Spaces] Migrate all usages of EuiPage*_Deprecated #161419

Closed
Tracked by #161872
cee-chen opened this issue Jul 7, 2023 · 2 comments · Fixed by #167078
Closed
Tracked by #161872

[Security][Spaces] Migrate all usages of EuiPage*_Deprecated #161419

cee-chen opened this issue Jul 7, 2023 · 2 comments · Fixed by #167078
Assignees
@jeramysoucy
Labels
deprecation_warnings EUI Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Jul 7, 2023 •
edited by legrego
Loading

👋 Hello from your friendly neighborhood EUI team! It's been almost a year since EUI's new EuiPageTemplate came out (if you can believe it), which means we're about a month away from the old deprecated EUI page template components being permanently removed.

Your team is being pinged in this issue because you have usages of EuiPage*_Deprecated components, which you can find listed here:

How

  • Please see our new EuiPageTemplate guidelines and examples for suggestions on how to migrate over.
  • You can also see more examples of layout conversions in the original EuiPageTemplate PR:
    [Feature] EuiPage and EuiPageTemplate Updates eui#5768
  • Here's a quick conversion map of components that approximately translate to their new equivalents:
    • EuiPageTemplate_Deprecated -> EuiPageTemplate
    • EuiPageSideBar_Deprecated -> EuiPageSidebar or EuiPageTemplate.Sidebar
    • EuiPageContent_Deprecated -> EuiPageSection or EuiPageTemplate.Section
    • EuiPageContentBody_Deprecated -> Use EuiPageSection instead
    • EuiPageContentHeader_Deprecated -> Use EuiPageHeader instead
    • EuiPageContentHeaderSection_Deprecated -> Use EuiPageHeader instead

When

We'd really appreciate it if you could migrate your component usages over before or during August if possible.

If your team does not have the ability or bandwidth to perform this work by that time, please let us know. While we'd really appreciate as many teams as possible taking on this work so we're not having to touch hundreds of files by ourselves and in one go, the EUI team can potentially help you out - but we will need you to help QA that work and ensure your layouts look the same as before.

Thanks, and please feel free to reach out anytime with questions or help with migration!

CleanShot 2023-07-24 at 07 47 14@2x CleanShot 2023-07-24 at 07 47 39@2x
@cee-chen cee-chen added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! deprecation_warnings EUI labels Jul 7, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@petrklapka petrklapka mentioned this issue Jul 13, 2023
Closed
1 task
@jeramysoucy jeramysoucy mentioned this issue Sep 22, 2023
Merged
jeramysoucy added a commit that referenced this issue Sep 29, 2023
@jeramysoucy @kibanamachine
Migrates all security and spaces usage of deprecated Eui Page compone…
90faf2b 
…nts (#167078)

Closes #161419

## Summary

Replaces deprecated EuiPage*_Deprecated components with the suggested
replacement components (see
[issue](#161419)).

### Visual Difference
The only UI that is noticeably affected is the User Profile page. The
spacing and header font size are slightly different from the previous
implementation, however, it is consistent with other
`Eui/KibanaPageTemplate` pages.

Previous render:
<img width="1391" alt="Screenshot 2023-09-22 at 1 27 27 PM"
src="https://github.com/elastic/kibana/assets/103939324/58d2a86e-63b7-4c7d-bcf1-2071290d25b2">

New render:
<img width="1286" alt="Screenshot 2023-09-22 at 2 56 44 PM"
src="https://github.com/elastic/kibana/assets/103939324/0f2b3e38-8ea3-4daf-8937-03e47474658c">

### Applicable Tests

-
x-pack/plugins/security/public/account_management/user_profile/user_profile.test.tsx
-
x-pack/plugins/security/public/management/users/users_grid/users_grid_page.test.tsx
-
x-pack/plugins/spaces/public/management/edit_space/manage_space_page.test.tsx
-
x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.test.tsx
-
x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.test.tsx
(for permission denied)

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeramysoucy jeramysoucy

Labels
deprecation_warnings EUI Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrates all security and spaces usage of deprecated Eui Page components jeramysoucy/kibana
3 participants
@cee-chen @elasticmachine @jeramysoucy