Migrates all security and spaces usage of deprecated Eui Page components #167078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeramysoucy
added
Team:Security
jeramysoucy
force-pushed
the
migrate-eui-page-components
branch
from
2585389 to
fd7e63f
Compare
…-ref HEAD~1..HEAD --fix'
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
jeramysoucy
commented
Sep 25, 2023
| @@ -21,7 +21,7 @@ interface CreateRoleMappingButtonProps { | |||
| export const CreateRoleMappingButton = ({ history }: CreateRoleMappingButtonProps) => { | |||
| return ( | |||
| <EuiButton | |||
| iconType="plusInCircle" | |||
| iconType="plusInCircleFilled" | |||
There was a problem hiding this comment.
This is just to make this page consistent with our other pages. It is unrelated to the main changes of the PR.
|
Pinging @elastic/kibana-security (Team:Security) |
jeramysoucy
added
backport:skip
|
@MichaelMarcialis Could you review the updated UI layout? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161419
Summary
Replaces deprecated EuiPage*_Deprecated components with the suggested replacement components (see issue).
Visual Difference
The only UI that is noticeably affected is the User Profile page. The spacing and header font size are slightly different from the previous implementation, however, it is consistent with other
Eui/KibanaPageTemplatepages.Previous render:
New render:
Applicable Tests