-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Serverless] Adapt the new IA to the left navigation #157847
Closed
10 tasks done
Labels
Comments
semd
added
Team:Threat Hunting
Security Solution Threat Hunting Team
Team:Threat Hunting:Explore
v8.9.0
Project:Serverless MVP
labels
May 16, 2023
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
semd
added a commit
that referenced
this issue
May 17, 2023
## Summary This is a code cleaning to prepare for #157847 This PR removes the Landing Pages sub-plugin without introducing any noticeable change in the UX. All the logic of the Landing Pages sub-plugin has been relocated to the proper Explore and Management sub-plugins. The Dashboard sub-plugin landing page was also relocated in a previous PR. The common components used by the different landing page components (`LandingLinksIcons` and `LandingLinksImages`) have been relocated to _public/common/components/landing_links/*_. ### Benefits Cleaning of a non-necessary sub-plugin. Each Security sub-team will now own its landing page component, route, and link configuration. More consistent directory organization, and less complexity.
semd
added a commit
that referenced
this issue
May 31, 2023
part of: #157847 closes: #145718 ### Background The new navigation became the default navigation for Security on 8.4. To have a smooth transition we added an advanced setting to use the old navigation. Since then the legacy navigation has become outdated, there are links in Security that are not accessible through it, such as the landing pages for the sub-sections: - `/security/dashboards` - `/security/explore` - `/security/manage` With the introduction of the new Security AI design, more of those landing pages that are not compatible with the legacy navigation design will be added (e.g. Rules). And it was starting to become overcrowded since there was no possibility to collapse groups. Also, over time it has become harder and harder to maintain both versions at the same time, all the new pages added to security were having to duplicate the navigation configurations for both versions and also test everything twice. On top of that, the legacy navigation won't be supported on the Security Serverless projects, everything will work with the new one exclusively. ## Docs The Security documentation assumes the new navigation is used everywhere, there's no mention of the old navigation, only one small section about the advanced setting (which is actually outdated): https://www.elastic.co/guide/en/security/8.7/advanced-settings.html#_enable_grouped_navigation Which will need to be removed for 8.9. ## Summary Cleans the old navigation and the advanced setting (`securitySolution:enableGroupedNav`) to turn it on. Removes the telemetry (which shows almost no usage of it) and external dependencies as well. Only the new navigation will be available. All links should work only with the `app_links` architecture from now on. Old Nav ❌ ![old_nav](https://github.com/elastic/kibana/assets/17747913/b95ff48c-73d4-45f6-93e5-8bec3fb24052) New nav ✅ ![new_nav](https://github.com/elastic/kibana/assets/17747913/8695c63e-df97-4ffc-b504-b4f48a366b3b) --------- Co-authored-by: kibanamachine <[email protected]>
semd
added a commit
that referenced
this issue
Aug 15, 2023
## Summary closes: #157847 The new links and pages in Security Solution for Serverless: - `Investigations` - `Timelines` - `Osquery` - `Assets` - `Fleet` (and all its sub-links) - `Endpoints` (and all its sub-links) - `Cloud defend` (and all its sub-links) - Callout with button linking `Integrations` in Project Setting - `Project settings` - `Users & roles` (Cloud UI) - `Billing & consumption` (Cloud UI) - `Integrations` (link to integrations with _/browse/security_ path parameter) - `Entity risk score` (link currently under the `riskScoringRoutesEnabled` experimental flag) - `Management` accordion with a set of (stack) management categories and pages links Sections updated: (ESS & Serverless) `Rules` links have been updated according to new specs. (ESS) The `Settings` page was renamed back to `Manage`. (Serverless) The `Dev tools` link was moved to the bottom of the side navigation. #### Cypress tests for serverless: They will be implemented in a follow-up PR when the infrastructure is ready #162698 ## Screenshots ### Serverless Investigations: ![investigations](https://github.com/elastic/kibana/assets/17747913/19b602ab-53bb-4280-b0c3-dc69255ea3ab) ![investigations_panel](https://github.com/elastic/kibana/assets/17747913/8be036fc-6095-4234-8b07-1a7149c8a92b) Assets: ![assets](https://github.com/elastic/kibana/assets/17747913/963723d5-16da-45dd-955c-a7d7b61099e6) ![assets_panel](https://github.com/elastic/kibana/assets/17747913/977c0716-7cc3-4369-acdf-0787e264a912) Rules: ![rules](https://github.com/elastic/kibana/assets/17747913/5bafbd08-508c-4b50-bd28-dc052371e76a) ![rules_panel](https://github.com/elastic/kibana/assets/17747913/ea47f8d9-4b68-44f3-8a42-6f795d05b982) Project Settings: ![project_settings](https://github.com/elastic/kibana/assets/17747913/36dbb446-3354-4519-b59c-e8b5005fbb71) ![project_settings_panel](https://github.com/elastic/kibana/assets/17747913/1315b54b-4423-41a2-b0ed-997ee77c1f6d) ## ESS Side Navigation: ![ess_side_nav](https://github.com/elastic/kibana/assets/17747913/a3687a47-3ccb-4ce8-aa53-9e962a6ef1cf) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Tomasz Ciecierski <[email protected]> Co-authored-by: Tomasz Ciecierski <[email protected]>
bryce-b
pushed a commit
that referenced
this issue
Aug 22, 2023
## Summary closes: #157847 The new links and pages in Security Solution for Serverless: - `Investigations` - `Timelines` - `Osquery` - `Assets` - `Fleet` (and all its sub-links) - `Endpoints` (and all its sub-links) - `Cloud defend` (and all its sub-links) - Callout with button linking `Integrations` in Project Setting - `Project settings` - `Users & roles` (Cloud UI) - `Billing & consumption` (Cloud UI) - `Integrations` (link to integrations with _/browse/security_ path parameter) - `Entity risk score` (link currently under the `riskScoringRoutesEnabled` experimental flag) - `Management` accordion with a set of (stack) management categories and pages links Sections updated: (ESS & Serverless) `Rules` links have been updated according to new specs. (ESS) The `Settings` page was renamed back to `Manage`. (Serverless) The `Dev tools` link was moved to the bottom of the side navigation. #### Cypress tests for serverless: They will be implemented in a follow-up PR when the infrastructure is ready #162698 ## Screenshots ### Serverless Investigations: ![investigations](https://github.com/elastic/kibana/assets/17747913/19b602ab-53bb-4280-b0c3-dc69255ea3ab) ![investigations_panel](https://github.com/elastic/kibana/assets/17747913/8be036fc-6095-4234-8b07-1a7149c8a92b) Assets: ![assets](https://github.com/elastic/kibana/assets/17747913/963723d5-16da-45dd-955c-a7d7b61099e6) ![assets_panel](https://github.com/elastic/kibana/assets/17747913/977c0716-7cc3-4369-acdf-0787e264a912) Rules: ![rules](https://github.com/elastic/kibana/assets/17747913/5bafbd08-508c-4b50-bd28-dc052371e76a) ![rules_panel](https://github.com/elastic/kibana/assets/17747913/ea47f8d9-4b68-44f3-8a42-6f795d05b982) Project Settings: ![project_settings](https://github.com/elastic/kibana/assets/17747913/36dbb446-3354-4519-b59c-e8b5005fbb71) ![project_settings_panel](https://github.com/elastic/kibana/assets/17747913/1315b54b-4423-41a2-b0ed-997ee77c1f6d) ## ESS Side Navigation: ![ess_side_nav](https://github.com/elastic/kibana/assets/17747913/a3687a47-3ccb-4ce8-aa53-9e962a6ef1cf) --------- Co-authored-by: kibanamachine <[email protected]> Co-authored-by: Tomasz Ciecierski <[email protected]> Co-authored-by: Tomasz Ciecierski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Summary
Adapt the new IA design in the left navigation for serverless.
The UI changes will also apply to the ESS left navigation, but it won't contain any external link.
Changes
Only for serverless
Example
The text was updated successfully, but these errors were encountered: