Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Add alert start annotations on the preview charts #153850

Closed
Tracked by #145117
maryam-saeidi opened this issue Mar 28, 2023 · 0 comments · Fixed by #153954
Closed
Tracked by #145117

[AO] Add alert start annotations on the preview charts #153850

maryam-saeidi opened this issue Mar 28, 2023 · 0 comments · Fixed by #153954
Assignees
@maryam-saeidi
Labels
Feature:Alert Details Page Observability ux management team Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Mar 28, 2023 •
edited
Loading

📝 Summary

This ticket is about adding an alert start annotation.

image

✅ Acceptance Criteria

  • Add alert start annotations on the preview charts
@maryam-saeidi maryam-saeidi mentioned this issue Mar 28, 2023
Closed
41 tasks
@maryam-saeidi maryam-saeidi added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" Feature:Alert Details Page Observability ux management team v8.8.0 labels Mar 28, 2023
@maryam-saeidi maryam-saeidi mentioned this issue Mar 30, 2023
Merged
@maryam-saeidi maryam-saeidi self-assigned this Mar 30, 2023
maryam-saeidi added a commit that referenced this issue Apr 4, 2023
@maryam-saeidi @kibanamachine
[AO] Metric threshold alert details - custom time range and alert sta…
6350e14 
…rt annotation (#153954)

Closes #153202, closes #153850

## Summary

This PR adds alert start annotation and also uses a custom time range
for the alert details' charts depending on the alert duration. The logic
to calculate the time range was added in a separate package to be used
in other use cases as well.


![image](https://user-images.githubusercontent.com/12370520/228583927-bf90cc13-53d5-4824-9b3b-ed6e6ffd06f5.png)

## 🧪 How to test

Create a metric threshold alert and go to the related alert details
page, verify:
- Alert start annotation
- The time range of the charts should be before the alert was started
(1/8 of the duration was added to each side)

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
Feature:Alert Details Page Observability ux management team Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
1 participant
@maryam-saeidi