Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AO] Alert details page - Allow custom time range for metric threshold preview chart #153202

Closed
Tracked by #145117
maryam-saeidi opened this issue Mar 14, 2023 · 0 comments · Fixed by #153954
Closed
Tracked by #145117

[AO] Alert details page - Allow custom time range for metric threshold preview chart #153202

maryam-saeidi opened this issue Mar 14, 2023 · 0 comments · Fixed by #153954
Assignees
@maryam-saeidi
Labels
Feature:Alert Details Page Observability ux management team Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Mar 14, 2023 •
edited
Loading

📝 Summary

We need to be able to pass a custom time range to the preview chart to use it for the metric threshold rule details page.

✅ Acceptance Criteria

  • Allow passing custom time range to metric threshold preview chart
@maryam-saeidi maryam-saeidi mentioned this issue Mar 14, 2023
Closed
41 tasks
@maryam-saeidi maryam-saeidi changed the title Allow custom time for preview chart [AO] Allow custom time for preview chart Mar 14, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 14, 2023
@maryam-saeidi maryam-saeidi added the Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" label Mar 14, 2023
@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 14, 2023
@maryam-saeidi maryam-saeidi self-assigned this Mar 14, 2023
@maryam-saeidi maryam-saeidi changed the title [AO] Allow custom time for preview chart [AO] Alert details page - Allow custom time for preview chart Mar 14, 2023
@maryam-saeidi maryam-saeidi changed the title [AO] Alert details page - Allow custom time for preview chart [AO] Alert details page - Allow custom time range for metric threshold preview chart Mar 14, 2023
@maryam-saeidi maryam-saeidi added Feature:Alert Details Page Observability ux management team v8.8.0 labels Mar 30, 2023
@maryam-saeidi maryam-saeidi mentioned this issue Mar 30, 2023
Merged
maryam-saeidi added a commit that referenced this issue Apr 4, 2023
@maryam-saeidi @kibanamachine
[AO] Metric threshold alert details - custom time range and alert sta…
6350e14 
…rt annotation (#153954)

Closes #153202, closes #153850

## Summary

This PR adds alert start annotation and also uses a custom time range
for the alert details' charts depending on the alert duration. The logic
to calculate the time range was added in a separate package to be used
in other use cases as well.


![image](https://user-images.githubusercontent.com/12370520/228583927-bf90cc13-53d5-4824-9b3b-ed6e6ffd06f5.png)

## 🧪 How to test

Create a metric threshold alert and go to the related alert details
page, verify:
- Alert start annotation
- The time range of the charts should be before the alert was started
(1/8 of the duration was added to each side)

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
Feature:Alert Details Page Observability ux management team Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.8.0
Projects
None yet
Milestone
No milestone
1 participant
@maryam-saeidi