Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Remove version column from the Rules table #148196

Closed
Tracked by #174166
banderror opened this issue Dec 29, 2022 · 3 comments · Fixed by #149840
Closed
Tracked by #174166

[Security Solution] Remove version column from the Rules table #148196

banderror opened this issue Dec 29, 2022 · 3 comments · Fixed by #149840
Assignees
@xcrzx
Labels
8.7 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@banderror
Copy link
Contributor

banderror commented Dec 29, 2022 •
edited
Loading

Epic: https://github.com/elastic/security-team/issues/1974 (internal)

Summary

It was discussed a long time ago that the Version column in the Rules table is quite useless and it only consumes space.

Also, after #137168 it will show 0 for all custom rules regardless of the rule editing: i.e. when a user edits a custom rule the version field won't be updated because it will represent the version of the prebuilt content, which will be 0 for any custom rule.

Let's remove the column from the table.

Screenshot_2022-12-29_at_15_45_48
@banderror banderror added triage_needed Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area labels Dec 29, 2022
@banderror banderror self-assigned this Dec 29, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror assigned spong and unassigned banderror Dec 29, 2022
@banderror banderror mentioned this issue Jan 5, 2023
Closed
@spong spong mentioned this issue Feb 3, 2023
Merged
@xcrzx xcrzx assigned xcrzx and unassigned spong Feb 6, 2023
@xcrzx
Copy link
Contributor

xcrzx commented Feb 6, 2023

Removed in: #149840

xcrzx added a commit that referenced this issue Feb 7, 2023
@xcrzx
[Security Solution] Remove the advanced sorting switch from the rules…
4513f7b 
… management page (#149840)

**Resolves: #138907
**Resolves: #148196

## Summary

- Added missing `outcomeOrder` field to the alerting framework
- Removed the advanced sorting switch from the rules management page
- Both rules management and rules monitoring tables now have all columns
sortable, including indexing time, query time, last gap, and last
response
- Sorting now happens entirely on the server side. No in-memory
structures are needed.
- Removed the version column as intended in
#148196

There's one caveat, though. The running status is represented as a
different rule field. So when sorting by the last status, if there are
any "running" rules, they could appear in any row on the table:

![Screenshot 2023-01-31 at 16 18
29](https://user-images.githubusercontent.com/1938181/216108688-6abe9cb9-3307-4b72-9b6e-27a485a130d5.png)
@banderror banderror mentioned this issue Feb 21, 2023
Closed
4 tasks
@nastasha-solomon nastasha-solomon mentioned this issue Feb 21, 2023
Closed
@banderror banderror mentioned this issue Jan 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcrzx xcrzx

Labels
8.7 candidate Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Remove the advanced sorting switch from the rules management page xcrzx/kibana
4 participants
@xcrzx @spong @banderror @elasticmachine