Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Actionable Observability] Use shareable alert search bar on Rule details page #143962

Closed
Tracked by #134886
maryam-saeidi opened this issue Oct 25, 2022 · 1 comment · Fixed by #144718
Closed
Tracked by #134886

[Actionable Observability] Use shareable alert search bar on Rule details page #143962

maryam-saeidi opened this issue Oct 25, 2022 · 1 comment · Fixed by #144718
Assignees
@maryam-saeidi
Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0

Comments

@maryam-saeidi
Copy link
Member

📝 Summary

In this ticket, we want to use the shareable alert search bar and use it on the Rule details page. We also need to save the search bar state in the URL. Some of the shared logic with the Alerts page can be extracted into a separate component to be used in both places.

✅ Acceptance Criteria

  • Integrate the search bar on the rule details page and save the state in the URL
@maryam-saeidi maryam-saeidi added Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0 labels Oct 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi mentioned this issue Oct 25, 2022
Closed
14 tasks
@maryam-saeidi maryam-saeidi self-assigned this Oct 25, 2022
@maryam-saeidi maryam-saeidi mentioned this issue Nov 7, 2022
Merged
maryam-saeidi added a commit that referenced this issue Nov 9, 2022
@maryam-saeidi @kibanamachine
[Actionable Observability] Integrate alert search bar on rule details…
ef7c1a6 
… page (#144718)

Resolves #143962

## 📝 Summary
In this PR, an alerts search bar was added to the rule details page by
syncing its state to the URL. This will enable navigating to the alerts
table for a specific rule with a filtered state based on active or
recovered.
### Notes
- Renamed alert page container to alert search bar container and used it
both in alerts and rule details page (it will be responsible to sync
search bar params to the URL) --> moved to a shared component
- Moved AlertsStatusFilter to be a sub-component of the shared
observability search bar
- Allowed ObservabilityAlertSearchBar to be used both as a stand-alone
component and as a wired component with syncing params to the URL
(ObservabilityAlertSearchBar, ObservabilityAlertSearchbarWithUrlSync)
- Set a minHeight for the Alerts and Execution tab, otherwise, the page
will have extra scroll on the tab change while content is loading (very
annoying!)

## 🎨 Preview

![image](https://user-images.githubusercontent.com/12370520/200547324-d9c4ef3c-8a82-4c16-88bd-f1d4b2bc8006.png)

## 🧪 How to test
- Create a rule and go to the rule details page
- Click on the alerts tab and change the search criteria, you should be
able to see the criteria in the query parameter
- Refresh the page, alerts tab should be selected and you should be able
to see the filters that you applied in the previous step
- As a side test, check alert search bar on alerts page as well, it
should work as before

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryam-saeidi maryam-saeidi

Labels
Feature:Alerting Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Actionable Observability] Integrate alert search bar on rule details page maryam-saeidi/kibana
2 participants
@maryam-saeidi @elasticmachine