[Discover] Update unified histogram chart to use Lens #143108
Assignees
Labels
Feature:Discover
Discover Application
impact:high
Addressing this issue will have a high level of impact on the quality/strength of our product.
loe:large
Large Level of Effort
Team:DataDiscovery
Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
v8.7.0
Comments
davismcphee
added
Feature:Discover
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
This was referenced Oct 11, 2022
davismcphee
added a commit
that referenced
this issue
Dec 5, 2022
## Summary This PR updates Discover and Unified Histogram to use Lens for the histogram chart, and removes Discover as a Lens dependency:  Note that there are some additional changes to make in followup PRs before this will be ready for solutions adoption: - Add the ability for Unified Histogram to support manually refetching in addition to auto refetching. - Currently Unified Histogram watches for changes to the query, filters, and time range. We will need to update this so those dependencies are passed as props instead. - It would be helpful to add some usage documentation to Unified Histogram to help other teams implement it in their projects. A la carte deployment: https://davismcphee-pr-143117-enhancement-unified-histogram-lens.kbndev.co. Flaky test run: https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1571. Resolves #143108. Resolves #142390. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] ~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] ~Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~ - [ ] ~If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) Co-authored-by: Dzmitry Tamashevich <[email protected]> Co-authored-by: Matthias Wilhelm <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now that the work to create the
unifiedHistogramplugin has been completed in #141992, we need to update the chart to use Lens instead of a custom histogram chart. This will set the foundation for adding the breakdown functionality in a subsequent PR to wrap up the initial phase of the unified histogram project. The work covered in this issue should include the following:unifiedHistogramplugin to use Lens for the chart instead of a custom chart.unifiedHistogramchanges.The text was updated successfully, but these errors were encountered: