Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Implement unified histogram break down UI element #142390

Closed
kertal opened this issue Sep 30, 2022 · 1 comment · Fixed by #143117
Closed

[Discover] Implement unified histogram break down UI element #142390

kertal opened this issue Sep 30, 2022 · 1 comment · Fixed by #143117
Assignees
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0

Comments

@kertal
Copy link
Member

kertal commented Sep 30, 2022

TBD. Just a quick placeholder of the unified histogram breakdown UI widget
Bildschirmfoto 2022-09-30 um 18 44 27

@kertal kertal added Feature:Discover Discover Application Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Sep 30, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal kertal added v8.6.0 enhancement New value added to drive a business result labels Sep 30, 2022
@kertal kertal added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort labels Sep 30, 2022
@dimaanj dimaanj assigned davismcphee and unassigned dimaanj Oct 26, 2022
@davismcphee davismcphee added v8.7.0 and removed v8.6.0 labels Nov 18, 2022
davismcphee added a commit that referenced this issue Dec 5, 2022
## Summary

This PR updates Discover and Unified Histogram to use Lens for the
histogram chart, and removes Discover as a Lens dependency:

![discover_lens](https://user-images.githubusercontent.com/25592674/202795541-a7dc33d6-5529-4097-9de4-f2155fd81052.gif)

Note that there are some additional changes to make in followup PRs
before this will be ready for solutions adoption:
- Add the ability for Unified Histogram to support manually refetching
in addition to auto refetching.
- Currently Unified Histogram watches for changes to the query, filters,
and time range. We will need to update this so those dependencies are
passed as props instead.
- It would be helpful to add some usage documentation to Unified
Histogram to help other teams implement it in their projects.

A la carte deployment:
https://davismcphee-pr-143117-enhancement-unified-histogram-lens.kbndev.co.

Flaky test run:
https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/1571.

Resolves #143108.
Resolves #142390.

### Checklist

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
~[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials~
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] ~Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~
- [ ] ~If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

Co-authored-by: Dzmitry Tamashevich <[email protected]>
Co-authored-by: Matthias Wilhelm <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:large Large Level of Effort Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. v8.7.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants