Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tags selection dropdown on save panel is missing dark theme #142636

Closed
bhavyarm opened this issue Oct 4, 2022 · 4 comments
Closed

Tags selection dropdown on save panel is missing dark theme #142636

bhavyarm opened this issue Oct 4, 2022 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Object Tagging Saved Objects Tagging feature impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Oct 4, 2022

Kibana version: 8.5.0 BC2

Elasticsearch version: 8.5.0 BC2

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug: Tags selection input box on save dialog is missing dark theme application
Screen Shot 2022-10-04 at 12 17 34 PM
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Object Tagging Saved Objects Tagging feature labels Oct 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet
Copy link
Contributor

Linked (superseeded?) by https://github.com/elastic/kibana-team/issues/805

@clintandrewhall
Copy link
Contributor

clintandrewhall commented Nov 18, 2022 •
edited
Loading

This particular issue is due to @elastic/kibana-presentation having a component, loaded lazily, that isn't wrapped in a Theme Provider. The best fix would be to add the Theme Provider to the context provider in the Presentation Util plugin. The easiest way to do that would be to wrap the context provided by the plugin with the theme.

@clintandrewhall clintandrewhall added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Nov 18, 2022
@ThomThomson ThomThomson added loe:medium Medium Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed Feature:Maps labels Nov 21, 2022
@ThomThomson ThomThomson mentioned this issue Jan 18, 2023
Merged
nreese added a commit that referenced this issue Jan 19, 2023
@nreese @kibanamachine
fix 'Save modal dark theme issues in Discover, Dashboard, and Maps' (#…
d5f6fe8 
…149147)

Fixes #149130 and
#142636

PR updates `showSaveModal` to wrap modal in `KibanaThemeProvider` to
resolve dark theme issues. Rather than passing in theme$ as a new
parameter, theme$ is imported from within the plugin itself.

Co-authored-by: kibanamachine <[email protected]>
@nreese
Copy link
Contributor

nreese commented Jan 19, 2023

closed by #149147

@nreese nreese closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Object Tagging Saved Objects Tagging feature impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@clintandrewhall @nreese @pgayvallet @bhavyarm @Heenawter @ThomThomson @elasticmachine