Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kuery's use of implicit ANDs more clear #13563

Closed
trevan opened this issue Aug 17, 2017 · 1 comment
Closed

Make kuery's use of implicit ANDs more clear #13563

trevan opened this issue Aug 17, 2017 · 1 comment
Labels
Feature:Query Bar Querying and query bar features release_note:enhancement

Comments

@trevan
Copy link
Contributor

trevan commented Aug 17, 2017

I used makelogs to generate some logstash data and then ran the query "extension:jpg response:404" under both kuery and lucene.

In kuery, it found 5 items. In lucene, it found 56 items. That is because kuery uses AND to join the clauses while lucene uses OR to join the clauses.

Since keury can be identical to lucene, I think you'll have confusion from people who switch between the two or are using filters that they found elsewhere.

I can't seem to find any reason why it was decided to use AND as the implicit join in either #12624 (PR) or #12624 (Issue) but maybe there was internal discussion about it.

@Bargs
Copy link
Contributor

Bargs commented Aug 18, 2017

We made this decision intentionally. In my experience the implicit ORs in the lucene query syntax seem to be unintuitive for users. It's the opposite of how most query languages work.

You make a good point that the transition could be confusing though. I'll add more emphasis in the docs. I bet we can figure out a way to make this more obvious when we're working on autocomplete as well.

@Bargs Bargs changed the title kuery uses AND to join clauses while lucene uses OR to join clauses Make kuery's use of implicit ANDs more clear Aug 18, 2017
Bargs added a commit that referenced this issue Aug 18, 2017
…13592)

Fixes #13563

Brings additional attention to the fact that Kuery uses implicit ANDs whereas Lucene query syntax uses implicit ORs, which could confuse users if they're not aware of the difference.
Bargs added a commit to Bargs/kibana that referenced this issue Aug 18, 2017
…lastic#13592)

Fixes elastic#13563

Brings additional attention to the fact that Kuery uses implicit ANDs whereas Lucene query syntax uses implicit ORs, which could confuse users if they're not aware of the difference.
Bargs added a commit to Bargs/kibana that referenced this issue Aug 18, 2017
…lastic#13592)

Fixes elastic#13563

Brings additional attention to the fact that Kuery uses implicit ANDs whereas Lucene query syntax uses implicit ORs, which could confuse users if they're not aware of the difference.
Bargs added a commit that referenced this issue Aug 18, 2017
…13592) (#13593)

Fixes #13563

Brings additional attention to the fact that Kuery uses implicit ANDs whereas Lucene query syntax uses implicit ORs, which could confuse users if they're not aware of the difference.
Bargs added a commit that referenced this issue Aug 18, 2017
…13592) (#13594)

Fixes #13563

Brings additional attention to the fact that Kuery uses implicit ANDs whereas Lucene query syntax uses implicit ORs, which could confuse users if they're not aware of the difference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Query Bar Querying and query bar features release_note:enhancement
Projects
None yet
Development

No branches or pull requests

2 participants