Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Controls] [Meta] Engineering Phase 2 Implementation Roadmap #120035

Closed
16 of 23 tasks
ThomThomson opened this issue Nov 30, 2021 · 8 comments
Closed
16 of 23 tasks

[Controls] [Meta] Engineering Phase 2 Implementation Roadmap #120035

ThomThomson opened this issue Nov 30, 2021 · 8 comments
Labels
Feature:Input Control Input controls visualization impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Meta Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

ThomThomson commented Nov 30, 2021

Controls Phase 2

The following is an ordered list of tasks / PRs which need to be completed for the second phase of the controls project. By the end of this phase, deliverables will include:

  • A validation system for the Options List Control to show when previously selected values would result in an empty dashboard.
    • The options list control should have a new setting to control what happens to invalid selections. Possible settings could include: Remove, Ignore, & Apply
  • The ability to enable a Hierarchical Chaining mode which should be compatible with every type of control.
  • A new Range Slider control
  • A new Time Slider control
  • A new Time Picker control
  • Various upgrades to the Options List

Tasks / PRs

Options List Upgrades @ThomThomson

  • Show cardinality in Options List
  • Options List Static Mode For Booleans
  • Options List control validation

Hierarchical Chaining System @ThomThomson

  • Set up and maintain Input / Output subscription chain even when control order changes
  • Propagate filtering to child filters
  • Make Hierarchical Chaining optional

Range Slider @cqliu1 #125584

  • Create React component in storybook
  • State management
  • Create Inline Editor Component
  • Write embeddable and factory. Register control type

Time Slider @crob611

  • Create React component in storybook
  • State management
  • Create Inline Editor Component
  • Write embeddable and factory. Register control type

Time Picker

  • Create React component in storybook
  • State management
  • Create Inline Editor Component
  • Write embeddable and factory. Register control type

Administrative / Stability

Deprecation / Migration

POC

  • Test / POC render & interact in canvas
@ThomThomson ThomThomson added Meta Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Project:Controls labels Nov 30, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor Author

We can consider adding functionality to locally filter individual controls to allow users to narrow which options are shown in the control. This could be accomplished in the generic control editor because we know all controls can inherit filters, query and time range from the dashboard. See this issue for more info

@ghudgins
Copy link
Contributor

ghudgins commented Feb 3, 2022

a good wildcard request from controls from discuss user - https://discuss.elastic.co/t/wildcard-search-based-on-a-field-like-splunk/295250

@ThomThomson
Copy link
Contributor Author

ThomThomson commented Feb 3, 2022

A wildcard-based Search box control could be a good candidate for Controls phase 3. Basically this would be a new control type which shows only a search box, and anything written in the box would immediately be turned into a wildcard filter, without any validation.

@ThomThomson
Copy link
Contributor Author

A Query DSL templating feature would be extremely helpful for some control types. Specifically this request could be fulfilled with an Options List control configured to insert its selection into the key portion of a terms lookup query.

@ThomThomson
Copy link
Contributor Author

Something else to think about adding is configurable sorting for Options List controls.

Currently the sorting is handled by relevance (number of documents), but it's common for authors to want their controls sorted alphabetically.

Additionally, there have been a few requests for adding numeric sorting to the Options List control. I'm not sure if this is possible with Keyword mapped fields, but we can look into it. There are some relevant docs that might help us add this option.

@ThomThomson
Copy link
Contributor Author

ThomThomson commented Mar 2, 2022

Potential feature additions for phase 2 or phase 3:

@ThomThomson
Copy link
Contributor Author

Closing this as Controls Phase 2 is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Input Control Input controls visualization impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Meta Project:Controls Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants