[APM] Replace security plugin authc with Kibana core (#203771)

closes [#200700](#200700) ## Summary Replaces `authc` from `security` plugin with `core`'s as per https://docs.elastic.dev/kibana-dev-docs/api-meta/deprecated-api-list-by-plugin#apm Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 91e9995)
elastic · Dec 19, 2024 · 6f70393 · 6f70393
1 parent 2ac6186
commit 6f70393
Show file tree

Hide file tree

Showing 19 changed files with 83 additions and 163 deletions.
diff --git a/x-pack/platform/plugins/private/translations/translations/fr-FR.json b/x-pack/platform/plugins/private/translations/translations/fr-FR.json
@@ -10753,7 +10753,6 @@
     "xpack.apm.anomalyRuleType.anomalyDetector": "Types de détecteurs",
     "xpack.apm.anomalyRuleType.anomalyDetector.infoLabel": "Vous devez sélectionner au moins un détecteur",
     "xpack.apm.anomalyScore": "Anomalie {severity, select, minor {mineure} major {majeure} critical {critique} other {de sévérité inconnue}}",
-    "xpack.apm.api.apiKeys.securityRequired": "Le plug-in de sécurité est requis",
     "xpack.apm.api.fleet.cloud_apm_package_policy.requiredRoleOnCloud": "Opération autorisée uniquement pour les utilisateurs Elastic Cloud disposant du rôle de superutilisateur.",
     "xpack.apm.api.fleet.fleetSecurityRequired": "Les plug-ins Fleet et Security sont requis",
     "xpack.apm.api.storageExplorer.securityRequired": "Le plug-in de sécurité est requis",
@@ -49866,4 +49865,4 @@
     "xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "Ce champ est requis.",
     "xpack.watcher.watcherDescription": "Détectez les modifications survenant dans vos données en créant, gérant et monitorant des alertes."
   }
-}
+}
diff --git a/x-pack/platform/plugins/private/translations/translations/ja-JP.json b/x-pack/platform/plugins/private/translations/translations/ja-JP.json
@@ -10622,7 +10622,6 @@
     "xpack.apm.anomalyRuleType.anomalyDetector": "検知器タイプ",
     "xpack.apm.anomalyRuleType.anomalyDetector.infoLabel": "検知器を最低1つ選択する必要があります",
     "xpack.apm.anomalyScore": "{severity, select, minor {軽微な} major {重要な} critical {重大な} other {不明な重要度の}}異常",
-    "xpack.apm.api.apiKeys.securityRequired": "セキュリティプラグインが必要です",
     "xpack.apm.api.fleet.cloud_apm_package_policy.requiredRoleOnCloud": "スーパーユーザーロールが付与されたElastic Cloudユーザーのみが操作できます。",
     "xpack.apm.api.fleet.fleetSecurityRequired": "FleetおよびSecurityプラグインが必要です",
     "xpack.apm.api.storageExplorer.securityRequired": "セキュリティプラグインが必要です",
@@ -49714,4 +49713,4 @@
     "xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "フィールドを選択してください。",
     "xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。"
   }
-}
+}
diff --git a/x-pack/platform/plugins/private/translations/translations/zh-CN.json b/x-pack/platform/plugins/private/translations/translations/zh-CN.json
@@ -10673,7 +10673,6 @@
     "xpack.apm.anomalyRuleType.anomalyDetector": "检测工具类型",
     "xpack.apm.anomalyRuleType.anomalyDetector.infoLabel": "应至少选择一个检测工具",
     "xpack.apm.anomalyScore": "{severity, select, minor {轻微} major {重大} critical {严重} other {严重性未知}}异常",
-    "xpack.apm.api.apiKeys.securityRequired": "需要 Security 插件",
     "xpack.apm.api.fleet.cloud_apm_package_policy.requiredRoleOnCloud": "操作仅允许具有超级用户角色的 Elastic Cloud 用户执行。",
     "xpack.apm.api.fleet.fleetSecurityRequired": "需要 Fleet 和 Security 插件",
     "xpack.apm.api.storageExplorer.securityRequired": "需要 Security 插件",
@@ -49816,4 +49815,4 @@
     "xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "此字段必填。",
     "xpack.watcher.watcherDescription": "通过创建、管理和监测警报来检测数据中的更改。"
   }
-}
+}
diff --git a/...ck/plugins/observability_solution/apm/server/assistant_functions/get_apm_services_list.ts b/...ck/plugins/observability_solution/apm/server/assistant_functions/get_apm_services_list.ts
@@ -63,12 +63,13 @@ export function registerGetApmServicesListFunction({
       } as const,
     },
     async ({ arguments: args }, signal) => {
-      const { logger } = resources;
+      const { logger, core } = resources;
+      const coreStart = await core.start();
       const [apmAlertsClient, mlClient, randomSampler] = await Promise.all([
         getApmAlertsClient(resources),
         getMlClient(resources),
         getRandomSampler({
-          security: resources.plugins.security,
+          coreStart,
           probability: 1,
           request: resources.request,
         }),

diff --git a/x-pack/plugins/observability_solution/apm/server/assistant_functions/index.ts b/x-pack/plugins/observability_solution/apm/server/assistant_functions/index.ts
@@ -80,14 +80,12 @@ export function registerAssistantFunctions({
       },
     };
 
-    const {
-      request,
-      plugins: { security },
-    } = apmRouteHandlerResources;
+    const { request, core } = apmRouteHandlerResources;
 
+    const coreStart = await core.start();
     const [apmEventClient, randomSampler] = await Promise.all([
       getApmEventClient(apmRouteHandlerResources),
-      getRandomSampler({ security, request, probability: 1 }),
+      getRandomSampler({ coreStart, request, probability: 1 }),
     ]);
 
     const hasData = await hasHistoricalAgentData(apmEventClient);

diff --git a/x-pack/plugins/observability_solution/apm/server/lib/helpers/get_random_sampler/index.ts b/x-pack/plugins/observability_solution/apm/server/lib/helpers/get_random_sampler/index.ts
@@ -5,30 +5,26 @@
  * 2.0.
  */
 
-import { KibanaRequest } from '@kbn/core/server';
+import { CoreStart, KibanaRequest } from '@kbn/core/server';
 import seedrandom from 'seedrandom';
-import { APMRouteHandlerResources } from '../../../routes/apm_routes/register_apm_server_routes';
 
 export type RandomSampler = Awaited<ReturnType<typeof getRandomSampler>>;
 
 export async function getRandomSampler({
-  security,
+  coreStart,
   request,
   probability,
 }: {
-  security: APMRouteHandlerResources['plugins']['security'];
+  coreStart: CoreStart;
   request: KibanaRequest;
   probability: number;
 }) {
   let seed = 1;
 
-  if (security) {
-    const securityPluginStart = await security.start();
-    const username = securityPluginStart.authc.getCurrentUser(request)?.username;
+  const username = coreStart.security.authc.getCurrentUser(request)?.username;
 
-    if (username) {
-      seed = Math.abs(seedrandom(username).int32());
-    }
+  if (username) {
+    seed = Math.abs(seedrandom(username).int32());
   }
 
   return {

diff --git a/x-pack/plugins/observability_solution/apm/server/plugin.ts b/x-pack/plugins/observability_solution/apm/server/plugin.ts
@@ -223,7 +223,7 @@ export class APMPlugin
     );
 
     plugins.observability.alertDetailsContextualInsightsService.registerHandler(
-      getAlertDetailsContextHandler(resourcePlugins, logger)
+      getAlertDetailsContextHandler(getCoreStart(), resourcePlugins, logger)
     );
 
     return { config$ };

diff --git a/x-pack/plugins/observability_solution/apm/server/routes/agent_explorer/route.ts b/x-pack/plugins/observability_solution/apm/server/routes/agent_explorer/route.ts
@@ -33,18 +33,16 @@ const agentExplorerRoute = createApmServerRoute({
     ]),
   }),
   async handler(resources): Promise<AgentExplorerAgentsResponse> {
-    const {
-      params,
-      request,
-      plugins: { security },
-    } = resources;
+    const { params, request, core } = resources;
 
     const { environment, kuery, start, end, probability, serviceName, agentLanguage } =
       params.query;
 
+    const coreStart = await core.start();
+
     const [apmEventClient, randomSampler] = await Promise.all([
       getApmEventClient(resources),
-      getRandomSampler({ security, request, probability }),
+      getRandomSampler({ coreStart, request, probability }),
     ]);
 
     return getAgents({

diff --git a/.../plugins/observability_solution/apm/server/routes/agent_keys/get_agent_keys_privileges.ts b/.../plugins/observability_solution/apm/server/routes/agent_keys/get_agent_keys_privileges.ts
@@ -5,8 +5,8 @@
  * 2.0.
  */
 
+import { CoreStart } from '@kbn/core/server';
 import { ApmPluginRequestHandlerContext } from '../typings';
-import { APMPluginStartDependencies } from '../../types';
 
 export interface AgentKeysPrivilegesResponse {
   areApiKeysEnabled: boolean;
@@ -16,10 +16,10 @@ export interface AgentKeysPrivilegesResponse {
 
 export async function getAgentKeysPrivileges({
   context,
-  securityPluginStart,
+  coreStart,
 }: {
   context: ApmPluginRequestHandlerContext;
-  securityPluginStart: NonNullable<APMPluginStartDependencies['security']>;
+  coreStart: CoreStart;
 }): Promise<AgentKeysPrivilegesResponse> {
   const esClient = (await context.core).elasticsearch.client;
   const [securityHasPrivilegesResponse, areApiKeysEnabled] = await Promise.all([
@@ -28,7 +28,7 @@ export async function getAgentKeysPrivileges({
         cluster: ['manage_security', 'manage_api_key', 'manage_own_api_key'],
       },
     }),
-    securityPluginStart.authc.apiKeys.areAPIKeysEnabled(),
+    coreStart.security.authc.apiKeys.areAPIKeysEnabled(),
   ]);
 
   const {

diff --git a/x-pack/plugins/observability_solution/apm/server/routes/agent_keys/route.ts b/x-pack/plugins/observability_solution/apm/server/routes/agent_keys/route.ts
@@ -5,8 +5,6 @@
  * 2.0.
  */
 
-import Boom from '@hapi/boom';
-import { i18n } from '@kbn/i18n';
 import * as t from 'io-ts';
 import { createApmServerRoute } from '../apm_routes/create_apm_server_route';
 import { AgentKeysResponse, getAgentKeys } from './get_agent_keys';
@@ -33,19 +31,12 @@ const agentKeysPrivilegesRoute = createApmServerRoute({
   endpoint: 'GET /internal/apm/agent_keys/privileges',
   security: { authz: { requiredPrivileges: ['apm'] } },
   handler: async (resources): Promise<AgentKeysPrivilegesResponse> => {
-    const {
-      plugins: { security },
-      context,
-    } = resources;
+    const { context, core } = resources;
 
-    if (!security) {
-      throw Boom.internal(SECURITY_REQUIRED_MESSAGE);
-    }
-
-    const securityPluginStart = await security.start();
+    const coreStart = await core.start();
     const agentKeysPrivileges = await getAgentKeysPrivileges({
       context,
-      securityPluginStart,
+      coreStart,
     });
 
     return agentKeysPrivileges;
@@ -63,23 +54,15 @@ const invalidateAgentKeyRoute = createApmServerRoute({
     body: t.type({ id: t.string }),
   }),
   handler: async (resources): Promise<InvalidateAgentKeyResponse> => {
-    const {
-      context,
-      params,
-      plugins: { security },
-    } = resources;
+    const { context, params, core } = resources;
     const {
       body: { id },
     } = params;
 
-    if (!security) {
-      throw Boom.internal(SECURITY_REQUIRED_MESSAGE);
-    }
-
-    const securityPluginStart = await security.start();
+    const coreStart = await core.start();
     const { isAdmin } = await getAgentKeysPrivileges({
       context,
-      securityPluginStart,
+      coreStart,
     });
 
     const invalidatedKeys = await invalidateAgentKey({
@@ -126,7 +109,3 @@ export const agentKeysRouteRepository = {
   ...invalidateAgentKeyRoute,
   ...createAgentKeyRoute,
 };
-
-const SECURITY_REQUIRED_MESSAGE = i18n.translate('xpack.apm.api.apiKeys.securityRequired', {
-  defaultMessage: 'Security plugin is required',
-});
diff --git a/...on/apm/server/routes/assistant_functions/get_observability_alert_details_context/index.ts b/...on/apm/server/routes/assistant_functions/get_observability_alert_details_context/index.ts
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import { Logger } from '@kbn/core/server';
+import { CoreStart, Logger } from '@kbn/core/server';
 import type {
   AlertDetailsContextualInsight,
   AlertDetailsContextualInsightsHandler,
@@ -32,6 +32,7 @@ import { APMRouteHandlerResources } from '../../apm_routes/register_apm_server_r
 import { getApmErrors } from './get_apm_errors';
 
 export const getAlertDetailsContextHandler = (
+  coreStartPromise: Promise<CoreStart>,
   resourcePlugins: APMRouteHandlerResources['plugins'],
   logger: Logger
 ): AlertDetailsContextualInsightsHandler => {
@@ -64,6 +65,7 @@ export const getAlertDetailsContextHandler = (
       },
     };
 
+    const coreStart = await coreStartPromise;
     const [
       apmEventClient,
       annotationsClient,
@@ -81,7 +83,7 @@ export const getAlertDetailsContextHandler = (
       requestContext.core,
       getMlClient(resources),
       getRandomSampler({
-        security: resourcePlugins.security,
+        coreStart,
         probability: 1,
         request: requestContext.request,
       }),

diff --git a/x-pack/plugins/observability_solution/apm/server/routes/assistant_functions/route.ts b/x-pack/plugins/observability_solution/apm/server/routes/assistant_functions/route.ts
@@ -55,15 +55,12 @@ const getDownstreamDependenciesRoute = createApmServerRoute({
   }),
   security: { authz: { requiredPrivileges: ['apm'] } },
   handler: async (resources): Promise<{ content: APMDownstreamDependency[] }> => {
-    const {
-      params,
-      request,
-      plugins: { security },
-    } = resources;
+    const { params, request, core } = resources;
 
+    const coreStart = await core.start();
     const [apmEventClient, randomSampler] = await Promise.all([
       getApmEventClient(resources),
-      getRandomSampler({ security, request, probability: 1 }),
+      getRandomSampler({ coreStart, request, probability: 1 }),
     ]);
 
     const { query } = params;

diff --git a/x-pack/plugins/observability_solution/apm/server/routes/dependencies/route.ts b/x-pack/plugins/observability_solution/apm/server/routes/dependencies/route.ts
@@ -49,14 +49,12 @@ const topDependenciesRoute = createApmServerRoute({
   ]),
   security: { authz: { requiredPrivileges: ['apm'] } },
   handler: async (resources): Promise<TopDependenciesResponse> => {
-    const {
-      request,
-      plugins: { security },
-    } = resources;
+    const { request, core } = resources;
 
+    const coreStart = await core.start();
     const [apmEventClient, randomSampler] = await Promise.all([
       getApmEventClient(resources),
-      getRandomSampler({ security, request, probability: 1 }),
+      getRandomSampler({ coreStart, request, probability: 1 }),
     ]);
     const { environment, offset, numBuckets, kuery, start, end } = resources.params.query;
 
@@ -89,14 +87,12 @@ const upstreamServicesForDependencyRoute = createApmServerRoute({
   ]),
   security: { authz: { requiredPrivileges: ['apm'] } },
   handler: async (resources): Promise<UpstreamServicesForDependencyResponse> => {
-    const {
-      request,
-      plugins: { security },
-    } = resources;
+    const { request, core } = resources;
 
+    const coreStart = await core.start();
     const [apmEventClient, randomSampler] = await Promise.all([
       getApmEventClient(resources),
-      getRandomSampler({ security, request, probability: 1 }),
+      getRandomSampler({ coreStart, request, probability: 1 }),
     ]);
 
     const {

diff --git a/x-pack/plugins/observability_solution/apm/server/routes/fleet/is_superuser.ts b/x-pack/plugins/observability_solution/apm/server/routes/fleet/is_superuser.ts
@@ -5,16 +5,15 @@
  * 2.0.
  */
 
-import { KibanaRequest } from '@kbn/core/server';
-import { APMPluginStartDependencies } from '../../types';
+import { CoreStart, KibanaRequest } from '@kbn/core/server';
 
 export function isSuperuser({
-  securityPluginStart,
+  coreStart,
   request,
 }: {
-  securityPluginStart: NonNullable<APMPluginStartDependencies['security']>;
+  coreStart: CoreStart;
   request: KibanaRequest;
 }) {
-  const user = securityPluginStart.authc.getCurrentUser(request);
+  const user = coreStart.security.authc.getCurrentUser(request);
   return user?.roles.includes('superuser');
 }
diff --git a/x-pack/plugins/observability_solution/apm/server/routes/fleet/route.ts b/x-pack/plugins/observability_solution/apm/server/routes/fleet/route.ts
@@ -149,19 +149,17 @@ const createCloudApmPackagePolicyRoute = createApmServerRoute({
       throw Boom.internal(FLEET_SECURITY_REQUIRED_MESSAGE);
     }
 
-    const [savedObjectsClient, coreStart, fleetPluginStart, securityPluginStart, apmIndices] =
-      await Promise.all([
-        (await context.core).savedObjects.client,
-        resources.core.start(),
-        plugins.fleet.start(),
-        plugins.security.start(),
-        resources.getApmIndices(),
-      ]);
+    const [savedObjectsClient, coreStart, fleetPluginStart, apmIndices] = await Promise.all([
+      (await context.core).savedObjects.client,
+      resources.core.start(),
+      plugins.fleet.start(),
+      resources.getApmIndices(),
+    ]);
 
     const esClient = coreStart.elasticsearch.client.asScoped(resources.request).asCurrentUser;
     const cloudPluginSetup = plugins.cloud?.setup;
 
-    const hasRequiredRole = isSuperuser({ securityPluginStart, request });
+    const hasRequiredRole = isSuperuser({ coreStart, request });
     if (!hasRequiredRole || !cloudApmMigrationEnabled) {
       throw Boom.forbidden(CLOUD_SUPERUSER_REQUIRED_MESSAGE);
     }