Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Replace security plugin authc with Kibana core #203771

Merged

Conversation

crespocarlos
Copy link
Contributor

@crespocarlos crespocarlos commented Dec 11, 2024

closes #200700

Summary

Replaces authc from security plugin with core's as per https://docs.elastic.dev/kibana-dev-docs/api-meta/deprecated-api-list-by-plugin#apm

@crespocarlos
Copy link
Contributor Author

/ci

@crespocarlos crespocarlos force-pushed the 200700-replace-security-authc-with-core branch from b89104d to 9becae5 Compare December 11, 2024 13:03
@crespocarlos
Copy link
Contributor Author

/ci

@crespocarlos crespocarlos force-pushed the 200700-replace-security-authc-with-core branch from 9becae5 to 922edc5 Compare December 11, 2024 14:32
@crespocarlos
Copy link
Contributor Author

/ci

@crespocarlos crespocarlos marked this pull request as ready for review December 11, 2024 16:57
@crespocarlos crespocarlos requested a review from a team as a code owner December 11, 2024 16:57
@crespocarlos crespocarlos added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Dec 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Code review only

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Dec 13, 2024
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@crespocarlos
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: 7b1f204
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203771-7b1f204feb7f

History

@crespocarlos crespocarlos merged commit 91e9995 into elastic:main Dec 19, 2024
8 checks passed
@crespocarlos crespocarlos deleted the 200700-replace-security-authc-with-core branch December 19, 2024 09:16
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12409708380

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 19, 2024
closes [elastic#200700](elastic#200700)

## Summary

Replaces `authc` from `security` plugin with `core`'s as per
https://docs.elastic.dev/kibana-dev-docs/api-meta/deprecated-api-list-by-plugin#apm

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 91e9995)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 19, 2024
…204896)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[APM] Replace security plugin authc with Kibana core
(#203771)](#203771)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Carlos
Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-19T09:16:43Z","message":"[APM]
Replace security plugin authc with Kibana core (#203771)\n\ncloses
[#200700](https://github.com/elastic/kibana/issues/200700)\r\n\r\n##
Summary\r\n\r\nReplaces `authc` from `security` plugin with `core`'s as
per\r\nhttps://docs.elastic.dev/kibana-dev-docs/api-meta/deprecated-api-list-by-plugin#apm\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"91e99955f983b19e026d3aa16d5986198a867b7a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services"],"title":"[APM]
Replace security plugin authc with Kibana
core","number":203771,"url":"https://github.com/elastic/kibana/pull/203771","mergeCommit":{"message":"[APM]
Replace security plugin authc with Kibana core (#203771)\n\ncloses
[#200700](https://github.com/elastic/kibana/issues/200700)\r\n\r\n##
Summary\r\n\r\nReplaces `authc` from `security` plugin with `core`'s as
per\r\nhttps://docs.elastic.dev/kibana-dev-docs/api-meta/deprecated-api-list-by-plugin#apm\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"91e99955f983b19e026d3aa16d5986198a867b7a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203771","number":203771,"mergeCommit":{"message":"[APM]
Replace security plugin authc with Kibana core (#203771)\n\ncloses
[#200700](https://github.com/elastic/kibana/issues/200700)\r\n\r\n##
Summary\r\n\r\nReplaces `authc` from `security` plugin with `core`'s as
per\r\nhttps://docs.elastic.dev/kibana-dev-docs/api-meta/deprecated-api-list-by-plugin#apm\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"91e99955f983b19e026d3aa16d5986198a867b7a"}}]}]
BACKPORT-->

Co-authored-by: Carlos Crespo <[email protected]>
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[APM] Fix deprecated usage of authc
4 participants